From: Aurelien Jarno <aurelien@aurel32.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4/4] mips_malta: Catch kernels linked at wrong address
Date: Fri, 27 Jun 2014 10:43:56 +0200 [thread overview]
Message-ID: <20140627084355.GD10041@hall.aurel32.net> (raw)
In-Reply-To: <1403775865-25219-5-git-send-email-james.hogan@imgtec.com>
On Thu, Jun 26, 2014 at 10:44:25AM +0100, James Hogan wrote:
> Add error reporting if the wrong type of kernel is provided for the
> current mode of acceleration.
>
> Currently a KVM kernel linked at 0x40000000 can't be used with TCG, and
> a normal kernel linked at 0x80000000 can't be used with KVM.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/mips/mips_malta.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 76cf5f2c48f4..95df42e6a4d5 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -792,9 +792,23 @@ static int64_t load_kernel (void)
> loaderparams.kernel_filename);
> exit(1);
> }
> +
> + /* Sanity check where the kernel has been linked */
> if (kvm_enabled()) {
> + if (kernel_entry & 0x80000000ll) {
> + error_report("KVM guest kernels must be linked in useg. "
> + "Did you forget to enable CONFIG_KVM_GUEST?");
> + exit(1);
> + }
> +
> xlate_to_kseg0 = cpu_mips_kvm_um_phys_to_kseg0;
> } else {
> + if (!(kernel_entry & 0x80000000ll)) {
> + error_report("KVM guest kernels aren't supported with TCG. "
> + "Did you unintentionally enable CONFIG_KVM_GUEST?");
> + exit(1);
> + }
> +
> xlate_to_kseg0 = cpu_mips_phys_to_kseg0;
> }
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
WARNING: multiple messages have this Message-ID (diff)
From: Aurelien Jarno <aurelien@aurel32.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 4/4] mips_malta: Catch kernels linked at wrong address
Date: Fri, 27 Jun 2014 10:43:56 +0200 [thread overview]
Message-ID: <20140627084355.GD10041@hall.aurel32.net> (raw)
In-Reply-To: <1403775865-25219-5-git-send-email-james.hogan@imgtec.com>
On Thu, Jun 26, 2014 at 10:44:25AM +0100, James Hogan wrote:
> Add error reporting if the wrong type of kernel is provided for the
> current mode of acceleration.
>
> Currently a KVM kernel linked at 0x40000000 can't be used with TCG, and
> a normal kernel linked at 0x80000000 can't be used with KVM.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/mips/mips_malta.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
> index 76cf5f2c48f4..95df42e6a4d5 100644
> --- a/hw/mips/mips_malta.c
> +++ b/hw/mips/mips_malta.c
> @@ -792,9 +792,23 @@ static int64_t load_kernel (void)
> loaderparams.kernel_filename);
> exit(1);
> }
> +
> + /* Sanity check where the kernel has been linked */
> if (kvm_enabled()) {
> + if (kernel_entry & 0x80000000ll) {
> + error_report("KVM guest kernels must be linked in useg. "
> + "Did you forget to enable CONFIG_KVM_GUEST?");
> + exit(1);
> + }
> +
> xlate_to_kseg0 = cpu_mips_kvm_um_phys_to_kseg0;
> } else {
> + if (!(kernel_entry & 0x80000000ll)) {
> + error_report("KVM guest kernels aren't supported with TCG. "
> + "Did you unintentionally enable CONFIG_KVM_GUEST?");
> + exit(1);
> + }
> +
> xlate_to_kseg0 = cpu_mips_phys_to_kseg0;
> }
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2014-06-27 8:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 9:44 [PATCH 0/4] QEMU MIPS KVM improvements for v2.1 James Hogan
2014-06-26 9:44 ` [Qemu-devel] " James Hogan
2014-06-26 9:44 ` [PATCH 1/4] mips/kvm: Init EBase to correct KSEG0 James Hogan
2014-06-26 9:44 ` [Qemu-devel] " James Hogan
2014-06-27 8:41 ` Aurelien Jarno
2014-06-27 8:41 ` [Qemu-devel] " Aurelien Jarno
2014-06-26 9:44 ` [PATCH 2/4] mips_malta: Change default KVM cpu to 24Kc (no FP) James Hogan
2014-06-26 9:44 ` [Qemu-devel] " James Hogan
2014-06-27 8:43 ` Aurelien Jarno
2014-06-27 8:43 ` [Qemu-devel] " Aurelien Jarno
2014-06-27 11:33 ` Paolo Bonzini
2014-06-27 11:33 ` [Qemu-devel] " Paolo Bonzini
2014-06-27 15:22 ` [PATCH v2 2/4] mips/kvm: Disable FPU on reset with KVM James Hogan
2014-06-27 15:22 ` [Qemu-devel] " James Hogan
2014-06-26 9:44 ` [PATCH 3/4] mips_malta: Remove incorrect KVM T&E references James Hogan
2014-06-26 9:44 ` [Qemu-devel] " James Hogan
2014-06-27 8:43 ` Aurelien Jarno
2014-06-27 8:43 ` [Qemu-devel] " Aurelien Jarno
2014-06-26 9:44 ` [PATCH 4/4] mips_malta: Catch kernels linked at wrong address James Hogan
2014-06-26 9:44 ` [Qemu-devel] " James Hogan
2014-06-27 8:43 ` Aurelien Jarno [this message]
2014-06-27 8:43 ` Aurelien Jarno
2014-06-26 10:12 ` [PATCH 0/4] QEMU MIPS KVM improvements for v2.1 Paolo Bonzini
2014-06-26 10:12 ` [Qemu-devel] " Paolo Bonzini
2014-06-26 11:27 ` James Hogan
2014-06-26 11:27 ` [Qemu-devel] " James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627084355.GD10041@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.