From: Mark Brown <broonie@kernel.org>
To: Andy Gross <agross@codeaurora.org>
Cc: linux-spi@vger.kernel.org, Sagar Dharia <sdharia@codeaurora.org>,
Daniel Sneddon <dsneddon@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] spi: qup: Add DMA capabilities
Date: Fri, 27 Jun 2014 11:50:57 +0100 [thread overview]
Message-ID: <20140627105057.GF23300@sirena.org.uk> (raw)
In-Reply-To: <1403816781-31008-1-git-send-email-agross@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
On Thu, Jun 26, 2014 at 04:06:21PM -0500, Andy Gross wrote:
> + if (xfer->rx_buf) {
> + rx_dma = dma_map_single(controller->dev, xfer->rx_buf,
> + xfer->len, DMA_FROM_DEVICE);
It would be better to use the core DMA mapping code rather than open
coding. This code won't work for vmalloc()ed addresses, or physically
non-contiguous addresses unless there's an IOMMU fixing things up.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: qup: Add DMA capabilities
Date: Fri, 27 Jun 2014 11:50:57 +0100 [thread overview]
Message-ID: <20140627105057.GF23300@sirena.org.uk> (raw)
In-Reply-To: <1403816781-31008-1-git-send-email-agross@codeaurora.org>
On Thu, Jun 26, 2014 at 04:06:21PM -0500, Andy Gross wrote:
> + if (xfer->rx_buf) {
> + rx_dma = dma_map_single(controller->dev, xfer->rx_buf,
> + xfer->len, DMA_FROM_DEVICE);
It would be better to use the core DMA mapping code rather than open
coding. This code won't work for vmalloc()ed addresses, or physically
non-contiguous addresses unless there's an IOMMU fixing things up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140627/0c812691/attachment.sig>
next prev parent reply other threads:[~2014-06-27 10:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 21:06 [PATCH] spi: qup: Add DMA capabilities Andy Gross
2014-06-26 21:06 ` Andy Gross
2014-06-27 10:50 ` Mark Brown [this message]
2014-06-27 10:50 ` Mark Brown
2014-06-27 15:54 ` Andy Gross
2014-06-27 15:54 ` Andy Gross
2014-06-27 16:24 ` Russell King - ARM Linux
2014-06-27 16:24 ` Russell King - ARM Linux
[not found] ` <20140627162411.GO32514-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-06-27 18:58 ` Andy Gross
2014-06-27 18:58 ` Andy Gross
2014-06-27 18:58 ` Andy Gross
[not found] ` <1403816781-31008-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-07-02 14:26 ` Ivan T. Ivanov
2014-07-02 14:26 ` Ivan T. Ivanov
2014-07-02 14:26 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627105057.GF23300@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=dsneddon@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.