* [PATCH net-next] xfrm4: Remove duplicate semicolon
@ 2014-06-28 12:12 Christoph Paasch
2014-06-30 9:20 ` Steffen Klassert
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Paasch @ 2014-06-28 12:12 UTC (permalink / raw)
To: netdev; +Cc: David Miller, Steffen Klassert, Herbert Xu
3328715e6c1fc (xfrm4: Add IPsec protocol multiplexer) adds a
duplicate semicolon after the return-statement.
Although it has no negative impact, the second semicolon should be
removed.
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
---
net/ipv4/xfrm4_protocol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/xfrm4_protocol.c b/net/ipv4/xfrm4_protocol.c
index a2ce0101eaac..dccefa9d84cf 100644
--- a/net/ipv4/xfrm4_protocol.c
+++ b/net/ipv4/xfrm4_protocol.c
@@ -124,7 +124,7 @@ static int xfrm4_ah_rcv(struct sk_buff *skb)
for_each_protocol_rcu(ah4_handlers, handler)
if ((ret = handler->handler(skb)) != -EINVAL)
- return ret;;
+ return ret;
icmp_send(skb, ICMP_DEST_UNREACH, ICMP_PORT_UNREACH, 0);
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] xfrm4: Remove duplicate semicolon
2014-06-28 12:12 [PATCH net-next] xfrm4: Remove duplicate semicolon Christoph Paasch
@ 2014-06-30 9:20 ` Steffen Klassert
0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2014-06-30 9:20 UTC (permalink / raw)
To: Christoph Paasch; +Cc: netdev, David Miller, Herbert Xu
On Sat, Jun 28, 2014 at 02:12:44PM +0200, Christoph Paasch wrote:
> 3328715e6c1fc (xfrm4: Add IPsec protocol multiplexer) adds a
> duplicate semicolon after the return-statement.
>
> Although it has no negative impact, the second semicolon should be
> removed.
>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Applied to ipsec-next, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-30 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-28 12:12 [PATCH net-next] xfrm4: Remove duplicate semicolon Christoph Paasch
2014-06-30 9:20 ` Steffen Klassert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.