From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: mvebu: add armada drm init to Dove board setup
Date: Tue, 1 Jul 2014 14:10:26 +0100 [thread overview]
Message-ID: <20140701131026.GO32514@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1404219871-18419-5-git-send-email-sebastian.hesselbarth@gmail.com>
On Tue, Jul 01, 2014 at 03:04:31PM +0200, Sebastian Hesselbarth wrote:
> + pdev = platform_device_register_full(&armada_drm_dev_info);
> + /* assign last found lcd node to drm device for clk lookup */
> + pdev->dev.of_node = clknp;
NAK. This really isn't a good way to deal with this, even in a
temporary basis. While assigning a DT node to a manually created
platform device does solve that problem, it also introduces the
problem that this platform device will now match any platform driver
which recognises the "marvell,dove-lcd" compatible type, which may
occur _before_ we find the driver to match using the legacy strings.
There really isn't an easy solution to this other than doing the thing
properly.
The other problem in this series is that while you introduce some
bindings which may work today, they're not going to work tomorrow, and
that's a problem. Don't do DT piecemeal like this and end up having to
break the bindings (which we will have to do to add the endpoints.)
If you want to do this then you need to add the endpoints from the start
even though the driver doesn't yet make use of them - or don't add the
DT bits at all.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: mvebu: add armada drm init to Dove board setup
Date: Tue, 1 Jul 2014 14:10:26 +0100 [thread overview]
Message-ID: <20140701131026.GO32514@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1404219871-18419-5-git-send-email-sebastian.hesselbarth@gmail.com>
On Tue, Jul 01, 2014 at 03:04:31PM +0200, Sebastian Hesselbarth wrote:
> + pdev = platform_device_register_full(&armada_drm_dev_info);
> + /* assign last found lcd node to drm device for clk lookup */
> + pdev->dev.of_node = clknp;
NAK. This really isn't a good way to deal with this, even in a
temporary basis. While assigning a DT node to a manually created
platform device does solve that problem, it also introduces the
problem that this platform device will now match any platform driver
which recognises the "marvell,dove-lcd" compatible type, which may
occur _before_ we find the driver to match using the legacy strings.
There really isn't an easy solution to this other than doing the thing
properly.
The other problem in this series is that while you introduce some
bindings which may work today, they're not going to work tomorrow, and
that's a problem. Don't do DT piecemeal like this and end up having to
break the bindings (which we will have to do to add the endpoints.)
If you want to do this then you need to add the endpoints from the start
even though the driver doesn't yet make use of them - or don't add the
DT bits at all.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-07-01 13:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 13:04 [PATCH 0/4] Marvell Dove DRM for DT Sebastian Hesselbarth
2014-07-01 13:04 ` Sebastian Hesselbarth
2014-07-01 13:04 ` [PATCH 1/4] dt-bindings: add Marvell Dove LCD controller documentation Sebastian Hesselbarth
2014-07-01 13:04 ` Sebastian Hesselbarth
2014-07-01 13:04 ` [PATCH 2/4] ARM: dts: dove: add DT LCD controllers Sebastian Hesselbarth
2014-07-01 13:04 ` Sebastian Hesselbarth
2014-07-01 13:04 ` Sebastian Hesselbarth
2014-07-01 13:04 ` [PATCH 3/4] ARM: dts: dove: enable lcd0 on SolidRun CuBox Sebastian Hesselbarth
2014-07-01 13:04 ` Sebastian Hesselbarth
2014-07-01 13:04 ` Sebastian Hesselbarth
2014-07-01 13:18 ` Mark Rutland
2014-07-01 13:18 ` Mark Rutland
2014-07-01 13:18 ` Mark Rutland
2014-07-01 15:40 ` Jean-Francois Moine
2014-07-01 15:40 ` Jean-Francois Moine
2014-07-01 15:40 ` Jean-Francois Moine
2014-07-01 13:04 ` [PATCH 4/4] ARM: mvebu: add armada drm init to Dove board setup Sebastian Hesselbarth
2014-07-01 13:04 ` Sebastian Hesselbarth
2014-07-01 13:10 ` Russell King - ARM Linux [this message]
2014-07-01 13:10 ` Russell King - ARM Linux
2014-07-01 13:21 ` Sebastian Hesselbarth
2014-07-01 13:21 ` Sebastian Hesselbarth
2014-07-01 13:36 ` Russell King - ARM Linux
2014-07-01 13:36 ` Russell King - ARM Linux
2014-07-01 13:40 ` Sebastian Hesselbarth
2014-07-01 13:40 ` Sebastian Hesselbarth
2014-07-01 13:42 ` Russell King - ARM Linux
2014-07-01 13:42 ` Russell King - ARM Linux
2014-07-01 16:04 ` Jean-Francois Moine
2014-07-01 16:04 ` Jean-Francois Moine
2014-07-01 16:45 ` Russell King - ARM Linux
2014-07-01 16:45 ` Russell King - ARM Linux
2014-07-01 17:49 ` Jean-Francois Moine
2014-07-01 17:49 ` Jean-Francois Moine
2014-07-01 22:00 ` Russell King - ARM Linux
2014-07-01 22:00 ` Russell King - ARM Linux
2014-07-01 16:53 ` Jason Cooper
2014-07-01 16:53 ` Jason Cooper
2014-07-01 17:06 ` Russell King - ARM Linux
2014-07-01 17:06 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701131026.GO32514@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.