[PATCH] Bluetooth: Enforce providing hdev->send driver callback

[PATCH] Bluetooth: Enforce providing hdev->send driver callback

[Marcel Holtmann]

The hdev->send driver callback is mandatory to be provided by a driver
before calling hci_register_dev. So enforce it and return EINVAL in
case it is not available.

All existing drivers are providing this callback anyway, so this is
just an extra sanity check.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
 net/bluetooth/hci_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index b02454ab07ee..623ffe0da4a6 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3932,7 +3932,7 @@ int hci_register_dev(struct hci_dev *hdev)
 {
 	int id, error;
 
-	if (!hdev->open || !hdev->close)
+	if (!hdev->open || !hdev->close || !hdev->send)
 		return -EINVAL;
 
 	/* Do not allow HCI_AMP devices to register at index 0,
-- 
1.9.3

Re: [PATCH] Bluetooth: Enforce providing hdev->send driver callback

[Johan Hedberg]

Hi Marcel,

On Sun, Jul 06, 2014, Marcel Holtmann wrote:
> The hdev->send driver callback is mandatory to be provided by a driver
> before calling hci_register_dev. So enforce it and return EINVAL in
> case it is not available.
> 
> All existing drivers are providing this callback anyway, so this is
> just an extra sanity check.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/bluetooth/hci_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to bluetooth-next. Thanks.

Johan