* [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()
@ 2014-07-03 1:31 ` Nicholas Krause
0 siblings, 0 replies; 4+ messages in thread
From: Nicholas Krause @ 2014-07-03 1:31 UTC (permalink / raw)
To: tony; +Cc: linux, linux-omap, linux-arm-kernel, linux-kernel
This removes the FIXME message above ocpi_enable being declared
for proper locking in this function. As of the current kernel
verisons there is no need for locking as only one driver uses
this function currently and therefore there is no need for real
locking requirements.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/arm/mach-omap1/ocpi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-omap1/ocpi.c b/arch/arm/mach-omap1/ocpi.c
index 238170c..44a3d19 100644
--- a/arch/arm/mach-omap1/ocpi.c
+++ b/arch/arm/mach-omap1/ocpi.c
@@ -55,7 +55,6 @@ static struct clk *ocpi_ck;
/*
* Enables device access to OMAP buses via the OCPI bridge
- * FIXME: Add locking
*/
int ocpi_enable(void)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()
@ 2014-07-03 1:31 ` Nicholas Krause
0 siblings, 0 replies; 4+ messages in thread
From: Nicholas Krause @ 2014-07-03 1:31 UTC (permalink / raw)
To: linux-arm-kernel
This removes the FIXME message above ocpi_enable being declared
for proper locking in this function. As of the current kernel
verisons there is no need for locking as only one driver uses
this function currently and therefore there is no need for real
locking requirements.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/arm/mach-omap1/ocpi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-omap1/ocpi.c b/arch/arm/mach-omap1/ocpi.c
index 238170c..44a3d19 100644
--- a/arch/arm/mach-omap1/ocpi.c
+++ b/arch/arm/mach-omap1/ocpi.c
@@ -55,7 +55,6 @@ static struct clk *ocpi_ck;
/*
* Enables device access to OMAP buses via the OCPI bridge
- * FIXME: Add locking
*/
int ocpi_enable(void)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()
2014-07-03 1:31 ` Nicholas Krause
@ 2014-07-08 8:16 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2014-07-08 8:16 UTC (permalink / raw)
To: Nicholas Krause; +Cc: linux, linux-omap, linux-arm-kernel, linux-kernel
* Nicholas Krause <xerofoify@gmail.com> [140702 18:33]:
> This removes the FIXME message above ocpi_enable being declared
> for proper locking in this function. As of the current kernel
> verisons there is no need for locking as only one driver uses
> this function currently and therefore there is no need for real
> locking requirements.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Thanks applying into omap-for-v3.17/fixes-not-urgent.
Tony
> ---
> arch/arm/mach-omap1/ocpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/ocpi.c b/arch/arm/mach-omap1/ocpi.c
> index 238170c..44a3d19 100644
> --- a/arch/arm/mach-omap1/ocpi.c
> +++ b/arch/arm/mach-omap1/ocpi.c
> @@ -55,7 +55,6 @@ static struct clk *ocpi_ck;
>
> /*
> * Enables device access to OMAP buses via the OCPI bridge
> - * FIXME: Add locking
> */
> int ocpi_enable(void)
> {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable()
@ 2014-07-08 8:16 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2014-07-08 8:16 UTC (permalink / raw)
To: linux-arm-kernel
* Nicholas Krause <xerofoify@gmail.com> [140702 18:33]:
> This removes the FIXME message above ocpi_enable being declared
> for proper locking in this function. As of the current kernel
> verisons there is no need for locking as only one driver uses
> this function currently and therefore there is no need for real
> locking requirements.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Thanks applying into omap-for-v3.17/fixes-not-urgent.
Tony
> ---
> arch/arm/mach-omap1/ocpi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/ocpi.c b/arch/arm/mach-omap1/ocpi.c
> index 238170c..44a3d19 100644
> --- a/arch/arm/mach-omap1/ocpi.c
> +++ b/arch/arm/mach-omap1/ocpi.c
> @@ -55,7 +55,6 @@ static struct clk *ocpi_ck;
>
> /*
> * Enables device access to OMAP buses via the OCPI bridge
> - * FIXME: Add locking
> */
> int ocpi_enable(void)
> {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-08 8:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-03 1:31 [PATCH] omap16xx: Removes fixme no longer needed in ocpi_enable() Nicholas Krause
2014-07-03 1:31 ` Nicholas Krause
2014-07-08 8:16 ` Tony Lindgren
2014-07-08 8:16 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.