* [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations
@ 2014-06-25 15:25 Cheng-Wei Lee
2014-07-08 10:28 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Cheng-Wei Lee @ 2014-06-25 15:25 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sherif Shehab Aldin, Avinash Kumar,
Peter Senna Tschudin
Cc: devel, linux-kernel
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 07cee56..99e2f2d 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3533,7 +3533,7 @@ static void hfa384x_usbin_rx(wlandevice_t
*wlandev, struct sk_buff *skb)
}
done:
- return;
+ pr_debug("hfa384x_usbin_rx: done\n");
}
/*----------------------------------------------------------------
@@ -3643,8 +3643,6 @@ static void hfa384x_int_rxmonitor(wlandevice_t *wlandev,
/* pass it back up */
prism2sta_ev_rx(wlandev, skb);
-
- return;
}
/*----------------------------------------------------------------
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations
2014-06-25 15:25 [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations Cheng-Wei Lee
@ 2014-07-08 10:28 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-07-08 10:28 UTC (permalink / raw)
To: Cheng-Wei Lee
Cc: Greg Kroah-Hartman, Sherif Shehab Aldin, Avinash Kumar,
Peter Senna Tschudin, devel, linux-kernel
On Wed, Jun 25, 2014 at 11:25:33PM +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 07cee56..99e2f2d 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3533,7 +3533,7 @@ static void hfa384x_usbin_rx(wlandevice_t
> *wlandev, struct sk_buff *skb)
> }
>
> done:
> - return;
> + pr_debug("hfa384x_usbin_rx: done\n");
Don't add this stuff. Just delete the useless label.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-08 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-25 15:25 [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations Cheng-Wei Lee
2014-07-08 10:28 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.