* [PATCH V2] ASoC: omap-mcbsp: Use devm_snd_soc_register_component
@ 2014-07-08 16:25 Manish Badarkhe
2014-07-09 5:45 ` Peter Ujfalusi
2014-07-09 8:15 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Manish Badarkhe @ 2014-07-08 16:25 UTC (permalink / raw)
To: linux-omap, alsa-devel; +Cc: broonie, peter.ujfalusi, badarkhe.manish
Replaced snd_soc_register_component with its devres equivalent,
devm_snd_soc_register_component.
Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
---
Changes since V1:
Aligned function parameter properly.
:100644 100644 efe2cd6... bd3ef2a... M sound/soc/omap/omap-mcbsp.c
sound/soc/omap/omap-mcbsp.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index efe2cd6..bd3ef2a 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -805,8 +805,9 @@ static int asoc_mcbsp_probe(struct platform_device *pdev)
if (ret)
return ret;
- ret = snd_soc_register_component(&pdev->dev, &omap_mcbsp_component,
- &omap_mcbsp_dai, 1);
+ ret = devm_snd_soc_register_component(&pdev->dev,
+ &omap_mcbsp_component,
+ &omap_mcbsp_dai, 1);
if (ret)
return ret;
@@ -817,8 +818,6 @@ static int asoc_mcbsp_remove(struct platform_device *pdev)
{
struct omap_mcbsp *mcbsp = platform_get_drvdata(pdev);
- snd_soc_unregister_component(&pdev->dev);
-
if (mcbsp->pdata->ops && mcbsp->pdata->ops->free)
mcbsp->pdata->ops->free(mcbsp->id);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] ASoC: omap-mcbsp: Use devm_snd_soc_register_component
2014-07-08 16:25 [PATCH V2] ASoC: omap-mcbsp: Use devm_snd_soc_register_component Manish Badarkhe
@ 2014-07-09 5:45 ` Peter Ujfalusi
2014-07-09 8:15 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2014-07-09 5:45 UTC (permalink / raw)
To: Manish Badarkhe, linux-omap, alsa-devel; +Cc: broonie
On 07/08/2014 07:25 PM, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.
>
> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Changes since V1:
> Aligned function parameter properly.
>
> :100644 100644 efe2cd6... bd3ef2a... M sound/soc/omap/omap-mcbsp.c
> sound/soc/omap/omap-mcbsp.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
> index efe2cd6..bd3ef2a 100644
> --- a/sound/soc/omap/omap-mcbsp.c
> +++ b/sound/soc/omap/omap-mcbsp.c
> @@ -805,8 +805,9 @@ static int asoc_mcbsp_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - ret = snd_soc_register_component(&pdev->dev, &omap_mcbsp_component,
> - &omap_mcbsp_dai, 1);
> + ret = devm_snd_soc_register_component(&pdev->dev,
> + &omap_mcbsp_component,
> + &omap_mcbsp_dai, 1);
> if (ret)
> return ret;
>
> @@ -817,8 +818,6 @@ static int asoc_mcbsp_remove(struct platform_device *pdev)
> {
> struct omap_mcbsp *mcbsp = platform_get_drvdata(pdev);
>
> - snd_soc_unregister_component(&pdev->dev);
> -
> if (mcbsp->pdata->ops && mcbsp->pdata->ops->free)
> mcbsp->pdata->ops->free(mcbsp->id);
>
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] ASoC: omap-mcbsp: Use devm_snd_soc_register_component
2014-07-08 16:25 [PATCH V2] ASoC: omap-mcbsp: Use devm_snd_soc_register_component Manish Badarkhe
2014-07-09 5:45 ` Peter Ujfalusi
@ 2014-07-09 8:15 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-07-09 8:15 UTC (permalink / raw)
To: Manish Badarkhe; +Cc: linux-omap, alsa-devel, peter.ujfalusi
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
On Tue, Jul 08, 2014 at 09:55:23PM +0530, Manish Badarkhe wrote:
> Replaced snd_soc_register_component with its devres equivalent,
> devm_snd_soc_register_component.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-09 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-08 16:25 [PATCH V2] ASoC: omap-mcbsp: Use devm_snd_soc_register_component Manish Badarkhe
2014-07-09 5:45 ` Peter Ujfalusi
2014-07-09 8:15 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.