* [patch] crypto: qat - remove an unneeded cast
@ 2014-07-08 10:59 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-07-08 10:59 UTC (permalink / raw)
To: Tadeusz Struk
Cc: Herbert Xu, David S. Miller, Bruce Allan, Pingchaox Yang, Bo Cui,
qat-linux, linux-crypto, kernel-janitors
The cast to (unsigned int *) doesn't hurt anything but it is pointless.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
index 903ca88..28da876 100644
--- a/drivers/crypto/qat/qat_common/qat_hal.c
+++ b/drivers/crypto/qat/qat_common/qat_hal.c
@@ -850,7 +850,7 @@ static int qat_hal_exec_micro_inst(struct icp_qat_fw_loader_handle *handle,
if ((inst_num > handle->hal_handle->max_ustore) || !micro_inst) {
pr_err("QAT: invalid instructs inst_num=%d, micro_inst=0x%p\n ",
- inst_num, (unsigned int *)micro_inst);
+ inst_num, micro_inst);
return -EINVAL;
}
/* save current context */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] crypto: qat - remove an unneeded cast
@ 2014-07-08 10:59 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-07-08 10:59 UTC (permalink / raw)
To: Tadeusz Struk
Cc: Herbert Xu, David S. Miller, Bruce Allan, Pingchaox Yang, Bo Cui,
qat-linux, linux-crypto, kernel-janitors
The cast to (unsigned int *) doesn't hurt anything but it is pointless.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c
index 903ca88..28da876 100644
--- a/drivers/crypto/qat/qat_common/qat_hal.c
+++ b/drivers/crypto/qat/qat_common/qat_hal.c
@@ -850,7 +850,7 @@ static int qat_hal_exec_micro_inst(struct icp_qat_fw_loader_handle *handle,
if ((inst_num > handle->hal_handle->max_ustore) || !micro_inst) {
pr_err("QAT: invalid instructs inst_num=%d, micro_inst=0x%p\n ",
- inst_num, (unsigned int *)micro_inst);
+ inst_num, micro_inst);
return -EINVAL;
}
/* save current context */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] crypto: qat - remove an unneeded cast
2014-07-08 10:59 ` Dan Carpenter
@ 2014-07-10 9:00 ` Herbert Xu
-1 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2014-07-10 9:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tadeusz Struk, David S. Miller, Bruce Allan, Pingchaox Yang,
Bo Cui, qat-linux, linux-crypto, kernel-janitors
On Tue, Jul 08, 2014 at 01:59:07PM +0300, Dan Carpenter wrote:
> The cast to (unsigned int *) doesn't hurt anything but it is pointless.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] crypto: qat - remove an unneeded cast
@ 2014-07-10 9:00 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2014-07-10 9:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tadeusz Struk, David S. Miller, Bruce Allan, Pingchaox Yang,
Bo Cui, qat-linux, linux-crypto, kernel-janitors
On Tue, Jul 08, 2014 at 01:59:07PM +0300, Dan Carpenter wrote:
> The cast to (unsigned int *) doesn't hurt anything but it is pointless.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-10 9:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-08 10:59 [patch] crypto: qat - remove an unneeded cast Dan Carpenter
2014-07-08 10:59 ` Dan Carpenter
2014-07-10 9:00 ` Herbert Xu
2014-07-10 9:00 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.