All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC 1/2] sdhci : recompute timeout_clk when needed
@ 2014-07-10  8:01 Matthieu CASTET
  2014-07-10  8:03 ` Matthieu CASTET
  0 siblings, 1 reply; 2+ messages in thread
From: Matthieu CASTET @ 2014-07-10  8:01 UTC (permalink / raw)
  To: linux-mmc; +Cc: Chris Ball, Matthieu CASTET

when SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set, timeout_clk is sdclk.
We need to update it when we change sdclk in sdhci_set_clock.
This allow to have a more precisse timeout and max_busy_timeout. This
can help for command that need a big busy wait (erase, ...).

Signed-off-by: Matthieu CASTET <matthieu.castet@parrot.com>
---
 drivers/mmc/host/sdhci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 9df59a4..76b1aab 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1192,8 +1192,13 @@ void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
 	}
 
 clock_set:
-	if (real_div)
+	if (real_div) {
 		host->mmc->actual_clock = (host->max_clk * clk_mul) / real_div;
+		if (host->quirks & SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK) {
+			host->timeout_clk = host->mmc->actual_clock / 1000;
+			host->mmc->max_busy_timeout = (1 << 27) / host->timeout_clk;
+		}
+	}
 
 	clk |= (div & SDHCI_DIV_MASK) << SDHCI_DIVIDER_SHIFT;
 	clk |= ((div & SDHCI_DIV_HI_MASK) >> SDHCI_DIV_MASK_LEN)
-- 
2.0.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC 1/2] sdhci : recompute timeout_clk when needed
  2014-07-10  8:01 [RFC 1/2] sdhci : recompute timeout_clk when needed Matthieu CASTET
@ 2014-07-10  8:03 ` Matthieu CASTET
  0 siblings, 0 replies; 2+ messages in thread
From: Matthieu CASTET @ 2014-07-10  8:03 UTC (permalink / raw)
  To: linux-mmc; +Cc: Chris Ball

Please ignore this mail, it is a mistake (it was already sent).

Sorry for the noise.

Le Thu, 10 Jul 2014 10:01:03 +0200,
Matthieu CASTET <matthieu.castet@parrot.com> a écrit :

> when SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK is set, timeout_clk is sdclk.
> We need to update it when we change sdclk in sdhci_set_clock.
> This allow to have a more precisse timeout and max_busy_timeout. This
> can help for command that need a big busy wait (erase, ...).
> 
> Signed-off-by: Matthieu CASTET <matthieu.castet@parrot.com>
> ---
>  drivers/mmc/host/sdhci.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 9df59a4..76b1aab 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1192,8 +1192,13 @@ void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
>  	}
>  
>  clock_set:
> -	if (real_div)
> +	if (real_div) {
>  		host->mmc->actual_clock = (host->max_clk * clk_mul) / real_div;
> +		if (host->quirks & SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK) {
> +			host->timeout_clk = host->mmc->actual_clock / 1000;
> +			host->mmc->max_busy_timeout = (1 << 27) / host->timeout_clk;
> +		}
> +	}
>  
>  	clk |= (div & SDHCI_DIV_MASK) << SDHCI_DIVIDER_SHIFT;
>  	clk |= ((div & SDHCI_DIV_HI_MASK) >> SDHCI_DIV_MASK_LEN)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-10  8:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-10  8:01 [RFC 1/2] sdhci : recompute timeout_clk when needed Matthieu CASTET
2014-07-10  8:03 ` Matthieu CASTET

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.