* [PATCH] staging: input: sunkbd.c: Fix coding style
@ 2014-07-20 12:01 ` Bivolaru Catalin
0 siblings, 0 replies; 6+ messages in thread
From: Bivolaru Catalin @ 2014-07-20 12:01 UTC (permalink / raw)
To: kernel-janitors, dmitry.torokhov, linux-input, linux-kernel
Cc: paul.gortmaker
Fix coding style with regard to missing spaces after , and the column limit
that was violated after the first change.
Signed-off-by: Bivolaru Catalin <bivolaru.catalin@gmail.com>
---
The change was tested only by compilation.
diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
index dc6bb9d..25ba6b6 100644
--- a/drivers/input/keyboard/sunkbd.c
+++ b/drivers/input/keyboard/sunkbd.c
@@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");
static unsigned char sunkbd_keycode[128] = {
- 0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
- 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106, 1, 2, 3,
- 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
- 116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
- 26, 27,111,127, 71, 72, 73, 74,134,135,107, 0, 29, 30, 31, 32,
- 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
- 104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
- 79, 80, 81, 0, 0, 0,138, 58,125, 57,126,109, 86, 78
+ 0, 128, 114, 129, 115, 59, 60, 68, 61, 87, 62, 88, 63, 100,
+ 64, 112, 65, 66, 67, 56, 103, 119, 99, 70, 105, 130, 131, 108,
+ 106, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
+ 41, 14, 110, 113, 98, 55, 116, 132, 83, 133, 102, 15, 16, 17,
+ 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 111, 127, 71, 72,
+ 73, 74, 134, 135, 107, 0, 29, 30, 31, 32, 33, 34, 35, 36,
+ 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82, 136, 104, 137,
+ 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 101,
+ 79, 80, 81, 0, 0, 0, 138, 58, 125, 57, 126, 109, 86, 78
};
#define SUNKBD_CMD_RESET 0x1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: input: sunkbd.c: Fix coding style
@ 2014-07-20 12:01 ` Bivolaru Catalin
0 siblings, 0 replies; 6+ messages in thread
From: Bivolaru Catalin @ 2014-07-20 12:01 UTC (permalink / raw)
To: kernel-janitors, dmitry.torokhov, linux-input, linux-kernel
Cc: paul.gortmaker
Fix coding style with regard to missing spaces after , and the column limit
that was violated after the first change.
Signed-off-by: Bivolaru Catalin <bivolaru.catalin@gmail.com>
---
The change was tested only by compilation.
diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
index dc6bb9d..25ba6b6 100644
--- a/drivers/input/keyboard/sunkbd.c
+++ b/drivers/input/keyboard/sunkbd.c
@@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");
static unsigned char sunkbd_keycode[128] = {
- 0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
- 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106, 1, 2, 3,
- 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
- 116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
- 26, 27,111,127, 71, 72, 73, 74,134,135,107, 0, 29, 30, 31, 32,
- 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
- 104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
- 79, 80, 81, 0, 0, 0,138, 58,125, 57,126,109, 86, 78
+ 0, 128, 114, 129, 115, 59, 60, 68, 61, 87, 62, 88, 63, 100,
+ 64, 112, 65, 66, 67, 56, 103, 119, 99, 70, 105, 130, 131, 108,
+ 106, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
+ 41, 14, 110, 113, 98, 55, 116, 132, 83, 133, 102, 15, 16, 17,
+ 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 111, 127, 71, 72,
+ 73, 74, 134, 135, 107, 0, 29, 30, 31, 32, 33, 34, 35, 36,
+ 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82, 136, 104, 137,
+ 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 101,
+ 79, 80, 81, 0, 0, 0, 138, 58, 125, 57, 126, 109, 86, 78
};
#define SUNKBD_CMD_RESET 0x1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: input: sunkbd.c: Fix coding style
2014-07-20 12:01 ` Bivolaru Catalin
@ 2014-07-20 15:52 ` Joe Perches
-1 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2014-07-20 15:52 UTC (permalink / raw)
To: Bivolaru Catalin
Cc: kernel-janitors, dmitry.torokhov, linux-input, linux-kernel,
paul.gortmaker
On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> Fix coding style with regard to missing spaces after , and the column limit
> that was violated after the first change.
Some checkpatch errors should be ignored.
These are some of them.
This change doesn't make it easier to read
or to find any array entry.
It's currently in groups of 16 (0x10).
This change would make it very difficult
to find any particular entry.
It might make some sense to change the last
line to add a trailing " 0, 0" entry as
the compiler does to make it a bit clearer
the table has 128 entries.
> diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
[]
> @@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
>
> static unsigned char sunkbd_keycode[128] = {
> - 0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
> - 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106, 1, 2, 3,
> - 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
> - 116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
> - 26, 27,111,127, 71, 72, 73, 74,134,135,107, 0, 29, 30, 31, 32,
> - 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
> - 104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
> - 79, 80, 81, 0, 0, 0,138, 58,125, 57,126,109, 86, 78
> + 0, 128, 114, 129, 115, 59, 60, 68, 61, 87, 62, 88, 63, 100,
> + 64, 112, 65, 66, 67, 56, 103, 119, 99, 70, 105, 130, 131, 108,
> + 106, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
> + 41, 14, 110, 113, 98, 55, 116, 132, 83, 133, 102, 15, 16, 17,
> + 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 111, 127, 71, 72,
> + 73, 74, 134, 135, 107, 0, 29, 30, 31, 32, 33, 34, 35, 36,
> + 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82, 136, 104, 137,
> + 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 101,
> + 79, 80, 81, 0, 0, 0, 138, 58, 125, 57, 126, 109, 86, 78
> };
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: input: sunkbd.c: Fix coding style
@ 2014-07-20 15:52 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2014-07-20 15:52 UTC (permalink / raw)
To: Bivolaru Catalin
Cc: kernel-janitors, dmitry.torokhov, linux-input, linux-kernel,
paul.gortmaker
On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> Fix coding style with regard to missing spaces after , and the column limit
> that was violated after the first change.
Some checkpatch errors should be ignored.
These are some of them.
This change doesn't make it easier to read
or to find any array entry.
It's currently in groups of 16 (0x10).
This change would make it very difficult
to find any particular entry.
It might make some sense to change the last
line to add a trailing " 0, 0" entry as
the compiler does to make it a bit clearer
the table has 128 entries.
> diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
[]
> @@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
>
> static unsigned char sunkbd_keycode[128] = {
> - 0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
> - 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106, 1, 2, 3,
> - 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
> - 116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
> - 26, 27,111,127, 71, 72, 73, 74,134,135,107, 0, 29, 30, 31, 32,
> - 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
> - 104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
> - 79, 80, 81, 0, 0, 0,138, 58,125, 57,126,109, 86, 78
> + 0, 128, 114, 129, 115, 59, 60, 68, 61, 87, 62, 88, 63, 100,
> + 64, 112, 65, 66, 67, 56, 103, 119, 99, 70, 105, 130, 131, 108,
> + 106, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
> + 41, 14, 110, 113, 98, 55, 116, 132, 83, 133, 102, 15, 16, 17,
> + 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 111, 127, 71, 72,
> + 73, 74, 134, 135, 107, 0, 29, 30, 31, 32, 33, 34, 35, 36,
> + 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82, 136, 104, 137,
> + 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 101,
> + 79, 80, 81, 0, 0, 0, 138, 58, 125, 57, 126, 109, 86, 78
> };
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: input: sunkbd.c: Fix coding style
2014-07-20 15:52 ` Joe Perches
@ 2014-07-20 20:19 ` Dmitry Torokhov
-1 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2014-07-20 20:19 UTC (permalink / raw)
To: Joe Perches
Cc: Bivolaru Catalin, kernel-janitors, linux-input, linux-kernel,
paul.gortmaker
On Sun, Jul 20, 2014 at 08:52:54AM -0700, Joe Perches wrote:
> On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> > Fix coding style with regard to missing spaces after , and the column limit
> > that was violated after the first change.
>
> Some checkpatch errors should be ignored.
>
> These are some of them.
>
> This change doesn't make it easier to read
> or to find any array entry.
>
> It's currently in groups of 16 (0x10).
>
> This change would make it very difficult
> to find any particular entry.
>
> It might make some sense to change the last
> line to add a trailing " 0, 0" entry as
> the compiler does to make it a bit clearer
> the table has 128 entries.
I'd rather not change a thing in this table - it has been working as is
for many years.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: input: sunkbd.c: Fix coding style
@ 2014-07-20 20:19 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2014-07-20 20:19 UTC (permalink / raw)
To: Joe Perches
Cc: Bivolaru Catalin, kernel-janitors, linux-input, linux-kernel,
paul.gortmaker
On Sun, Jul 20, 2014 at 08:52:54AM -0700, Joe Perches wrote:
> On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> > Fix coding style with regard to missing spaces after , and the column limit
> > that was violated after the first change.
>
> Some checkpatch errors should be ignored.
>
> These are some of them.
>
> This change doesn't make it easier to read
> or to find any array entry.
>
> It's currently in groups of 16 (0x10).
>
> This change would make it very difficult
> to find any particular entry.
>
> It might make some sense to change the last
> line to add a trailing " 0, 0" entry as
> the compiler does to make it a bit clearer
> the table has 128 entries.
I'd rather not change a thing in this table - it has been working as is
for many years.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-20 20:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-20 12:01 [PATCH] staging: input: sunkbd.c: Fix coding style Bivolaru Catalin
2014-07-20 12:01 ` Bivolaru Catalin
2014-07-20 15:52 ` Joe Perches
2014-07-20 15:52 ` Joe Perches
2014-07-20 20:19 ` Dmitry Torokhov
2014-07-20 20:19 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.