From: Jesse Barnes <jbarnes@virtuousgeek.org> To: Daniel Vetter <daniel@ffwll.ch> Cc: "Alex Deucher" <alexdeucher@gmail.com>, "Christian König" <christian.koenig@amd.com>, "Thomas Hellstrom" <thellstrom@vmware.com>, nouveau <nouveau@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Deucher, Alexander" <alexander.deucher@amd.com>, "Ben Skeggs" <bskeggs@redhat.com> Subject: Re: [PATCH 09/17] drm/radeon: use common fence implementation for fences Date: Tue, 22 Jul 2014 12:14:35 -0700 [thread overview] Message-ID: <20140722121435.6bd093d0@jbarnes-desktop> (raw) In-Reply-To: <CAKMK7uGtfUTU=VwSnF07jncJsH1Ckie2m1FCjct60Yz88uE3cg@mail.gmail.com> On Tue, 22 Jul 2014 17:48:18 +0200 Daniel Vetter <daniel@ffwll.ch> wrote: > On Tue, Jul 22, 2014 at 5:42 PM, Alex Deucher <alexdeucher@gmail.com> wrote: > >> Fence-based syncing between userspace queues submitted stuff through > >> doorbells and anything submitted by the general simply wont work. > >> Which is why I think the doorbell is a stupid interface since I just > >> don't see cameras and v4l devices implementing all that complexity to > >> get a pure userspace side sync solution. > >> > > > > Like it or not this is what a lot of application writers want (look at > > mantle and metal and similar new APIs or android synpts). Having > > queues and fences in userspace allows the application to structure > > things to best fit their own task graphs. The app can decide how to > > deal with dependencies and synchronization explicitly instead of > > blocking the queues in the kernel for everyone. Anyway, this is > > getting off topic. > > Well there's explicit fences as used in opencl and android syncpts. My > plan is actually to support that in i915 using Maarten's struct fence > stuff (and there's just a very trivial patch for the android stuff in > merging needed to get there). What doesn't work is fences created > behind the kernel's back purely in userspace by giving shared memory > locations special meaning. Those get the kernel completely out of the > picture (as opposed to android syncpts, which just make sync > explicit). > > I guess long-term we might need something like gpu futexes to make > that pure userspace syncing integrate a bit better, but imo that's (at > least for now) out of scope. For fences here I have the goal of one Yeah, with a little kernel help you could have a mostly kernel independent sync mechanism using just shared mem in userspace. The kernel would just need to signal any interested clients when something happened (even if it didn't know what) and let userspace sort out the rest. I think that would be a nice thing to provide at some point, as it could allow for some fine grained CPU/GPU algorithms that use lightweight synchronization with and without busy looping on the CPU side. But all of that is definitely a lower priority than getting explicit fencing exported to userspace to work right, both for intra-driver sync and inter-driver sync. > internally representation used by both implicit syncing (dma-buf on > classic linux, e.g. prime) and explicit fencing on android or opencl > or something like that. > > We don't have the code yet ready, but that's the direction i915 will > move towards for the near future. Jesse is working on some patches > already. Yeah I'd like to get some feedback from Maarten on my bits so I can get them ready for upstream. I still need to add documentation and tests, but I'd like to make sure the interfaces and internals get acked first. Thanks, -- Jesse Barnes, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> To: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org> Cc: "Thomas Hellstrom" <thellstrom-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>, nouveau <nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, dri-devel <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, "Deucher, Alexander" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>, "Ben Skeggs" <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "Alex Deucher" <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org> Subject: Re: [PATCH 09/17] drm/radeon: use common fence implementation for fences Date: Tue, 22 Jul 2014 12:14:35 -0700 [thread overview] Message-ID: <20140722121435.6bd093d0@jbarnes-desktop> (raw) In-Reply-To: <CAKMK7uGtfUTU=VwSnF07jncJsH1Ckie2m1FCjct60Yz88uE3cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On Tue, 22 Jul 2014 17:48:18 +0200 Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org> wrote: > On Tue, Jul 22, 2014 at 5:42 PM, Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > >> Fence-based syncing between userspace queues submitted stuff through > >> doorbells and anything submitted by the general simply wont work. > >> Which is why I think the doorbell is a stupid interface since I just > >> don't see cameras and v4l devices implementing all that complexity to > >> get a pure userspace side sync solution. > >> > > > > Like it or not this is what a lot of application writers want (look at > > mantle and metal and similar new APIs or android synpts). Having > > queues and fences in userspace allows the application to structure > > things to best fit their own task graphs. The app can decide how to > > deal with dependencies and synchronization explicitly instead of > > blocking the queues in the kernel for everyone. Anyway, this is > > getting off topic. > > Well there's explicit fences as used in opencl and android syncpts. My > plan is actually to support that in i915 using Maarten's struct fence > stuff (and there's just a very trivial patch for the android stuff in > merging needed to get there). What doesn't work is fences created > behind the kernel's back purely in userspace by giving shared memory > locations special meaning. Those get the kernel completely out of the > picture (as opposed to android syncpts, which just make sync > explicit). > > I guess long-term we might need something like gpu futexes to make > that pure userspace syncing integrate a bit better, but imo that's (at > least for now) out of scope. For fences here I have the goal of one Yeah, with a little kernel help you could have a mostly kernel independent sync mechanism using just shared mem in userspace. The kernel would just need to signal any interested clients when something happened (even if it didn't know what) and let userspace sort out the rest. I think that would be a nice thing to provide at some point, as it could allow for some fine grained CPU/GPU algorithms that use lightweight synchronization with and without busy looping on the CPU side. But all of that is definitely a lower priority than getting explicit fencing exported to userspace to work right, both for intra-driver sync and inter-driver sync. > internally representation used by both implicit syncing (dma-buf on > classic linux, e.g. prime) and explicit fencing on android or opencl > or something like that. > > We don't have the code yet ready, but that's the direction i915 will > move towards for the near future. Jesse is working on some patches > already. Yeah I'd like to get some feedback from Maarten on my bits so I can get them ready for upstream. I still need to add documentation and tests, but I'd like to make sure the interfaces and internals get acked first. Thanks, -- Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-07-22 19:13 UTC|newest] Thread overview: 165+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-09 12:29 [PATCH 00/17] Convert TTM to the new fence interface Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 01/17] drm/ttm: add interruptible parameter to ttm_eu_reserve_buffers Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 02/17] drm/ttm: kill off some members to ttm_validate_buffer Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 03/17] drm/nouveau: add reservation to nouveau_gem_ioctl_cpu_prep Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 04/17] drm/nouveau: require reservations for nouveau_fence_sync and nouveau_bo_fence Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 05/17] drm/ttm: call ttm_bo_wait while inside a reservation Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 06/17] drm/ttm: kill fence_lock Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 07/17] drm/nouveau: rework to new fence interface Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 08/17] drm/radeon: add timeout argument to radeon_fence_wait_seq Maarten Lankhorst 2014-07-09 12:29 ` Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 09/17] drm/radeon: use common fence implementation for fences Maarten Lankhorst 2014-07-09 12:57 ` Deucher, Alexander 2014-07-09 12:57 ` Deucher, Alexander 2014-07-09 13:23 ` [PATCH v2 " Maarten Lankhorst 2014-07-09 13:23 ` Maarten Lankhorst 2014-07-10 17:27 ` Alex Deucher 2014-07-10 17:27 ` Alex Deucher 2014-07-22 4:05 ` [PATCH " Dave Airlie 2014-07-22 4:05 ` Dave Airlie 2014-07-22 4:05 ` Dave Airlie 2014-07-22 8:43 ` Christian König 2014-07-22 8:43 ` Christian König 2014-07-22 11:46 ` Daniel Vetter 2014-07-22 11:46 ` Daniel Vetter 2014-07-22 11:52 ` Daniel Vetter 2014-07-22 11:52 ` Daniel Vetter 2014-07-22 11:57 ` Daniel Vetter 2014-07-22 11:57 ` Daniel Vetter 2014-07-22 12:19 ` Christian König 2014-07-22 12:19 ` Christian König 2014-07-22 13:26 ` [Nouveau] " Daniel Vetter 2014-07-22 13:26 ` Daniel Vetter 2014-07-22 13:45 ` Christian König 2014-07-22 13:45 ` Christian König 2014-07-22 14:44 ` [Nouveau] " Maarten Lankhorst 2014-07-22 14:44 ` Maarten Lankhorst 2014-07-22 15:02 ` [Nouveau] " Christian König 2014-07-22 15:18 ` Maarten Lankhorst 2014-07-22 15:17 ` Daniel Vetter 2014-07-22 15:17 ` Daniel Vetter 2014-07-22 15:35 ` [Nouveau] " Christian König 2014-07-22 15:35 ` Christian König 2014-07-22 15:42 ` Daniel Vetter 2014-07-22 15:42 ` Daniel Vetter 2014-07-22 15:59 ` Christian König 2014-07-22 15:59 ` Christian König 2014-07-22 16:21 ` Daniel Vetter 2014-07-22 16:21 ` Daniel Vetter 2014-07-22 16:39 ` Christian König 2014-07-22 16:39 ` Christian König 2014-07-22 16:52 ` Daniel Vetter 2014-07-22 16:52 ` Daniel Vetter 2014-07-22 16:43 ` Daniel Vetter 2014-07-22 16:43 ` Daniel Vetter 2014-07-23 6:40 ` Maarten Lankhorst 2014-07-23 6:40 ` Maarten Lankhorst 2014-07-23 6:52 ` Christian König 2014-07-23 6:52 ` Christian König 2014-07-23 7:02 ` [Nouveau] " Daniel Vetter 2014-07-23 7:02 ` Daniel Vetter 2014-07-23 7:06 ` [Nouveau] " Maarten Lankhorst 2014-07-23 7:06 ` Maarten Lankhorst 2014-07-23 7:09 ` Daniel Vetter 2014-07-23 7:09 ` Daniel Vetter 2014-07-23 7:15 ` Christian König 2014-07-23 7:15 ` Christian König 2014-07-23 7:32 ` [Nouveau] " Maarten Lankhorst 2014-07-23 7:32 ` Maarten Lankhorst 2014-07-23 7:41 ` Christian König 2014-07-23 7:41 ` Christian König 2014-07-23 7:26 ` [Nouveau] " Christian König 2014-07-23 7:26 ` Christian König 2014-07-23 7:31 ` Daniel Vetter 2014-07-23 7:31 ` Daniel Vetter 2014-07-23 7:37 ` Christian König 2014-07-23 7:37 ` Christian König 2014-07-23 7:51 ` [Nouveau] " Maarten Lankhorst 2014-07-23 7:51 ` Maarten Lankhorst 2014-07-23 7:58 ` [Nouveau] " Christian König 2014-07-23 7:58 ` Christian König 2014-07-23 8:07 ` [Nouveau] " Daniel Vetter 2014-07-23 8:07 ` Daniel Vetter 2014-07-23 8:20 ` [Nouveau] " Christian König 2014-07-23 8:20 ` Christian König 2014-07-23 8:25 ` Maarten Lankhorst 2014-07-23 8:25 ` Maarten Lankhorst 2014-07-23 8:42 ` [Nouveau] " Daniel Vetter 2014-07-23 8:42 ` Daniel Vetter 2014-07-23 8:46 ` Christian König 2014-07-23 8:46 ` Christian König 2014-07-23 8:54 ` [Nouveau] " Daniel Vetter 2014-07-23 8:54 ` Daniel Vetter 2014-07-23 9:27 ` [Nouveau] " Christian König 2014-07-23 9:27 ` Christian König 2014-07-23 9:30 ` [Nouveau] " Daniel Vetter 2014-07-23 9:30 ` Daniel Vetter 2014-07-23 9:36 ` [Nouveau] " Christian König 2014-07-23 9:36 ` Christian König 2014-07-23 9:38 ` [Nouveau] " Maarten Lankhorst 2014-07-23 9:38 ` Maarten Lankhorst 2014-07-23 9:39 ` Christian König 2014-07-23 9:39 ` Christian König 2014-07-23 9:39 ` [Nouveau] " Daniel Vetter 2014-07-23 9:39 ` Daniel Vetter 2014-07-23 9:44 ` Daniel Vetter 2014-07-23 9:44 ` Daniel Vetter 2014-07-23 9:47 ` [Nouveau] " Christian König 2014-07-23 9:47 ` Christian König 2014-07-23 9:52 ` Daniel Vetter 2014-07-23 9:52 ` Daniel Vetter 2014-07-23 9:55 ` [Nouveau] " Maarten Lankhorst 2014-07-23 9:55 ` Maarten Lankhorst 2014-07-23 10:13 ` [Nouveau] " Christian König 2014-07-23 10:13 ` Christian König 2014-07-23 10:52 ` [Nouveau] " Daniel Vetter 2014-07-23 10:52 ` Daniel Vetter 2014-07-23 12:36 ` Christian König 2014-07-23 12:36 ` Christian König 2014-07-23 12:42 ` Daniel Vetter 2014-07-23 12:42 ` Daniel Vetter 2014-07-23 13:16 ` Maarten Lankhorst 2014-07-23 13:16 ` Maarten Lankhorst 2014-07-23 14:05 ` [Nouveau] " Maarten Lankhorst 2014-07-23 14:05 ` Maarten Lankhorst 2014-07-24 13:47 ` [Nouveau] " Christian König 2014-07-24 13:47 ` Christian König 2014-07-23 8:01 ` Daniel Vetter 2014-07-23 8:01 ` Daniel Vetter 2014-07-23 8:31 ` Christian König 2014-07-23 8:31 ` Christian König 2014-07-23 12:35 ` Rob Clark 2014-07-23 12:35 ` Rob Clark 2014-07-22 14:05 ` Maarten Lankhorst 2014-07-22 14:24 ` Christian König 2014-07-22 14:27 ` Maarten Lankhorst 2014-07-22 14:39 ` Christian König 2014-07-22 14:47 ` Maarten Lankhorst 2014-07-22 15:16 ` Christian König 2014-07-22 15:19 ` Daniel Vetter 2014-07-22 15:19 ` Daniel Vetter 2014-07-22 15:42 ` Alex Deucher 2014-07-22 15:42 ` Alex Deucher 2014-07-22 15:48 ` Daniel Vetter 2014-07-22 15:48 ` Daniel Vetter 2014-07-22 19:14 ` Jesse Barnes [this message] 2014-07-22 19:14 ` Jesse Barnes 2014-07-23 9:47 ` [Nouveau] " Daniel Vetter 2014-07-23 9:47 ` Daniel Vetter 2014-07-23 15:37 ` [Nouveau] " Jesse Barnes 2014-07-23 15:37 ` Jesse Barnes 2014-07-22 11:51 ` Maarten Lankhorst 2014-07-22 11:51 ` Maarten Lankhorst 2014-07-09 12:29 ` [PATCH 10/17] drm/qxl: rework to new fence interface Maarten Lankhorst 2014-07-09 12:30 ` [PATCH 11/17] drm/vmwgfx: get rid of different types of fence_flags entirely Maarten Lankhorst 2014-07-09 12:30 ` [PATCH 12/17] drm/vmwgfx: rework to new fence interface Maarten Lankhorst 2014-07-09 12:30 ` [PATCH 13/17] drm/ttm: flip the switch, and convert to dma_fence Maarten Lankhorst 2014-07-09 12:30 ` [PATCH 14/17] drm/nouveau: use rcu in nouveau_gem_ioctl_cpu_prep Maarten Lankhorst 2014-07-09 12:30 ` [PATCH 15/17] drm/radeon: use rcu waits in some ioctls Maarten Lankhorst 2014-07-09 12:30 ` [PATCH 16/17] drm/vmwgfx: use rcu in vmw_user_dmabuf_synccpu_grab Maarten Lankhorst 2014-07-09 12:30 ` [PATCH 17/17] drm/ttm: use rcu in core ttm Maarten Lankhorst 2014-07-09 13:09 ` [PATCH 00/17] Convert TTM to the new fence interface Mike Lothian 2014-07-09 13:21 ` Maarten Lankhorst 2014-07-09 13:21 ` Maarten Lankhorst 2014-07-10 21:37 ` Thomas Hellström 2014-07-10 21:37 ` Thomas Hellström
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140722121435.6bd093d0@jbarnes-desktop \ --to=jbarnes@virtuousgeek.org \ --cc=alexander.deucher@amd.com \ --cc=alexdeucher@gmail.com \ --cc=bskeggs@redhat.com \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nouveau@lists.freedesktop.org \ --cc=thellstrom@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.