Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend

From: Stefan Hajnoczi <stefanha@gmail.com>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend
Date: Tue, 22 Jul 2014 13:35:20 +0100	[thread overview]
Message-ID: <20140722123520.GA21042@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1403857452-23768-2-git-send-email-cnanakos@grnet.gr>

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote:
> +    xseg_set_req_data(s->xseg, req, reqdata);
> +    if (op == ARCHIP_OP_WRITE) {
> +        data = xseg_get_data(s->xseg, req);
> +        if (!data) {
> +            archipelagolog("Cannot get XSEG data\n");
> +            goto err_exit;
> +        }
> +        memcpy(data, aio_cb->buffer + bufidx, count);
> +    }

Can you avoid ->buffer and use iov_to_buf() or qemu_iovec_to_buf()
instead?

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]