Re: [Qemu-devel] [PATCH v6 4/5] QMP: Add support for Archipelago

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On 07/02/2014 08:11 AM, Chrysostomos Nanakos wrote:
> On 07/02/2014 04:58 PM, Eric Blake wrote:
>> On 06/27/2014 02:24 AM, Chrysostomos Nanakos wrote:
>>> Introduce new enum BlockdevOptionsArchipelago.
>>>

>>> @@ -1347,6 +1379,7 @@
>>>     'base': 'BlockdevOptionsBase',
>>>     'discriminator': 'driver',
>>>     'data': {
>>> +      'archipelago':'BlockdevOptionsArchipelago',
>> Again, not necessarily your fault, but we ought to do a better job of
>> documenting when new union branches are added in later releases.
> 
> Any proposition for this one?

Here's what was done for NetClientOptions:

# Since 1.2
#
# 'l2tpv3' - since 2.1

although doing it properly would best be done as a separate patch that
audits all qapi types.  I'm not trying to force you to take on the
documentation cleanup patch, although getting just your addition to
mention when it was added will make that cleanup audit easier for
whoever takes that task on.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]