From: Lee Jones <lee.jones@linaro.org> To: Joe Perches <joe@perches.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com Subject: Re: [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch Date: Tue, 22 Jul 2014 14:48:24 +0100 [thread overview] Message-ID: <20140722134824.GE16065@lee--X1> (raw) In-Reply-To: <1406036038.30871.19.camel@joe-AO725> On Tue, 22 Jul 2014, Joe Perches wrote: > On Tue, 2014-07-22 at 12:11 +0100, Lee Jones wrote: > > This is part of an effort to clean-up the MFD subsystem. > > > > WARNING: Missing a blank line after declarations > > + u32 flags; > > + void (*callback)(void *, u16[]); > > False positive from an old version of checkpatch. > > The one in -next doesn't emit this as it's > simply a function pointer declaration. Thanks Joe, will fix up. > > diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c > [] > > @@ -25,8 +25,9 @@ struct pcap_adc_request { > > u8 bank; > > u8 ch[2]; > > u32 flags; > > - void (*callback)(void *, u16[]); > > void *data; > > + > > + void (*callback)(void *, u16[]); > > }; > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch Date: Tue, 22 Jul 2014 14:48:24 +0100 [thread overview] Message-ID: <20140722134824.GE16065@lee--X1> (raw) In-Reply-To: <1406036038.30871.19.camel@joe-AO725> On Tue, 22 Jul 2014, Joe Perches wrote: > On Tue, 2014-07-22 at 12:11 +0100, Lee Jones wrote: > > This is part of an effort to clean-up the MFD subsystem. > > > > WARNING: Missing a blank line after declarations > > + u32 flags; > > + void (*callback)(void *, u16[]); > > False positive from an old version of checkpatch. > > The one in -next doesn't emit this as it's > simply a function pointer declaration. Thanks Joe, will fix up. > > diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c > [] > > @@ -25,8 +25,9 @@ struct pcap_adc_request { > > u8 bank; > > u8 ch[2]; > > u32 flags; > > - void (*callback)(void *, u16[]); > > void *data; > > + > > + void (*callback)(void *, u16[]); > > }; > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-22 13:48 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-22 11:11 [PATCH 00/19] mfd: Fix checkpatch errors Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 01/19] mfd: max77686: Fix 'line over 80 chars' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:45 ` pramod gurav 2014-07-22 11:45 ` pramod gurav 2014-07-22 12:13 ` Lee Jones 2014-07-22 12:13 ` Lee Jones 2014-07-22 12:27 ` pramod gurav 2014-07-22 12:27 ` pramod gurav 2014-07-22 11:11 ` [PATCH 02/19] mfd: max8925-i2c: Fix 'blank line after declarations' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:50 ` pramod gurav 2014-07-22 11:50 ` pramod gurav 2014-07-22 12:15 ` Lee Jones 2014-07-22 12:15 ` Lee Jones [not found] ` <CAMf-jSmyJ1r8eFe-kU2LwgYzNuqkNqNHvUVk088f4AUaULEugg@mail.gmail.com> 2014-07-22 14:03 ` Lee Jones 2014-07-22 11:11 ` [PATCH 03/19] mfd: tps80031: Fix 'missing break or fall-through comment' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:33 ` Arnd Bergmann 2014-07-22 11:33 ` Arnd Bergmann 2014-07-22 12:08 ` Lee Jones 2014-07-22 12:08 ` Lee Jones 2014-07-22 11:11 ` [PATCH 04/19] mfd: mcp-core: Fix 'blank line after declarations' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 05/19] mfd: wm8350-irq: Fix 'line over 80 chars' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 06/19] mfd: dm355evm_msp: Fix checkpatch error: insert space after ',' Lee Jones 2014-07-22 11:11 ` [PATCH 06/19] mfd: dm355evm_msp: Fix checkpatch error: insert space after ', ' Lee Jones 2014-07-22 11:11 ` [PATCH 07/19] mfd: sec-core: Fix 'missing blank line after declarations' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 08/19] mfd: twl6040: Fix 'insert space after ','', error Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 13:33 ` Joe Perches 2014-07-22 13:33 ` Joe Perches 2014-07-22 13:48 ` Lee Jones [this message] 2014-07-22 13:48 ` Lee Jones 2014-07-22 11:11 ` [PATCH 10/19] mfd: lp8788-irq: Fix 'missing blank line after declarations' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 11/19] mfd: twl4030-irq: Fix style warnings relating to pr_warn() and sizeof() Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 12/19] mfd: max8925-core: Fix 'missing blank line after declarations' warning Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 13/19] mfd: wm8350-i2c: Replace spaces with tabs Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 14/19] mfd: twl6030-irq: Extinguish coding style warnings Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 15/19] mfd: tc6387xb: Remove unnecessary braces and correct " Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 16/19] mfd: si476x-cmd: Remedy checkpatch style complains Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 17/19] mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 18/19] mfd: kempld-core: Correct a variety of checkpatch warnings Lee Jones 2014-07-22 11:11 ` Lee Jones 2014-07-22 11:11 ` [PATCH 19/19] mfd: wm8997-tables: Suppress 'line over 80 chars' warnings Lee Jones 2014-07-22 11:11 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140722134824.GE16065@lee--X1 \ --to=lee.jones@linaro.org \ --cc=joe@perches.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.