All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: axboe@kernel.dk, akpm@linux-foundation.org, linux-aio@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] aio: fix some comments
Date: Tue, 22 Jul 2014 10:12:20 -0400	[thread overview]
Message-ID: <20140722141220.GD26030@kvack.org> (raw)
In-Reply-To: <1405996804-8262-3-git-send-email-guz.fnst@cn.fujitsu.com>

On Tue, Jul 22, 2014 at 10:40:03AM +0800, Gu Zheng wrote:
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>

Again, you're missing a commit message here.  Please resubmit with a commit 
message.

		-ben

> ---
>  fs/aio.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/aio.c b/fs/aio.c
> index 1dc6158..0cd0479 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1037,7 +1037,7 @@ void aio_complete(struct kiocb *iocb, long res, long res2)
>  }
>  EXPORT_SYMBOL(aio_complete);
>  
> -/* aio_read_events
> +/* aio_read_events_ring
>   *	Pull an event off of the ioctx's event ring.  Returns the number of
>   *	events fetched
>   */
> @@ -1289,9 +1289,8 @@ static ssize_t aio_setup_single_vector(struct kiocb *kiocb,
>  }
>  
>  /*
> - * aio_setup_iocb:
> - *	Performs the initial checks and aio retry method
> - *	setup for the kiocb at the time of io submission.
> + * aio_run_iocb:
> + *	Performs the initial checks and io submission.
>   */
>  static ssize_t aio_run_iocb(struct kiocb *req, unsigned opcode,
>  			    char __user *buf, bool compat)
> -- 
> 1.7.7

-- 
"Thought is the essence of where you are now."

  parent reply	other threads:[~2014-07-22 14:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1405996804-8262-1-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:53 ` [PATCH 1/4] aio: remove the needless registration of ring file's private_data Jeff Moyer
     [not found] ` <1405996804-8262-2-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:54   ` [PATCH 2/4] aio: use the macro rather than the inline magic number Jeff Moyer
2014-07-25  3:13     ` Ming Lei
2014-07-25  5:54       ` Gu Zheng
2014-07-22 14:11   ` Benjamin LaHaise
     [not found] ` <1405996804-8262-3-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:54   ` [PATCH 3/4] aio: fix some comments Jeff Moyer
2014-07-22 14:12   ` Benjamin LaHaise [this message]
2014-07-23  3:58     ` Gu Zheng
     [not found] ` <1405996804-8262-4-git-send-email-guz.fnst@cn.fujitsu.com>
2014-07-22 13:48   ` [PATCH 4/4] aio: use iovec array rather than the single one Jeff Moyer
2014-07-22 15:20   ` Jeff Moyer
2014-07-23  4:05     ` Gu Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140722141220.GD26030@kvack.org \
    --to=bcrl@kvack.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.