Re: [PATCH 2/4] aio: use the macro rather than the inline magic number

From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jeff Moyer <jmoyer@redhat.com>, Benjamin LaHaise <bcrl@kvack.org>,
	Jens Axboe <axboe@kernel.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	open list: AIO <linux-aio@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, ;
Subject: Re: [PATCH 2/4] aio: use the macro rather than the inline magic number
Date: Fri, 25 Jul 2014 13:54:38 +0800	[thread overview]
Message-ID: <53D1F11E.80708@cn.fujitsu.com> (raw)
In-Reply-To: <CACVXFVOv1TShu=s40KvVLMTfk4b2ktZ0xmDUPyiO+7=BqOcSrw@mail.gmail.com>

Hi Lei,
On 07/25/2014 11:13 AM, Ming Lei wrote:

> On Tue, Jul 22, 2014 at 9:54 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
>> Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
>>
>>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>>
>> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>>
>>> ---
>>>  fs/aio.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/fs/aio.c b/fs/aio.c
>>> index ad35876..1dc6158 100644
>>> --- a/fs/aio.c
>>> +++ b/fs/aio.c
>>> @@ -201,7 +201,7 @@ static struct dentry *aio_mount(struct file_system_type *fs_type,
>>>       static const struct dentry_operations ops = {
>>>               .d_dname        = simple_dname,
>>>       };
>>> -     return mount_pseudo(fs_type, "aio:", NULL, &ops, 0xa10a10a1);
>>> +     return mount_pseudo(fs_type, "aio:", NULL, &ops, AIO_RING_MAGIC);
> 
> IMO, it might be better to use a new macro like AIO_FS_MAGIC
> with same number here because the same magic number
> 0xa10a10a1 serves for two purposes.

Sounds reasonable, but I prefer a more common name like
AIO_MAGIC to serve two if we need.:)

Thanks,
Gu

> 
> Thanks,
> .
> 