From: Lee Jones <lee.jones@linaro.org> To: Linus Walleij <linus.walleij@linaro.org> Cc: linux-mips@linux-mips.org, "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>, "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Matthew Garrett" <matthew.garrett@nebula.com>, "Samuel Ortiz" <sameo@linux.intel.com>, "Rafał Miłecki" <zajec5@gmail.com>, "Tomi Valkeinen" <tomi.valkeinen@ti.com>, "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>, "Linux Input" <linux-input@vger.kernel.org>, "abdoulaye berthe" <berthe.ab@gmail.com>, "Alexandre Courbot" <gnurou@gmail.com>, "Bryan Wu" <cooloney@gmail.com>, "arm@kernel.org" <arm@kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "Mark Brown" <broonie@kernel.org>, "Michael Buesch" <m@bues.ch> Subject: Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver Date: Tue, 22 Jul 2014 17:01:58 +0100 [thread overview] Message-ID: <20140722160158.GE23210@lee--X1> (raw) In-Reply-To: <CACRpkdasp9bLULT7NJM9nYX58rRSsQKXFddOLz9Ah6kp-j-3=Q@mail.gmail.com> On Tue, 22 Jul 2014, Linus Walleij wrote: > On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe <berthe.ab@gmail.com> wrote: > > Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be > applied. We're getting rid of the return value from gpiochip_remove(). > > > this remove all reference to gpio_remove retval in all driver > > except pinctrl and gpio. the same thing is done for gpio and > > pinctrl in two different patches. > > > > Signed-off-by: abdoulaye berthe <berthe.ab@gmail.com> > (...) > > I think this patch probably needs to be broken down per-subsystem as it > hits all over the map. But let's start requesting ACKs for the > individual pieces. > Actually I think it will be OK to merge because there is likely not much churn > around these code sites. > > I'm a bit torn between just wanting a big patch for this hitting drivers/gpio > and smaller patches hitting one subsystem at a time. We should be able > to hammer this in one switch strike. It would be better if you could devise a plan to make the switch a subsystem at a time. [...] > > drivers/mfd/asic3.c | 3 ++- > > drivers/mfd/htc-i2cpld.c | 8 +------- > > drivers/mfd/sm501.c | 17 +++-------------- > > drivers/mfd/tc6393xb.c | 13 ++++--------- > > drivers/mfd/ucb1x00-core.c | 8 ++------ > > Lee/Sam can either of you ACK this? I don't see any code? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Linus Walleij <linus.walleij@linaro.org> Cc: "abdoulaye berthe" <berthe.ab@gmail.com>, "arm@kernel.org" <arm@kernel.org>, "Ralf Baechle" <ralf@linux-mips.org>, "Benjamin Herrenschmidt" <benh@kernel.crashing.org>, "Rafał Miłecki" <zajec5@gmail.com>, "Jiri Kosina" <jkosina@suse.cz>, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Bryan Wu" <cooloney@gmail.com>, "Mauro Carvalho Chehab" <m.chehab@samsung.com>, "Samuel Ortiz" <sameo@linux.intel.com>, "Matthew Garrett" <matthew.garrett@nebula.com>, "Michael Buesch" <m@bues.ch>, "Greg KH" <gregkh@linuxfoundation.org>, "Tomi Valkeinen" <tomi.valkeinen@ti.com>, "Mark Brown" <broonie@kernel.org>, "Liam Girdwood" <lgirdwood@gmail.com>, "Alexandre Courbot" <gnurou@gmail.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-mips@linux-mips.org, "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>, "Linux Input" <linux-input@vger.kernel.org>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>, "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org> Subject: Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver Date: Tue, 22 Jul 2014 17:01:58 +0100 [thread overview] Message-ID: <20140722160158.GE23210@lee--X1> (raw) In-Reply-To: <CACRpkdasp9bLULT7NJM9nYX58rRSsQKXFddOLz9Ah6kp-j-3=Q@mail.gmail.com> On Tue, 22 Jul 2014, Linus Walleij wrote: > On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe <berthe.ab@gmail.com> wrote: > > Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be > applied. We're getting rid of the return value from gpiochip_remove(). > > > this remove all reference to gpio_remove retval in all driver > > except pinctrl and gpio. the same thing is done for gpio and > > pinctrl in two different patches. > > > > Signed-off-by: abdoulaye berthe <berthe.ab@gmail.com> > (...) > > I think this patch probably needs to be broken down per-subsystem as it > hits all over the map. But let's start requesting ACKs for the > individual pieces. > Actually I think it will be OK to merge because there is likely not much churn > around these code sites. > > I'm a bit torn between just wanting a big patch for this hitting drivers/gpio > and smaller patches hitting one subsystem at a time. We should be able > to hammer this in one switch strike. It would be better if you could devise a plan to make the switch a subsystem at a time. [...] > > drivers/mfd/asic3.c | 3 ++- > > drivers/mfd/htc-i2cpld.c | 8 +------- > > drivers/mfd/sm501.c | 17 +++-------------- > > drivers/mfd/tc6393xb.c | 13 ++++--------- > > drivers/mfd/ucb1x00-core.c | 8 ++------ > > Lee/Sam can either of you ACK this? I don't see any code? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-22 16:01 UTC|newest] Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-29 21:54 [PATCH] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe 2014-05-29 21:54 ` abdoulaye berthe 2014-05-29 21:54 ` abdoulaye berthe 2014-05-29 22:14 ` David Daney 2014-05-29 22:14 ` David Daney 2014-05-29 22:14 ` David Daney 2014-05-29 22:14 ` David Daney 2014-05-29 23:16 ` abdoulaye berthe 2014-05-29 23:16 ` abdoulaye berthe 2014-05-29 23:40 ` Stephen Rothwell 2014-05-29 23:40 ` Stephen Rothwell 2014-05-29 23:40 ` Stephen Rothwell 2014-05-29 23:40 ` Stephen Rothwell 2014-05-30 11:30 ` [PATCH 1/2] " abdoulaye berthe 2014-05-30 11:30 ` abdoulaye berthe 2014-05-30 11:30 ` abdoulaye berthe 2014-05-30 11:30 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe 2014-05-30 11:30 ` abdoulaye berthe 2014-05-30 11:30 ` abdoulaye berthe 2014-05-30 11:39 ` Geert Uytterhoeven 2014-05-30 11:39 ` Geert Uytterhoeven 2014-05-30 11:39 ` Geert Uytterhoeven 2014-05-30 11:39 ` Geert Uytterhoeven 2014-05-30 11:39 ` Geert Uytterhoeven 2014-05-30 11:39 ` Geert Uytterhoeven 2014-05-30 11:39 ` Geert Uytterhoeven 2014-05-30 15:48 ` Ralf Baechle 2014-05-30 15:48 ` Ralf Baechle 2014-05-30 15:48 ` Ralf Baechle 2014-05-30 15:48 ` Ralf Baechle 2014-05-30 15:48 ` Ralf Baechle 2014-05-30 15:48 ` Ralf Baechle 2014-05-30 15:48 ` Ralf Baechle 2014-05-30 17:33 ` David Daney 2014-05-30 17:33 ` David Daney 2014-05-30 17:33 ` David Daney 2014-05-30 17:33 ` David Daney 2014-05-30 17:33 ` David Daney 2014-05-30 17:33 ` David Daney 2014-05-30 18:16 ` Lars-Peter Clausen 2014-05-30 18:16 ` Lars-Peter Clausen 2014-05-30 18:16 ` Lars-Peter Clausen 2014-05-30 18:16 ` Lars-Peter Clausen 2014-05-30 18:16 ` Lars-Peter Clausen 2014-05-30 18:16 ` Lars-Peter Clausen 2014-05-30 23:29 ` Greg KH 2014-05-30 23:29 ` Greg KH 2014-05-30 23:29 ` Greg KH 2014-05-30 23:29 ` Greg KH 2014-05-30 23:29 ` Greg KH 2014-05-30 23:29 ` Greg KH 2014-05-31 7:35 ` Lars-Peter Clausen 2014-05-31 7:35 ` Lars-Peter Clausen 2014-05-31 7:35 ` Lars-Peter Clausen 2014-05-31 7:35 ` Lars-Peter Clausen 2014-05-31 7:35 ` Lars-Peter Clausen 2014-05-31 7:35 ` Lars-Peter Clausen 2014-05-31 12:19 ` Dan Carpenter 2014-05-31 12:19 ` Dan Carpenter 2014-05-31 12:19 ` Dan Carpenter 2014-05-31 12:19 ` Dan Carpenter 2014-05-31 12:19 ` Dan Carpenter 2014-06-08 23:18 ` Ben Dooks 2014-06-08 23:18 ` Ben Dooks 2014-06-08 23:18 ` Ben Dooks 2014-06-08 23:18 ` Ben Dooks 2014-06-08 23:18 ` Ben Dooks 2014-06-08 23:18 ` Ben Dooks 2014-06-09 11:29 ` Lars-Peter Clausen 2014-06-09 11:29 ` Lars-Peter Clausen 2014-06-09 11:29 ` Lars-Peter Clausen 2014-06-09 11:29 ` Lars-Peter Clausen 2014-06-09 11:29 ` Lars-Peter Clausen 2014-06-09 13:15 ` Andrzej Hajda 2014-06-09 13:15 ` Andrzej Hajda 2014-06-09 13:15 ` Andrzej Hajda 2014-06-09 13:15 ` Andrzej Hajda 2014-06-09 13:15 ` Andrzej Hajda 2014-06-09 13:43 ` David Laight 2014-06-09 13:43 ` David Laight 2014-06-09 13:43 ` David Laight 2014-06-09 13:43 ` David Laight 2014-06-10 6:57 ` Andrzej Hajda 2014-06-10 6:57 ` Andrzej Hajda 2014-06-10 6:57 ` Andrzej Hajda 2014-06-10 6:57 ` Andrzej Hajda 2014-06-10 6:57 ` Andrzej Hajda 2014-05-30 11:37 ` [PATCH 1/2] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe 2014-05-30 11:37 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe 2014-05-30 15:59 ` [PATCH 1/2] gpio: removes all usage of gpiochip_remove retval Alexandre Courbot 2014-06-04 18:22 ` [PATCH 0/2] gpiochip remove abdoulaye berthe 2014-06-04 18:22 ` [PATCH 1/2] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe 2014-07-04 22:35 ` Linus Walleij 2014-07-05 16:28 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe 2014-07-05 20:28 ` [PATCH] gpio: removes all usage of gpiochip_remove retval abdoulaye berthe 2014-07-09 7:45 ` Linus Walleij 2014-07-12 20:30 ` [PATCH 0/3] remove all usage of gpio_remove retval abdoulaye berthe 2014-07-12 20:30 ` [PATCH 1/1] gpio: remove all usage of gpio_remove retval in driver/gpio abdoulaye berthe 2014-07-12 20:30 ` [PATCH 2/2] pinctrl: remove all usage of gpio_remove ret val in driver/pinctl abdoulaye berthe 2014-07-22 14:34 ` Linus Walleij 2014-07-12 20:30 ` [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver abdoulaye berthe 2014-07-22 15:08 ` Linus Walleij 2014-07-22 15:08 ` Linus Walleij 2014-07-22 15:08 ` Linus Walleij 2014-07-22 15:11 ` Mark Brown 2014-07-22 15:11 ` Mark Brown 2014-07-24 8:29 ` Linus Walleij 2014-07-24 8:29 ` Linus Walleij 2014-07-22 15:17 ` Michael Büsch 2014-07-22 15:17 ` Michael Büsch 2014-07-22 16:01 ` Lee Jones [this message] 2014-07-22 16:01 ` Lee Jones 2014-07-22 17:51 ` Dmitry Torokhov 2014-07-22 17:51 ` Dmitry Torokhov 2014-07-22 19:17 ` Mauro Carvalho Chehab 2014-07-22 19:17 ` Mauro Carvalho Chehab 2014-07-29 11:30 ` Tomi Valkeinen 2014-07-29 11:30 ` Tomi Valkeinen 2014-07-29 11:30 ` Tomi Valkeinen 2014-06-04 18:22 ` [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void abdoulaye berthe 2014-06-08 12:12 ` Alexandre Courbot 2014-06-09 21:22 ` abdoulaye berthe 2014-07-04 22:55 ` Linus Walleij 2014-06-04 18:35 ` [PATCH 0/2] gpiochip remove abdoulaye berthe 2014-05-29 23:25 ` [PATCH] gpio: removes all usage of gpiochip_remove retval Greg KH 2014-05-29 23:25 ` Greg KH 2014-05-29 23:25 ` Greg KH 2014-05-29 23:25 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140722160158.GE23210@lee--X1 \ --to=lee.jones@linaro.org \ --cc=alsa-devel@alsa-project.org \ --cc=arm@kernel.org \ --cc=benh@kernel.crashing.org \ --cc=berthe.ab@gmail.com \ --cc=broonie@kernel.org \ --cc=cooloney@gmail.com \ --cc=gnurou@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=m@bues.ch \ --cc=matthew.garrett@nebula.com \ --cc=sameo@linux.intel.com \ --cc=tomi.valkeinen@ti.com \ --cc=zajec5@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.