[Buildroot] [RFC 0/3] Rename of mpc, gmp, mpfr to libmpc, libgmp, libmpfr

[Buildroot] [RFC 0/3] Rename of mpc, gmp, mpfr to libmpc, libgmp, libmpfr

[Jörg Krause]

Adding the package mpc - a client for mpd - conflicts with mpc - the GNU 
C library.

In most common distros the packages mpc, gmp, and mpfr and prefixed with lib,
namely libmpc, libgmp, and libmpfr. So renaiming results in being more 
consistent and adds clarification that these packages are libraries.

J?rg Krause (3):
  Rename package mpc to libmpc
  Rename package gmp to libgmp
  Rename package mpfr to libmpfr

 package/Config.in                                       |  6 +++---
 package/dnsmasq/Config.in                               |  2 +-
 package/gmp/gmp.mk                                      | 16 ----------------
 package/{gmp => libgmp}/Config.in                       |  4 ++--
 .../libgmp-01-arm-asm-conditional-on-no-thumb-1.patch}  |  0
 .../libgmp-02-arm-asm-conditional-on-no-thumb-2.patch}  |  0
 ...werpc-provide-default-bmod-to-mod-threshold-1.patch} |  0
 package/libgmp/libgmp.mk                                | 16 ++++++++++++++++
 package/{mpc => libmpc}/Config.in                       |  6 +++---
 package/{mpc/mpc.mk => libmpc/libmpc.mk}                | 14 +++++++-------
 package/{mpfr => libmpfr}/Config.in                     |  6 +++---
 package/libmpfr/libmpfr.mk                              | 17 +++++++++++++++++
 package/mpfr/mpfr.mk                                    | 17 -----------------
 package/nettle/Config.in                                |  2 +-
 package/nftables/Config.in                              |  2 +-
 package/openswan/Config.in                              |  2 +-
 package/python-pycrypto/Config.in                       |  2 +-
 package/sconeserver/Config.in                           |  2 +-
 package/strongswan/Config.in                            |  2 +-
 19 files changed, 58 insertions(+), 58 deletions(-)
 delete mode 100644 package/gmp/gmp.mk
 rename package/{gmp => libgmp}/Config.in (64%)
 rename package/{gmp/gmp-01-arm-asm-conditional-on-no-thumb-1.patch => libgmp/libgmp-01-arm-asm-conditional-on-no-thumb-1.patch} (100%)
 rename package/{gmp/gmp-02-arm-asm-conditional-on-no-thumb-2.patch => libgmp/libgmp-02-arm-asm-conditional-on-no-thumb-2.patch} (100%)
 rename package/{gmp/gmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch => libgmp/libgmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch} (100%)
 create mode 100644 package/libgmp/libgmp.mk
 rename package/{mpc => libmpc}/Config.in (79%)
 rename package/{mpc/mpc.mk => libmpc/libmpc.mk} (53%)
 rename package/{mpfr => libmpfr}/Config.in (68%)
 create mode 100644 package/libmpfr/libmpfr.mk
 delete mode 100644 package/mpfr/mpfr.mk

-- 
2.0.2

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Jörg Krause]

Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
 package/Config.in                        |  2 +-
 package/{mpc => libmpc}/Config.in        |  4 ++--
 package/{mpc/mpc.mk => libmpc/libmpc.mk} | 14 +++++++-------
 3 files changed, 10 insertions(+), 10 deletions(-)
 rename package/{mpc => libmpc}/Config.in (87%)
 rename package/{mpc/mpc.mk => libmpc/libmpc.mk} (53%)

diff --git a/package/Config.in b/package/Config.in
index 703fd3d..9370d7c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -838,6 +838,7 @@ menu "Other"
 	source "package/libgc/Config.in"
 	source "package/libglib2/Config.in"
 	source "package/libical/Config.in"
+	source "package/libmpc/Config.in"
 	source "package/libnspr/Config.in"
 	source "package/libpfm4/Config.in"
 	source "package/libplist/Config.in"
@@ -855,7 +856,6 @@ menu "Other"
 	source "package/libuv/Config.in"
 	source "package/linux-pam/Config.in"
 	source "package/lttng-libust/Config.in"
-	source "package/mpc/Config.in"
 	source "package/mpfr/Config.in"
 	source "package/msgpack/Config.in"
 	source "package/mtdev2tuio/Config.in"
diff --git a/package/mpc/Config.in b/package/libmpc/Config.in
similarity index 87%
rename from package/mpc/Config.in
rename to package/libmpc/Config.in
index 8377013..e4b5e01 100644
--- a/package/mpc/Config.in
+++ b/package/libmpc/Config.in
@@ -1,5 +1,5 @@
-config BR2_PACKAGE_MPC
-	bool "mpc"
+config BR2_PACKAGE_LIBMPC
+	bool "libmpc"
 	select BR2_PACKAGE_MPFR
 	select BR2_PACKAGE_GMP
 	help
diff --git a/package/mpc/mpc.mk b/package/libmpc/libmpc.mk
similarity index 53%
rename from package/mpc/mpc.mk
rename to package/libmpc/libmpc.mk
index 81ee5f0..766e113 100644
--- a/package/mpc/mpc.mk
+++ b/package/libmpc/libmpc.mk
@@ -1,15 +1,15 @@
 ################################################################################
 #
-# mpc
+# libmpc
 #
 ################################################################################
 
-MPC_VERSION = 1.0.2
-MPC_SITE = $(BR2_GNU_MIRROR)/mpc
-MPC_LICENSE = LGPLv3+
-MPC_LICENSE_FILES = COPYING.LESSER
-MPC_INSTALL_STAGING = YES
-MPC_DEPENDENCIES = gmp mpfr
+LIBMPC_VERSION = 1.0.2
+LIBMPC_SITE = $(BR2_GNU_MIRROR)/mpc
+LIBMPC_LICENSE = LGPLv3+
+LIBMPC_LICENSE_FILES = COPYING.LESSER
+LIBMPC_INSTALL_STAGING = YES
+LIBMPC_DEPENDENCIES = libgmp libmpfr
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.0.2

[Buildroot] [RFC 2/3] Rename package gmp to libgmp

[Jörg Krause]

Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
 package/Config.in                                        |  2 +-
 package/dnsmasq/Config.in                                |  2 +-
 package/gmp/gmp.mk                                       | 16 ----------------
 package/{gmp => libgmp}/Config.in                        |  4 ++--
 .../libgmp-01-arm-asm-conditional-on-no-thumb-1.patch}   |  0
 .../libgmp-02-arm-asm-conditional-on-no-thumb-2.patch}   |  0
 ...owerpc-provide-default-bmod-to-mod-threshold-1.patch} |  0
 package/libgmp/libgmp.mk                                 | 16 ++++++++++++++++
 package/libmpc/Config.in                                 |  2 +-
 package/mpfr/Config.in                                   |  2 +-
 package/nettle/Config.in                                 |  2 +-
 package/nftables/Config.in                               |  2 +-
 package/openswan/Config.in                               |  2 +-
 package/python-pycrypto/Config.in                        |  2 +-
 package/strongswan/Config.in                             |  2 +-
 15 files changed, 27 insertions(+), 27 deletions(-)
 delete mode 100644 package/gmp/gmp.mk
 rename package/{gmp => libgmp}/Config.in (64%)
 rename package/{gmp/gmp-01-arm-asm-conditional-on-no-thumb-1.patch => libgmp/libgmp-01-arm-asm-conditional-on-no-thumb-1.patch} (100%)
 rename package/{gmp/gmp-02-arm-asm-conditional-on-no-thumb-2.patch => libgmp/libgmp-02-arm-asm-conditional-on-no-thumb-2.patch} (100%)
 rename package/{gmp/gmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch => libgmp/libgmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch} (100%)
 create mode 100644 package/libgmp/libgmp.mk

diff --git a/package/Config.in b/package/Config.in
index 9370d7c..d0feeee 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -818,7 +818,6 @@ menu "Other"
 	source "package/fftw/Config.in"
 	source "package/flann/Config.in"
 	source "package/glibmm/Config.in"
-	source "package/gmp/Config.in"
 	source "package/gsl/Config.in"
 	source "package/gtest/Config.in"
 	source "package/libargtable2/Config.in"
@@ -837,6 +836,7 @@ menu "Other"
 	source "package/libffi/Config.in"
 	source "package/libgc/Config.in"
 	source "package/libglib2/Config.in"
+	source "package/libgmp/Config.in"
 	source "package/libical/Config.in"
 	source "package/libmpc/Config.in"
 	source "package/libnspr/Config.in"
diff --git a/package/dnsmasq/Config.in b/package/dnsmasq/Config.in
index 40376ad..7998fca 100644
--- a/package/dnsmasq/Config.in
+++ b/package/dnsmasq/Config.in
@@ -22,7 +22,7 @@ config BR2_PACKAGE_DNSMASQ_DHCP
 
 config BR2_PACKAGE_DNSMASQ_DNSSEC
 	bool "DNSSEC support"
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 	select BR2_PACKAGE_NETTLE
 	help
 	  Enable DNSSEC validation and caching support.
diff --git a/package/gmp/gmp.mk b/package/gmp/gmp.mk
deleted file mode 100644
index f71a210..0000000
--- a/package/gmp/gmp.mk
+++ /dev/null
@@ -1,16 +0,0 @@
-################################################################################
-#
-# gmp
-#
-################################################################################
-
-GMP_VERSION = 6.0.0a
-GMP_SITE = $(BR2_GNU_MIRROR)/gmp
-GMP_SOURCE = gmp-$(GMP_VERSION).tar.xz
-GMP_INSTALL_STAGING = YES
-GMP_LICENSE = LGPLv3+
-GMP_LICENSE_FILES = COPYING.LESSERv3
-GMP_DEPENDENCIES = host-m4
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
diff --git a/package/gmp/Config.in b/package/libgmp/Config.in
similarity index 64%
rename from package/gmp/Config.in
rename to package/libgmp/Config.in
index 226e088..a2519c5 100644
--- a/package/gmp/Config.in
+++ b/package/libgmp/Config.in
@@ -1,5 +1,5 @@
-config BR2_PACKAGE_GMP
-	bool "gmp"
+config BR2_PACKAGE_LIBGMP
+	bool "libgmp"
 	help
 	  GNU Multiple Precision Arithmetic Library.
 
diff --git a/package/gmp/gmp-01-arm-asm-conditional-on-no-thumb-1.patch b/package/libgmp/libgmp-01-arm-asm-conditional-on-no-thumb-1.patch
similarity index 100%
rename from package/gmp/gmp-01-arm-asm-conditional-on-no-thumb-1.patch
rename to package/libgmp/libgmp-01-arm-asm-conditional-on-no-thumb-1.patch
diff --git a/package/gmp/gmp-02-arm-asm-conditional-on-no-thumb-2.patch b/package/libgmp/libgmp-02-arm-asm-conditional-on-no-thumb-2.patch
similarity index 100%
rename from package/gmp/gmp-02-arm-asm-conditional-on-no-thumb-2.patch
rename to package/libgmp/libgmp-02-arm-asm-conditional-on-no-thumb-2.patch
diff --git a/package/gmp/gmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch b/package/libgmp/libgmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch
similarity index 100%
rename from package/gmp/gmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch
rename to package/libgmp/libgmp-03-powerpc-provide-default-bmod-to-mod-threshold-1.patch
diff --git a/package/libgmp/libgmp.mk b/package/libgmp/libgmp.mk
new file mode 100644
index 0000000..cd61eec
--- /dev/null
+++ b/package/libgmp/libgmp.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# libgmp
+#
+################################################################################
+
+LIBGMP_VERSION = 6.0.0a
+LIBGMP_SITE = $(BR2_GNU_MIRROR)/gmp
+LIBGMP_SOURCE = gmp-$(LIBGMP_VERSION).tar.xz
+LIBGMP_INSTALL_STAGING = YES
+LIBGMP_LICENSE = LGPLv3+
+LIBGMP_LICENSE_FILES = COPYING.LESSERv3
+LIBGMP_DEPENDENCIES = host-m4
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
diff --git a/package/libmpc/Config.in b/package/libmpc/Config.in
index e4b5e01..c000a0c 100644
--- a/package/libmpc/Config.in
+++ b/package/libmpc/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_LIBMPC
 	bool "libmpc"
 	select BR2_PACKAGE_MPFR
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 	help
 	  Mpc is a C library for the arithmetic of complex numbers with
 	  arbitrarily high precision and correct rounding of the result.
diff --git a/package/mpfr/Config.in b/package/mpfr/Config.in
index 9acb0b4..e2f19cc8 100644
--- a/package/mpfr/Config.in
+++ b/package/mpfr/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_MPFR
 	bool "mpfr"
 	default y if BR2_INSTALL_FORTRAN
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 	help
 	  C library for multiple-precision floating-point computations
 	  with exact rounding.
diff --git a/package/nettle/Config.in b/package/nettle/Config.in
index 5577621..2318993 100644
--- a/package/nettle/Config.in
+++ b/package/nettle/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_NETTLE
 	bool "nettle"
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 	help
 	  Nettle is a cryptographic library that is designed to fit easily
 	  in more or less any context: In crypto toolkits for object-oriented
diff --git a/package/nftables/Config.in b/package/nftables/Config.in
index 4ddfdbd..3730951 100644
--- a/package/nftables/Config.in
+++ b/package/nftables/Config.in
@@ -5,7 +5,7 @@ config BR2_PACKAGE_NFTABLES
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 	select BR2_PACKAGE_LIBMNL
 	select BR2_PACKAGE_LIBNFTNL
 	select BR2_PACKAGE_READLINE
diff --git a/package/openswan/Config.in b/package/openswan/Config.in
index 932a75f..8d96666 100644
--- a/package/openswan/Config.in
+++ b/package/openswan/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_OPENSWAN
 	bool "openswan"
 	depends on BR2_USE_MMU # iproute2
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 	select BR2_PACKAGE_IPROUTE2
 	help
 	  Openswan is an implementation of IPsec for Linux
diff --git a/package/python-pycrypto/Config.in b/package/python-pycrypto/Config.in
index fe545b5..163b7dc 100644
--- a/package/python-pycrypto/Config.in
+++ b/package/python-pycrypto/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_PYTHON_PYCRYPTO
 	bool "python-pycrypto"
 	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 	help
 	  PyCrypto is a collection of cryptographic algorithms and
 	  protocols, implemented for use from Python.
diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in
index d2cadf3..76ce0bd 100644
--- a/package/strongswan/Config.in
+++ b/package/strongswan/Config.in
@@ -39,7 +39,7 @@ config BR2_PACKAGE_STRONGSWAN_GCRYPT
 
 config BR2_PACKAGE_STRONGSWAN_GMP
 	bool "GNU MP (libgmp)"
-	select BR2_PACKAGE_GMP
+	select BR2_PACKAGE_LIBGMP
 
 endchoice
 
-- 
2.0.2

[Buildroot] [RFC 3/3] Rename package mpfr to libmpfr

[Jörg Krause]

Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
 package/Config.in                   |  2 +-
 package/{mpfr => libmpfr}/Config.in |  4 ++--
 package/libmpfr/libmpfr.mk          | 17 +++++++++++++++++
 package/mpfr/mpfr.mk                | 17 -----------------
 package/sconeserver/Config.in       |  2 +-
 5 files changed, 21 insertions(+), 21 deletions(-)
 rename package/{mpfr => libmpfr}/Config.in (80%)
 create mode 100644 package/libmpfr/libmpfr.mk
 delete mode 100644 package/mpfr/mpfr.mk

diff --git a/package/Config.in b/package/Config.in
index d0feeee..b81c481 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -839,6 +839,7 @@ menu "Other"
 	source "package/libgmp/Config.in"
 	source "package/libical/Config.in"
 	source "package/libmpc/Config.in"
+	source "package/libmpfr/Config.in"
 	source "package/libnspr/Config.in"
 	source "package/libpfm4/Config.in"
 	source "package/libplist/Config.in"
@@ -856,7 +857,6 @@ menu "Other"
 	source "package/libuv/Config.in"
 	source "package/linux-pam/Config.in"
 	source "package/lttng-libust/Config.in"
-	source "package/mpfr/Config.in"
 	source "package/msgpack/Config.in"
 	source "package/mtdev2tuio/Config.in"
 	source "package/orc/Config.in"
diff --git a/package/mpfr/Config.in b/package/libmpfr/Config.in
similarity index 80%
rename from package/mpfr/Config.in
rename to package/libmpfr/Config.in
index e2f19cc8..56b19da 100644
--- a/package/mpfr/Config.in
+++ b/package/libmpfr/Config.in
@@ -1,5 +1,5 @@
-config BR2_PACKAGE_MPFR
-	bool "mpfr"
+config BR2_PACKAGE_LIBMPFR
+	bool "libmpfr"
 	default y if BR2_INSTALL_FORTRAN
 	select BR2_PACKAGE_LIBGMP
 	help
diff --git a/package/libmpfr/libmpfr.mk b/package/libmpfr/libmpfr.mk
new file mode 100644
index 0000000..da65875
--- /dev/null
+++ b/package/libmpfr/libmpfr.mk
@@ -0,0 +1,17 @@
+################################################################################
+#
+# libmpfr
+#
+################################################################################
+
+LIBMPFR_VERSION = 3.1.2
+LIBMPFR_SITE = http://www.mpfr.org/mpfr-$(LIBMPFR_VERSION)
+LIBMPFR_SOURCE = mpfr-$(LIBMPFR_VERSION).tar.xz
+LIBMPFR_LICENSE = LGPLv3+
+LIBMPFR_LICENSE_FILES = COPYING.LESSER
+LIBMPFR_INSTALL_STAGING = YES
+LIBMPFR_DEPENDENCIES = gmp
+LIBMPFR_MAKE_OPT = RANLIB=$(TARGET_RANLIB)
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
diff --git a/package/mpfr/mpfr.mk b/package/mpfr/mpfr.mk
deleted file mode 100644
index 52d88fe..0000000
--- a/package/mpfr/mpfr.mk
+++ /dev/null
@@ -1,17 +0,0 @@
-################################################################################
-#
-# mpfr
-#
-################################################################################
-
-MPFR_VERSION = 3.1.2
-MPFR_SITE = http://www.mpfr.org/mpfr-$(MPFR_VERSION)
-MPFR_SOURCE = mpfr-$(MPFR_VERSION).tar.xz
-MPFR_LICENSE = LGPLv3+
-MPFR_LICENSE_FILES = COPYING.LESSER
-MPFR_INSTALL_STAGING = YES
-MPFR_DEPENDENCIES = gmp
-MPFR_MAKE_OPT = RANLIB=$(TARGET_RANLIB)
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
diff --git a/package/sconeserver/Config.in b/package/sconeserver/Config.in
index 6999535..2f435b9 100644
--- a/package/sconeserver/Config.in
+++ b/package/sconeserver/Config.in
@@ -79,7 +79,7 @@ config BR2_PACKAGE_SCONESERVER_LETTUCE
 
 config BR2_PACKAGE_SCONESERVER_MATHS
 	bool "maths"
-	select BR2_PACKAGE_MPFR
+	select BR2_PACKAGE_LIBMPFR
 	help
 	  Mathematics module for Sconeserver
 
-- 
2.0.2

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Thomas Petazzoni]

Dear J?rg Krause,

On Mon, 21 Jul 2014 16:12:15 +0200, J?rg Krause wrote:

> diff --git a/package/mpc/mpc.mk b/package/libmpc/libmpc.mk
> similarity index 53%
> rename from package/mpc/mpc.mk
> rename to package/libmpc/libmpc.mk
> index 81ee5f0..766e113 100644
> --- a/package/mpc/mpc.mk
> +++ b/package/libmpc/libmpc.mk
> @@ -1,15 +1,15 @@
>  ################################################################################
>  #
> -# mpc
> +# libmpc
>  #
>  ################################################################################
>  
> -MPC_VERSION = 1.0.2
> -MPC_SITE = $(BR2_GNU_MIRROR)/mpc
> -MPC_LICENSE = LGPLv3+
> -MPC_LICENSE_FILES = COPYING.LESSER
> -MPC_INSTALL_STAGING = YES
> -MPC_DEPENDENCIES = gmp mpfr
> +LIBMPC_VERSION = 1.0.2
> +LIBMPC_SITE = $(BR2_GNU_MIRROR)/mpc
> +LIBMPC_LICENSE = LGPLv3+
> +LIBMPC_LICENSE_FILES = COPYING.LESSER
> +LIBMPC_INSTALL_STAGING = YES
> +LIBMPC_DEPENDENCIES = libgmp libmpfr

Did you actually test this? With the package named "mpc", we didn't had
to define MPC_SOURCE, as it is inferred from the package name. If the
package is named "libmpc", then surely, there needs to be a
LIBMPC_SOURCE specification.

That being said, I would prefer to find a different name for the mpc
package (mpd client) rather than renaming existing packages.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Gustavo Zacarias]

On 07/21/2014 11:25 AM, Thomas Petazzoni wrote:

> That being said, I would prefer to find a different name for the mpc
> package (mpd client) rather than renaming existing packages.

+1
Renaming it is potentially very problematic for people that use mpc
(multiprecision library) for their own projects, mpc would be a
completely different thing now and we can't make it legacy either since
there would be a new mpc.
Just call it mpclient and use a different bool IMHO.
Regards.

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Thomas Petazzoni]

Hello,

On Mon, 21 Jul 2014 13:30:03 -0300, Gustavo Zacarias wrote:
> On 07/21/2014 11:25 AM, Thomas Petazzoni wrote:
> 
> > That being said, I would prefer to find a different name for the mpc
> > package (mpd client) rather than renaming existing packages.
> 
> +1
> Renaming it is potentially very problematic for people that use mpc
> (multiprecision library) for their own projects, mpc would be a
> completely different thing now and we can't make it legacy either since
> there would be a new mpc.
> Just call it mpclient and use a different bool IMHO.

Agreed. "mpclient" sounds like a good alternative.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Jörg Krause]

Dear Thomas,
Dear Gustavo,

On 07/21/2014 08:19 PM, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 21 Jul 2014 13:30:03 -0300, Gustavo Zacarias wrote:
>> On 07/21/2014 11:25 AM, Thomas Petazzoni wrote:
>>
>>> That being said, I would prefer to find a different name for the mpc
>>> package (mpd client) rather than renaming existing packages.
>> +1
>> Renaming it is potentially very problematic for people that use mpc
>> (multiprecision library) for their own projects, mpc would be a
>> completely different thing now and we can't make it legacy either since
>> there would be a new mpc.
>> Just call it mpclient and use a different bool IMHO.
> Agreed. "mpclient" sounds like a good alternative.

okay, I understand that renaming is potentially problematic. But the 
package mpc is not a dependency for any package. gmp is a dependency for 
eight packages, and mpfr for one.

Looking at Debian, Arch, and Fedora, these packages are all named 
libmpc, libgmp, and libmpfr. I liked the idea of having consistent 
package names. And if I am searching for mpc in the menuconfig I find 
the multiprecision library as libmpc and the mpd client as mpc. So it's 
not to difficult to find the right package.

There are dozen of clients for mpd. At least calling the package 
"mpclient" will show my the package when searching for "mpc" in the 
menuconfig.

Btw, is there any rule for duplicate names?

Best regards
J?rg

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Gustavo Zacarias]

On 07/22/2014 05:23 AM, J?rg Krause wrote:

Hello.

> okay, I understand that renaming is potentially problematic. But the
> package mpc is not a dependency for any package. gmp is a dependency for
> eight packages, and mpfr for one.
> 
> Looking at Debian, Arch, and Fedora, these packages are all named
> libmpc, libgmp, and libmpfr. I liked the idea of having consistent
> package names. And if I am searching for mpc in the menuconfig I find
> the multiprecision library as libmpc and the mpd client as mpc. So it's
> not to difficult to find the right package.

Well in gentoo mpfr is mpfr and so no, not prepended by lib since there
are categories which allows for duplicate naming.
The problem is if someone uses mpc in their custom packages, there's no
easy way of warning about the rename.

> There are dozen of clients for mpd. At least calling the package
> "mpclient" will show my the package when searching for "mpc" in the
> menuconfig.
> 
> Btw, is there any rule for duplicate names?

Yes that was the idea, mpclient doesn't sound right, but search works,
we could as well use mpcclient for example.
There's no rule for duplicates, best effort comes to mind.
Regards.

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Yann E. MORIN]

Gustavo, J?rg, All,

On 2014-07-22 07:20 -0300, Gustavo Zacarias spake thusly:
> On 07/22/2014 05:23 AM, J?rg Krause wrote:
> > okay, I understand that renaming is potentially problematic. But the
> > package mpc is not a dependency for any package. gmp is a dependency for
> > eight packages, and mpfr for one.
> > 
> > Looking at Debian, Arch, and Fedora, these packages are all named
> > libmpc, libgmp, and libmpfr. I liked the idea of having consistent
> > package names. And if I am searching for mpc in the menuconfig I find
> > the multiprecision library as libmpc and the mpd client as mpc. So it's
> > not to difficult to find the right package.
> 
> Well in gentoo mpfr is mpfr and so no, not prepended by lib since there
> are categories which allows for duplicate naming.
> The problem is if someone uses mpc in their custom packages, there's no
> easy way of warning about the rename.

Not only that, but users re-using a .config from a previous Buildroot
version would also be a problem.

We can not have a legacy symbol for mpc as our previous "libmpc" and a
new symbol for mpc as the new package "mpd client", since that would be
the same symbol.

So, I agree with Thomas here: we should not rename the current mpc, and
find an alternate name for the new mpc.

> > There are dozen of clients for mpd. At least calling the package
> > "mpclient" will show my the package when searching for "mpc" in the
> > menuconfig.
> Yes that was the idea, mpclient doesn't sound right, but search works,
> we could as well use mpcclient for example.

Or mpd-mpc.

> > Btw, is there any rule for duplicate names?
> There's no rule for duplicates, best effort comes to mind.

Untold policy is: first come, first served. ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [RFC 1/3] Rename package mpc to libmpc

[Jörg Krause]

Dear all,

On 07/22/2014 07:02 PM, Yann E. MORIN wrote:
> Gustavo, J?rg, All,
>
> On 2014-07-22 07:20 -0300, Gustavo Zacarias spake thusly:
>> On 07/22/2014 05:23 AM, J?rg Krause wrote:
>>> okay, I understand that renaming is potentially problematic. But the
>>> package mpc is not a dependency for any package. gmp is a dependency for
>>> eight packages, and mpfr for one.
>>>
>>> Looking at Debian, Arch, and Fedora, these packages are all named
>>> libmpc, libgmp, and libmpfr. I liked the idea of having consistent
>>> package names. And if I am searching for mpc in the menuconfig I find
>>> the multiprecision library as libmpc and the mpd client as mpc. So it's
>>> not to difficult to find the right package.
>> Well in gentoo mpfr is mpfr and so no, not prepended by lib since there
>> are categories which allows for duplicate naming.
>> The problem is if someone uses mpc in their custom packages, there's no
>> easy way of warning about the rename.
> Not only that, but users re-using a .config from a previous Buildroot
> version would also be a problem.
>
> We can not have a legacy symbol for mpc as our previous "libmpc" and a
> new symbol for mpc as the new package "mpd client", since that would be
> the same symbol.
>
> So, I agree with Thomas here: we should not rename the current mpc, and
> find an alternate name for the new mpc.

Okay, you all convinced me :-) We leave it as it is.

>
>>> There are dozen of clients for mpd. At least calling the package
>>> "mpclient" will show my the package when searching for "mpc" in the
>>> menuconfig.
>> Yes that was the idea, mpclient doesn't sound right, but search works,
>> we could as well use mpcclient for example.
> Or mpd-mpc.

This was my idea, too. I think I will choose this name.

>
>>> Btw, is there any rule for duplicate names?
>> There's no rule for duplicates, best effort comes to mind.
> Untold policy is: first come, first served. ;-)

Damn, so I am much to late ;-)

Thanky you all for the discussion! So I think we can close this topic now.

Best regards
J?rg