From: Catalin Marinas <catalin.marinas@arm.com>
To: Laura Abbott <lauraa@codeaurora.org>
Cc: Will Deacon <Will.Deacon@arm.com>,
David Riley <davidriley@chromium.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Ritesh Harjain <ritesh.harjani@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCHv4 3/5] common: dma-mapping: Introduce common remapping functions
Date: Wed, 23 Jul 2014 12:16:09 +0100 [thread overview]
Message-ID: <20140723111608.GC1366@localhost> (raw)
In-Reply-To: <1406079308-5232-4-git-send-email-lauraa@codeaurora.org>
On Wed, Jul 23, 2014 at 02:35:06AM +0100, Laura Abbott wrote:
> +void dma_common_free_remap(void *cpu_addr, size_t size, unsigned long vm_flags)
> +{
> + struct vm_struct *area = find_vm_area(cpu_addr);
> +
> + if (!area || (area->flags & vm_flags) != vm_flags) {
> + WARN(1, "trying to free invalid coherent area: %p\n", cpu_addr);
> + return;
> + }
> +
> + unmap_kernel_range((unsigned long)cpu_addr, size);
> + vunmap(cpu_addr);
> +}
One more thing - is unmap_kernel_range() needed here? vunmap() ends up
calling vunmap_page_range(), same as unmap_kernel_range(). I think one
difference is that in the vunmap case, TLB flushing is done lazily.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Laura Abbott <lauraa@codeaurora.org>
Cc: Will Deacon <Will.Deacon@arm.com>,
David Riley <davidriley@chromium.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Ritesh Harjain <ritesh.harjani@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCHv4 3/5] common: dma-mapping: Introduce common remapping functions
Date: Wed, 23 Jul 2014 12:16:09 +0100 [thread overview]
Message-ID: <20140723111608.GC1366@localhost> (raw)
In-Reply-To: <1406079308-5232-4-git-send-email-lauraa@codeaurora.org>
On Wed, Jul 23, 2014 at 02:35:06AM +0100, Laura Abbott wrote:
> +void dma_common_free_remap(void *cpu_addr, size_t size, unsigned long vm_flags)
> +{
> + struct vm_struct *area = find_vm_area(cpu_addr);
> +
> + if (!area || (area->flags & vm_flags) != vm_flags) {
> + WARN(1, "trying to free invalid coherent area: %p\n", cpu_addr);
> + return;
> + }
> +
> + unmap_kernel_range((unsigned long)cpu_addr, size);
> + vunmap(cpu_addr);
> +}
One more thing - is unmap_kernel_range() needed here? vunmap() ends up
calling vunmap_page_range(), same as unmap_kernel_range(). I think one
difference is that in the vunmap case, TLB flushing is done lazily.
--
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 3/5] common: dma-mapping: Introduce common remapping functions
Date: Wed, 23 Jul 2014 12:16:09 +0100 [thread overview]
Message-ID: <20140723111608.GC1366@localhost> (raw)
In-Reply-To: <1406079308-5232-4-git-send-email-lauraa@codeaurora.org>
On Wed, Jul 23, 2014 at 02:35:06AM +0100, Laura Abbott wrote:
> +void dma_common_free_remap(void *cpu_addr, size_t size, unsigned long vm_flags)
> +{
> + struct vm_struct *area = find_vm_area(cpu_addr);
> +
> + if (!area || (area->flags & vm_flags) != vm_flags) {
> + WARN(1, "trying to free invalid coherent area: %p\n", cpu_addr);
> + return;
> + }
> +
> + unmap_kernel_range((unsigned long)cpu_addr, size);
> + vunmap(cpu_addr);
> +}
One more thing - is unmap_kernel_range() needed here? vunmap() ends up
calling vunmap_page_range(), same as unmap_kernel_range(). I think one
difference is that in the vunmap case, TLB flushing is done lazily.
--
Catalin
next prev parent reply other threads:[~2014-07-23 11:16 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 1:35 [PATCHv4 0/5] Atomic pool for arm64 Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` [PATCHv4 1/5] lib/genalloc.c: Add power aligned algorithm Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` [PATCHv4 2/5] lib/genalloc.c: Add genpool range check function Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` [PATCHv4 3/5] common: dma-mapping: Introduce common remapping functions Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 10:45 ` Catalin Marinas
2014-07-23 10:45 ` Catalin Marinas
2014-07-23 10:45 ` Catalin Marinas
2014-07-23 21:56 ` Laura Abbott
2014-07-23 21:56 ` Laura Abbott
2014-07-23 21:56 ` Laura Abbott
2014-07-24 13:52 ` Catalin Marinas
2014-07-24 13:52 ` Catalin Marinas
2014-07-24 13:52 ` Catalin Marinas
2014-07-23 11:16 ` Catalin Marinas [this message]
2014-07-23 11:16 ` Catalin Marinas
2014-07-23 11:16 ` Catalin Marinas
2014-07-23 1:35 ` [PATCHv4 4/5] arm: use genalloc for the atomic pool Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` [PATCHv4 5/5] arm64: Add atomic pool for non-coherent and CMA allocations Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-23 1:35 ` Laura Abbott
2014-07-24 13:56 ` [PATCHv4 0/5] Atomic pool for arm64 Catalin Marinas
2014-07-24 13:56 ` Catalin Marinas
2014-07-24 13:56 ` Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2014-07-02 18:03 [PATCHv4 0/5] DMA " Laura Abbott
2014-07-02 18:03 ` [PATCHv4 3/5] common: dma-mapping: Introduce common remapping functions Laura Abbott
2014-07-02 18:03 ` Laura Abbott
2014-07-02 18:03 ` Laura Abbott
2014-07-09 22:46 ` Olof Johansson
2014-07-09 22:46 ` Olof Johansson
2014-07-09 22:46 ` Olof Johansson
2014-07-18 14:13 ` Catalin Marinas
2014-07-18 14:13 ` Catalin Marinas
2014-07-18 14:13 ` Catalin Marinas
2014-07-18 13:53 ` Catalin Marinas
2014-07-18 13:53 ` Catalin Marinas
2014-07-18 13:53 ` Catalin Marinas
2014-07-21 19:33 ` Laura Abbott
2014-07-21 19:33 ` Laura Abbott
2014-07-21 19:33 ` Laura Abbott
2014-07-22 16:04 ` Catalin Marinas
2014-07-22 16:04 ` Catalin Marinas
2014-07-22 16:04 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723111608.GC1366@localhost \
--to=catalin.marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=davidriley@chromium.org \
--cc=lauraa@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=ritesh.harjani@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.