* [PATCH] net_sched: remove exceptional & on function name
@ 2014-07-24 20:20 Himangi Saraogi
2014-07-25 6:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Himangi Saraogi @ 2014-07-24 20:20 UTC (permalink / raw)
To: Jamal Hadi Salim, David S. Miller, netdev, linux-kernel; +Cc: Julia Lawall
In this file, function names are otherwise used as pointers without &.
A simplified version of the Coccinelle semantic patch that makes this
change is as follows:
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
net/sched/cls_tcindex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
index c721cd4..3e9f764 100644
--- a/net/sched/cls_tcindex.c
+++ b/net/sched/cls_tcindex.c
@@ -420,7 +420,7 @@ static void tcindex_destroy(struct tcf_proto *tp)
pr_debug("tcindex_destroy(tp %p),p %p\n", tp, p);
walker.count = 0;
walker.skip = 0;
- walker.fn = &tcindex_destroy_element;
+ walker.fn = tcindex_destroy_element;
tcindex_walk(tp, &walker);
kfree(p->perfect);
kfree(p->h);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net_sched: remove exceptional & on function name
2014-07-24 20:20 [PATCH] net_sched: remove exceptional & on function name Himangi Saraogi
@ 2014-07-25 6:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-25 6:25 UTC (permalink / raw)
To: himangi774; +Cc: jhs, netdev, linux-kernel, julia.lawall
From: Himangi Saraogi <himangi774@gmail.com>
Date: Fri, 25 Jul 2014 01:50:41 +0530
> In this file, function names are otherwise used as pointers without &.
>
> A simplified version of the Coccinelle semantic patch that makes this
> change is as follows:
...
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-25 6:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-24 20:20 [PATCH] net_sched: remove exceptional & on function name Himangi Saraogi
2014-07-25 6:25 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.