All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Maxime COQUELIN <maxime.coquelin@st.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	kernel@stlinux.com
Subject: Re: [PATCH v2] drivers: i2c: i2c-st: Update i2c timings
Date: Fri, 1 Aug 2014 19:48:30 +0200	[thread overview]
Message-ID: <20140801174830.GC3277@katana> (raw)
In-Reply-To: <1406130247-19197-1-git-send-email-maxime.coquelin@st.com>

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Wed, Jul 23, 2014 at 05:44:07PM +0200, Maxime COQUELIN wrote:
> The i2c timing values specified in the driver are the minimun values defined
> in the I2C specifications.
> The I2C specification does not specify any default or maximum values.
> 
> Some I2C devices are out of spec, such as the HDMI link of the Toshiba 19AV600
> TV, and might not work properly with minimum values.
> 
> This patch adds a 10% margin on all the timings in both Normal and Fast modes.
> 
> Trial and error method have been used to find the minimum margin necessary to
> have the out-of-spec device working, and a security margin has been added.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Maxime COQUELIN <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Srinivas Kandagatla
	<srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Patrice Chotard <patrice.chotard-qxv4g6HH51o@public.gmane.org>,
	kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v2] drivers: i2c: i2c-st: Update i2c timings
Date: Fri, 1 Aug 2014 19:48:30 +0200	[thread overview]
Message-ID: <20140801174830.GC3277@katana> (raw)
In-Reply-To: <1406130247-19197-1-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

On Wed, Jul 23, 2014 at 05:44:07PM +0200, Maxime COQUELIN wrote:
> The i2c timing values specified in the driver are the minimun values defined
> in the I2C specifications.
> The I2C specification does not specify any default or maximum values.
> 
> Some I2C devices are out of spec, such as the HDMI link of the Toshiba 19AV600
> TV, and might not work properly with minimum values.
> 
> This patch adds a 10% margin on all the timings in both Normal and Fast modes.
> 
> Trial and error method have been used to find the minimum margin necessary to
> have the out-of-spec device working, and a security margin has been added.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-08-01 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 15:44 [PATCH v2] drivers: i2c: i2c-st: Update i2c timings Maxime COQUELIN
2014-07-23 15:44 ` Maxime COQUELIN
2014-08-01 17:48 ` Wolfram Sang [this message]
2014-08-01 17:48   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140801174830.GC3277@katana \
    --to=wsa@the-dreams.de \
    --cc=kernel@stlinux.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.coquelin@st.com \
    --cc=patrice.chotard@st.com \
    --cc=srinivas.kandagatla@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.