* [PATCH] net: wireless: wl1251: Remove unnecessary free_irq
@ 2014-08-02 11:21 ` Himangi Saraogi
0 siblings, 0 replies; 2+ messages in thread
From: Himangi Saraogi @ 2014-08-02 11:21 UTC (permalink / raw)
To: John W. Linville, linux-wireless, netdev, linux-kernel; +Cc: julia.lawall
This patch does away with free_irq in the remove function as the irq is
allocated with a devm_request_irq.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
I'm not sure that devm_request_irq should be used in
the first place, as it will move the stopping of the interrupt over
wl1251_free_hw. Should I use request_irq?
drivers/net/wireless/ti/wl1251/spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/spi.c b/drivers/net/wireless/ti/wl1251/spi.c
index a0aa8fa..735be53 100644
--- a/drivers/net/wireless/ti/wl1251/spi.c
+++ b/drivers/net/wireless/ti/wl1251/spi.c
@@ -345,7 +345,6 @@ static int wl1251_spi_remove(struct spi_device *spi)
{
struct wl1251 *wl = spi_get_drvdata(spi);
- free_irq(wl->irq, wl);
wl1251_free_hw(wl);
regulator_disable(wl->vio);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] net: wireless: wl1251: Remove unnecessary free_irq
@ 2014-08-02 11:21 ` Himangi Saraogi
0 siblings, 0 replies; 2+ messages in thread
From: Himangi Saraogi @ 2014-08-02 11:21 UTC (permalink / raw)
To: John W. Linville, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: julia.lawall-L2FTfq7BK8M
This patch does away with free_irq in the remove function as the irq is
allocated with a devm_request_irq.
Signed-off-by: Himangi Saraogi <himangi774-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
I'm not sure that devm_request_irq should be used in
the first place, as it will move the stopping of the interrupt over
wl1251_free_hw. Should I use request_irq?
drivers/net/wireless/ti/wl1251/spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/spi.c b/drivers/net/wireless/ti/wl1251/spi.c
index a0aa8fa..735be53 100644
--- a/drivers/net/wireless/ti/wl1251/spi.c
+++ b/drivers/net/wireless/ti/wl1251/spi.c
@@ -345,7 +345,6 @@ static int wl1251_spi_remove(struct spi_device *spi)
{
struct wl1251 *wl = spi_get_drvdata(spi);
- free_irq(wl->irq, wl);
wl1251_free_hw(wl);
regulator_disable(wl->vio);
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-02 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-02 11:21 [PATCH] net: wireless: wl1251: Remove unnecessary free_irq Himangi Saraogi
2014-08-02 11:21 ` Himangi Saraogi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.