All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in format string
@ 2014-08-04  0:19 Hans Wennborg
  2014-08-04 13:30 ` Dimitri Sivanich
  0 siblings, 1 reply; 4+ messages in thread
From: Hans Wennborg @ 2014-08-04  0:19 UTC (permalink / raw)
  To: sivanich, linux-kernel; +Cc: Hans Wennborg

Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
 drivers/misc/sgi-gru/grumain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index ae16c8c..a1ce324 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
 	spin_lock(&gru->gs_asid_lock);
 	BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
 	asids->mt_ctxbitmap ^= ctxbitmap;
-	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
+	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
 		gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
 	spin_unlock(&gru->gs_asid_lock);
 	spin_unlock(&gms->ms_asid_lock);
-- 
2.0.0.526.g5318336


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in format string
  2014-08-04  0:19 [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in format string Hans Wennborg
@ 2014-08-04 13:30 ` Dimitri Sivanich
  2014-08-05  0:58   ` [PATCH 1/1] " Hans Wennborg
  0 siblings, 1 reply; 4+ messages in thread
From: Dimitri Sivanich @ 2014-08-04 13:30 UTC (permalink / raw)
  To: Hans Wennborg; +Cc: linux-kernel

Decimal ("%d" without the "0x") for the ctxnum please.

Nacked-by: Dimitri Sivanich <sivanich@sgi.com>

On Sun, Aug 03, 2014 at 05:19:37PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
>  drivers/misc/sgi-gru/grumain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index ae16c8c..a1ce324 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
>  	spin_lock(&gru->gs_asid_lock);
>  	BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
>  	asids->mt_ctxbitmap ^= ctxbitmap;
> -	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> +	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
>  		gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
>  	spin_unlock(&gru->gs_asid_lock);
>  	spin_unlock(&gms->ms_asid_lock);
> -- 
> 2.0.0.526.g5318336

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] gru: fix %d confusingly prefixed with 0x in format string
  2014-08-04 13:30 ` Dimitri Sivanich
@ 2014-08-05  0:58   ` Hans Wennborg
  2014-08-05 12:23     ` Dimitri Sivanich
  0 siblings, 1 reply; 4+ messages in thread
From: Hans Wennborg @ 2014-08-05  0:58 UTC (permalink / raw)
  To: sivanich, linux-kernel; +Cc: Hans Wennborg

Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
 drivers/misc/sgi-gru/grumain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index ae16c8c..161a940 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
 	spin_lock(&gru->gs_asid_lock);
 	BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
 	asids->mt_ctxbitmap ^= ctxbitmap;
-	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
+	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum %d, asidmap 0x%lx\n",
 		gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
 	spin_unlock(&gru->gs_asid_lock);
 	spin_unlock(&gms->ms_asid_lock);
-- 
2.0.0.526.g5318336


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] gru: fix %d confusingly prefixed with 0x in format string
  2014-08-05  0:58   ` [PATCH 1/1] " Hans Wennborg
@ 2014-08-05 12:23     ` Dimitri Sivanich
  0 siblings, 0 replies; 4+ messages in thread
From: Dimitri Sivanich @ 2014-08-05 12:23 UTC (permalink / raw)
  To: Hans Wennborg; +Cc: linux-kernel

Acked-by: Dimitri Sivanich <sivanich@sgi.com>

On Mon, Aug 04, 2014 at 05:58:05PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
>  drivers/misc/sgi-gru/grumain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
> index ae16c8c..161a940 100644
> --- a/drivers/misc/sgi-gru/grumain.c
> +++ b/drivers/misc/sgi-gru/grumain.c
> @@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
>  	spin_lock(&gru->gs_asid_lock);
>  	BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
>  	asids->mt_ctxbitmap ^= ctxbitmap;
> -	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
> +	gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum %d, asidmap 0x%lx\n",
>  		gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
>  	spin_unlock(&gru->gs_asid_lock);
>  	spin_unlock(&gms->ms_asid_lock);
> -- 
> 2.0.0.526.g5318336

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-08-05 12:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-04  0:19 [PATCH 08/19] gru: fix %d confusingly prefixed with 0x in format string Hans Wennborg
2014-08-04 13:30 ` Dimitri Sivanich
2014-08-05  0:58   ` [PATCH 1/1] " Hans Wennborg
2014-08-05 12:23     ` Dimitri Sivanich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.