From: Antonio Ospite <ao2@ao2.it>
To: Vikrampal <vikram.pal@samsung.com>
Cc: 'Luiz Augusto von Dentz' <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org,
'Dmitry Kasatkin' <d.kasatkin@samsung.com>
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
Date: Tue, 5 Aug 2014 13:51:38 +0200 [thread overview]
Message-ID: <20140805135138.4d27987b16680f617c27582b@ao2.it> (raw)
In-Reply-To: <002f01cfb07a$2502c170$6f084450$@samsung.com>
On Tue, 05 Aug 2014 12:24:44 +0530
Vikrampal <vikram.pal@samsung.com> wrote:
> Sure Luiz!
>
> However, I've one more small doubt. If I'm submitting a series of patches
> Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that
> the patches separately compiles. What we need to ensure is that all the patches together
> gets compiled properly. Am I mistaken?
>
Make sure that sub-sequences of a series produce sensible code.
The code should $VALIDATE with 1/4 applied.
The code should $VALIDATE with 1/4 and 2/4 applied.
The code should $VALIDATE with 1/4, 2/4 and 3/4 applied.
The code should $VALIDATE with 1/4, 2/4, 3/4 and 4/4 applied.
The definition of VALIDATE can vary project by project or feature by
feature; the minimum requirement should be that compilation always
succeeds.
You can use something like:
git rebase -i --exec "make" some_parent_branch
to test that compilation passes after each commit.
Ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
next prev parent reply other threads:[~2014-08-05 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 8:48 AVCTP and AVRCP packet decoder file structure in btmon Vikrampal
2014-08-04 10:45 ` Luiz Augusto von Dentz
2014-08-05 6:54 ` Vikrampal
2014-08-05 8:01 ` Luiz Augusto von Dentz
2014-08-05 9:12 ` Vikrampal
2014-08-05 9:13 ` Vikrampal
2014-08-05 11:51 ` Antonio Ospite [this message]
2014-08-06 8:18 ` Vikrampal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805135138.4d27987b16680f617c27582b@ao2.it \
--to=ao2@ao2.it \
--cc=d.kasatkin@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=vikram.pal@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.