* [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed with 0x
@ 2014-08-06 4:44 ` Hans Wennborg
0 siblings, 0 replies; 4+ messages in thread
From: Hans Wennborg @ 2014-08-06 4:44 UTC (permalink / raw)
To: david, xfs, linux-kernel; +Cc: Hans Wennborg
The prefix suggests the number should be printed in hex, so use
the %x specifier to do that.
Found by using regex suggested by Joe Perches.
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
fs/xfs/xfs_discard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index 13d08a1..b4a2415 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -228,7 +228,7 @@ xfs_discard_extents(
GFP_NOFS, 0);
if (error && error != -EOPNOTSUPP) {
xfs_info(mp,
- "discard failed for extent [0x%llu,%u], error %d",
+ "discard failed for extent [0x%llx,%u], error %d",
(unsigned long long)busyp->bno,
busyp->length,
error);
--
2.0.0.526.g5318336
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed with 0x
@ 2014-08-06 4:44 ` Hans Wennborg
0 siblings, 0 replies; 4+ messages in thread
From: Hans Wennborg @ 2014-08-06 4:44 UTC (permalink / raw)
To: david, xfs, linux-kernel; +Cc: Hans Wennborg
The prefix suggests the number should be printed in hex, so use
the %x specifier to do that.
Found by using regex suggested by Joe Perches.
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
fs/xfs/xfs_discard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
index 13d08a1..b4a2415 100644
--- a/fs/xfs/xfs_discard.c
+++ b/fs/xfs/xfs_discard.c
@@ -228,7 +228,7 @@ xfs_discard_extents(
GFP_NOFS, 0);
if (error && error != -EOPNOTSUPP) {
xfs_info(mp,
- "discard failed for extent [0x%llu,%u], error %d",
+ "discard failed for extent [0x%llx,%u], error %d",
(unsigned long long)busyp->bno,
busyp->length,
error);
--
2.0.0.526.g5318336
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed with 0x
2014-08-06 4:44 ` Hans Wennborg
@ 2014-08-06 12:24 ` Brian Foster
-1 siblings, 0 replies; 4+ messages in thread
From: Brian Foster @ 2014-08-06 12:24 UTC (permalink / raw)
To: Hans Wennborg; +Cc: david, xfs, linux-kernel
On Tue, Aug 05, 2014 at 09:44:16PM -0700, Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
>
> Found by using regex suggested by Joe Perches.
>
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> fs/xfs/xfs_discard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index 13d08a1..b4a2415 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -228,7 +228,7 @@ xfs_discard_extents(
> GFP_NOFS, 0);
> if (error && error != -EOPNOTSUPP) {
> xfs_info(mp,
> - "discard failed for extent [0x%llu,%u], error %d",
> + "discard failed for extent [0x%llx,%u], error %d",
> (unsigned long long)busyp->bno,
> busyp->length,
> error);
It's kind of annoying seeing values of multiple bases being used to
describe a single extent, imo. But using 0x before a decimal value
certainly isn't nice... ;)
Reviewed-by: Brian Foster <bfoster@redhat.com>
> --
> 2.0.0.526.g5318336
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed with 0x
@ 2014-08-06 12:24 ` Brian Foster
0 siblings, 0 replies; 4+ messages in thread
From: Brian Foster @ 2014-08-06 12:24 UTC (permalink / raw)
To: Hans Wennborg; +Cc: linux-kernel, xfs
On Tue, Aug 05, 2014 at 09:44:16PM -0700, Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
>
> Found by using regex suggested by Joe Perches.
>
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> fs/xfs/xfs_discard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index 13d08a1..b4a2415 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -228,7 +228,7 @@ xfs_discard_extents(
> GFP_NOFS, 0);
> if (error && error != -EOPNOTSUPP) {
> xfs_info(mp,
> - "discard failed for extent [0x%llu,%u], error %d",
> + "discard failed for extent [0x%llx,%u], error %d",
> (unsigned long long)busyp->bno,
> busyp->length,
> error);
It's kind of annoying seeing values of multiple bases being used to
describe a single extent, imo. But using 0x before a decimal value
certainly isn't nice... ;)
Reviewed-by: Brian Foster <bfoster@redhat.com>
> --
> 2.0.0.526.g5318336
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-06 12:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-06 4:44 [PATCH 14/15] xfs: fix decimal printf format specifiers prefixed with 0x Hans Wennborg
2014-08-06 4:44 ` Hans Wennborg
2014-08-06 12:24 ` Brian Foster
2014-08-06 12:24 ` Brian Foster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.