All of lore.kernel.org
 help / color / mirror / Atom feed
* BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-07 11:52 ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-08-07 11:52 UTC (permalink / raw)
  To: Joonsoo Kim
  Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

Hi Joonsoo,

On Tue, Jul 1, 2014 at 10:27 AM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> BAD_ALIEN_MAGIC value isn't used anymore. So remove it.
>
> Acked-by: Christoph Lameter <cl@linux.com>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
>  mm/slab.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 7820a45..60c9e11 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -470,8 +470,6 @@ static struct kmem_cache kmem_cache_boot = {
>         .name = "kmem_cache",
>  };
>
> -#define BAD_ALIEN_MAGIC 0x01020304ul
> -
>  static DEFINE_PER_CPU(struct delayed_work, slab_reap_work);
>
>  static inline struct array_cache *cpu_cache_get(struct kmem_cache *cachep)
> @@ -838,7 +836,7 @@ static int transfer_objects(struct array_cache *to,
>  static inline struct alien_cache **alloc_alien_cache(int node,
>                                                 int limit, gfp_t gfp)
>  {
> -       return (struct alien_cache **)BAD_ALIEN_MAGIC;
> +       return NULL;
>  }

With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:

enable_cpucache failed for radix_tree_node, error 12.
kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
*** TRAP #7 ***   FORMAT=0
Current process id is 0
BAD KERNEL TRAP: 00000000
Modules linked in:
PC: [<0039c92c>] kmem_cache_init_late+0x70/0x8c
SR: 2200  SP: 00345f90  a2: 0034c2e8
d0: 0000003d    d1: 00000000    d2: 00000000    d3: 003ac942
d4: 00000000    d5: 00000000    a0: 0034f686    a1: 0034f682
Process swapper (pid: 0, task=0034c2e8)
Frame format=0
Stack from 00345fc4:
        002f69ef 002ff7e5 000005f2 000360fa 0017d806 003921d4 00000000 00000000
        00000000 00000000 00000000 00000000 003ac942 00000000 003912d6
Call Trace: [<000360fa>] parse_args+0x0/0x2ca
 [<0017d806>] strlen+0x0/0x1a
 [<003921d4>] start_kernel+0x23c/0x428
 [<003912d6>] _sinittext+0x2d6/0x95e

Code: f7e5 4879 002f 69ef 61ff ffca 462a 4e47 <4879> 0035 4b1c 61ff
fff0 0cc4 7005 23c0 0037 fd20 588f 265f 285f 4e75 48e7 301c
Disabling lock debugging due to kernel taint
Kernel panic - not syncing: Attempted to kill the idle task!
---[ end Kernel panic - not syncing: Attempted to kill the idle task!

I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Date:   Wed Aug 6 16:04:38 2014 -0700

    slab: remove BAD_ALIEN_MAGIC

    BAD_ALIEN_MAGIC value isn't used anymore. So remove it.

    Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Acked-by: Christoph Lameter <cl@linux.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: David Rientjes <rientjes@google.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Error 12 is ENOMEM, so I first thought it went out-of-memory, but just reverting
the above commit on mainline makes it work again.

I don't see the failure on ARM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-07 11:52 ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-08-07 11:52 UTC (permalink / raw)
  To: Joonsoo Kim
  Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

Hi Joonsoo,

On Tue, Jul 1, 2014 at 10:27 AM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> BAD_ALIEN_MAGIC value isn't used anymore. So remove it.
>
> Acked-by: Christoph Lameter <cl@linux.com>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
>  mm/slab.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 7820a45..60c9e11 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -470,8 +470,6 @@ static struct kmem_cache kmem_cache_boot = {
>         .name = "kmem_cache",
>  };
>
> -#define BAD_ALIEN_MAGIC 0x01020304ul
> -
>  static DEFINE_PER_CPU(struct delayed_work, slab_reap_work);
>
>  static inline struct array_cache *cpu_cache_get(struct kmem_cache *cachep)
> @@ -838,7 +836,7 @@ static int transfer_objects(struct array_cache *to,
>  static inline struct alien_cache **alloc_alien_cache(int node,
>                                                 int limit, gfp_t gfp)
>  {
> -       return (struct alien_cache **)BAD_ALIEN_MAGIC;
> +       return NULL;
>  }

With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:

enable_cpucache failed for radix_tree_node, error 12.
kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
*** TRAP #7 ***   FORMAT=0
Current process id is 0
BAD KERNEL TRAP: 00000000
Modules linked in:
PC: [<0039c92c>] kmem_cache_init_late+0x70/0x8c
SR: 2200  SP: 00345f90  a2: 0034c2e8
d0: 0000003d    d1: 00000000    d2: 00000000    d3: 003ac942
d4: 00000000    d5: 00000000    a0: 0034f686    a1: 0034f682
Process swapper (pid: 0, task=0034c2e8)
Frame format=0
Stack from 00345fc4:
        002f69ef 002ff7e5 000005f2 000360fa 0017d806 003921d4 00000000 00000000
        00000000 00000000 00000000 00000000 003ac942 00000000 003912d6
Call Trace: [<000360fa>] parse_args+0x0/0x2ca
 [<0017d806>] strlen+0x0/0x1a
 [<003921d4>] start_kernel+0x23c/0x428
 [<003912d6>] _sinittext+0x2d6/0x95e

Code: f7e5 4879 002f 69ef 61ff ffca 462a 4e47 <4879> 0035 4b1c 61ff
fff0 0cc4 7005 23c0 0037 fd20 588f 265f 285f 4e75 48e7 301c
Disabling lock debugging due to kernel taint
Kernel panic - not syncing: Attempted to kill the idle task!
---[ end Kernel panic - not syncing: Attempted to kill the idle task!

I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Date:   Wed Aug 6 16:04:38 2014 -0700

    slab: remove BAD_ALIEN_MAGIC

    BAD_ALIEN_MAGIC value isn't used anymore. So remove it.

    Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Acked-by: Christoph Lameter <cl@linux.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: David Rientjes <rientjes@google.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Error 12 is ENOMEM, so I first thought it went out-of-memory, but just reverting
the above commit on mainline makes it work again.

I don't see the failure on ARM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-07 11:52 ` Geert Uytterhoeven
@ 2014-08-07 12:36   ` Joonsoo Kim
  -1 siblings, 0 replies; 16+ messages in thread
From: Joonsoo Kim @ 2014-08-07 12:36 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Joonsoo Kim, Andrew Morton, Christoph Lameter, Pekka Enberg,
	David Rientjes, Linux MM, linux-kernel, Vladimir Davydov

2014-08-07 20:52 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> Hi Joonsoo,
>
> On Tue, Jul 1, 2014 at 10:27 AM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
>> BAD_ALIEN_MAGIC value isn't used anymore. So remove it.
>>
>> Acked-by: Christoph Lameter <cl@linux.com>
>> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> ---
>>  mm/slab.c |    4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/mm/slab.c b/mm/slab.c
>> index 7820a45..60c9e11 100644
>> --- a/mm/slab.c
>> +++ b/mm/slab.c
>> @@ -470,8 +470,6 @@ static struct kmem_cache kmem_cache_boot = {
>>         .name = "kmem_cache",
>>  };
>>
>> -#define BAD_ALIEN_MAGIC 0x01020304ul
>> -
>>  static DEFINE_PER_CPU(struct delayed_work, slab_reap_work);
>>
>>  static inline struct array_cache *cpu_cache_get(struct kmem_cache *cachep)
>> @@ -838,7 +836,7 @@ static int transfer_objects(struct array_cache *to,
>>  static inline struct alien_cache **alloc_alien_cache(int node,
>>                                                 int limit, gfp_t gfp)
>>  {
>> -       return (struct alien_cache **)BAD_ALIEN_MAGIC;
>> +       return NULL;
>>  }
>
> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
>
> enable_cpucache failed for radix_tree_node, error 12.
> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
> *** TRAP #7 ***   FORMAT=0
> Current process id is 0
> BAD KERNEL TRAP: 00000000
> Modules linked in:
> PC: [<0039c92c>] kmem_cache_init_late+0x70/0x8c
> SR: 2200  SP: 00345f90  a2: 0034c2e8
> d0: 0000003d    d1: 00000000    d2: 00000000    d3: 003ac942
> d4: 00000000    d5: 00000000    a0: 0034f686    a1: 0034f682
> Process swapper (pid: 0, task=0034c2e8)
> Frame format=0
> Stack from 00345fc4:
>         002f69ef 002ff7e5 000005f2 000360fa 0017d806 003921d4 00000000 00000000
>         00000000 00000000 00000000 00000000 003ac942 00000000 003912d6
> Call Trace: [<000360fa>] parse_args+0x0/0x2ca
>  [<0017d806>] strlen+0x0/0x1a
>  [<003921d4>] start_kernel+0x23c/0x428
>  [<003912d6>] _sinittext+0x2d6/0x95e
>
> Code: f7e5 4879 002f 69ef 61ff ffca 462a 4e47 <4879> 0035 4b1c 61ff
> fff0 0cc4 7005 23c0 0037 fd20 588f 265f 285f 4e75 48e7 301c
> Disabling lock debugging due to kernel taint
> Kernel panic - not syncing: Attempted to kill the idle task!
> ---[ end Kernel panic - not syncing: Attempted to kill the idle task!
>
> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Date:   Wed Aug 6 16:04:38 2014 -0700
>
>     slab: remove BAD_ALIEN_MAGIC
>
>     BAD_ALIEN_MAGIC value isn't used anymore. So remove it.
>
>     Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>     Acked-by: Christoph Lameter <cl@linux.com>
>     Cc: Pekka Enberg <penberg@kernel.org>
>     Cc: David Rientjes <rientjes@google.com>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> Error 12 is ENOMEM, so I first thought it went out-of-memory, but just reverting
> the above commit on mainline makes it work again.

Hello,

Thanks for reporting.

This patch only works for !NUMA. And if num_possible_nodes() is 1,
then it doesn't have any effect, because alloc_alien_cache() call is always
skipped. Is it possible !NUMA and num_possible_nodes() != 1?

Could you check your config for CONFIG_NUMA and
CONFIG_NODES_SHIFT?

And, could you check booting with boot param "noaliencache"?

Thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-07 12:36   ` Joonsoo Kim
  0 siblings, 0 replies; 16+ messages in thread
From: Joonsoo Kim @ 2014-08-07 12:36 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Joonsoo Kim, Andrew Morton, Christoph Lameter, Pekka Enberg,
	David Rientjes, Linux MM, linux-kernel, Vladimir Davydov

2014-08-07 20:52 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> Hi Joonsoo,
>
> On Tue, Jul 1, 2014 at 10:27 AM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
>> BAD_ALIEN_MAGIC value isn't used anymore. So remove it.
>>
>> Acked-by: Christoph Lameter <cl@linux.com>
>> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> ---
>>  mm/slab.c |    4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/mm/slab.c b/mm/slab.c
>> index 7820a45..60c9e11 100644
>> --- a/mm/slab.c
>> +++ b/mm/slab.c
>> @@ -470,8 +470,6 @@ static struct kmem_cache kmem_cache_boot = {
>>         .name = "kmem_cache",
>>  };
>>
>> -#define BAD_ALIEN_MAGIC 0x01020304ul
>> -
>>  static DEFINE_PER_CPU(struct delayed_work, slab_reap_work);
>>
>>  static inline struct array_cache *cpu_cache_get(struct kmem_cache *cachep)
>> @@ -838,7 +836,7 @@ static int transfer_objects(struct array_cache *to,
>>  static inline struct alien_cache **alloc_alien_cache(int node,
>>                                                 int limit, gfp_t gfp)
>>  {
>> -       return (struct alien_cache **)BAD_ALIEN_MAGIC;
>> +       return NULL;
>>  }
>
> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
>
> enable_cpucache failed for radix_tree_node, error 12.
> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
> *** TRAP #7 ***   FORMAT=0
> Current process id is 0
> BAD KERNEL TRAP: 00000000
> Modules linked in:
> PC: [<0039c92c>] kmem_cache_init_late+0x70/0x8c
> SR: 2200  SP: 00345f90  a2: 0034c2e8
> d0: 0000003d    d1: 00000000    d2: 00000000    d3: 003ac942
> d4: 00000000    d5: 00000000    a0: 0034f686    a1: 0034f682
> Process swapper (pid: 0, task=0034c2e8)
> Frame format=0
> Stack from 00345fc4:
>         002f69ef 002ff7e5 000005f2 000360fa 0017d806 003921d4 00000000 00000000
>         00000000 00000000 00000000 00000000 003ac942 00000000 003912d6
> Call Trace: [<000360fa>] parse_args+0x0/0x2ca
>  [<0017d806>] strlen+0x0/0x1a
>  [<003921d4>] start_kernel+0x23c/0x428
>  [<003912d6>] _sinittext+0x2d6/0x95e
>
> Code: f7e5 4879 002f 69ef 61ff ffca 462a 4e47 <4879> 0035 4b1c 61ff
> fff0 0cc4 7005 23c0 0037 fd20 588f 265f 285f 4e75 48e7 301c
> Disabling lock debugging due to kernel taint
> Kernel panic - not syncing: Attempted to kill the idle task!
> ---[ end Kernel panic - not syncing: Attempted to kill the idle task!
>
> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Date:   Wed Aug 6 16:04:38 2014 -0700
>
>     slab: remove BAD_ALIEN_MAGIC
>
>     BAD_ALIEN_MAGIC value isn't used anymore. So remove it.
>
>     Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>     Acked-by: Christoph Lameter <cl@linux.com>
>     Cc: Pekka Enberg <penberg@kernel.org>
>     Cc: David Rientjes <rientjes@google.com>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> Error 12 is ENOMEM, so I first thought it went out-of-memory, but just reverting
> the above commit on mainline makes it work again.

Hello,

Thanks for reporting.

This patch only works for !NUMA. And if num_possible_nodes() is 1,
then it doesn't have any effect, because alloc_alien_cache() call is always
skipped. Is it possible !NUMA and num_possible_nodes() != 1?

Could you check your config for CONFIG_NUMA and
CONFIG_NODES_SHIFT?

And, could you check booting with boot param "noaliencache"?

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-07 12:36   ` Joonsoo Kim
@ 2014-08-07 12:53     ` Geert Uytterhoeven
  -1 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-08-07 12:53 UTC (permalink / raw)
  To: Joonsoo Kim
  Cc: Joonsoo Kim, Andrew Morton, Christoph Lameter, Pekka Enberg,
	David Rientjes, Linux MM, linux-kernel, Vladimir Davydov

Hi,

On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim <js1304@gmail.com> wrote:
>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
>>
>> enable_cpucache failed for radix_tree_node, error 12.
>> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!

>> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
>> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> Date:   Wed Aug 6 16:04:38 2014 -0700
>>
>>     slab: remove BAD_ALIEN_MAGIC

> This patch only works for !NUMA. And if num_possible_nodes() is 1,
> then it doesn't have any effect, because alloc_alien_cache() call is always
> skipped. Is it possible !NUMA and num_possible_nodes() != 1?
>
> Could you check your config for CONFIG_NUMA and
> CONFIG_NODES_SHIFT?

$ grep CONFIG_NUMA .config
$ grep CONFIG_NODES_SHIFT .config
CONFIG_NODES_SHIFT=3
$

There are indeed multiple nodes:

On node 0 totalpages: 3584
free_area_init_node: node 0, pgdat 003659a4, node_mem_map 00402000
  DMA zone: 32 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 3584 pages, LIFO batch:0
On node 1 totalpages: 65536
free_area_init_node: node 1, pgdat 00366294, node_mem_map 00426090
  DMA zone: 576 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 65536 pages, LIFO batch:15

> And, could you check booting with boot param "noaliencache"?

That fixes the boot, too.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-07 12:53     ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-08-07 12:53 UTC (permalink / raw)
  To: Joonsoo Kim
  Cc: Joonsoo Kim, Andrew Morton, Christoph Lameter, Pekka Enberg,
	David Rientjes, Linux MM, linux-kernel, Vladimir Davydov

Hi,

On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim <js1304@gmail.com> wrote:
>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
>>
>> enable_cpucache failed for radix_tree_node, error 12.
>> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!

>> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
>> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>> Date:   Wed Aug 6 16:04:38 2014 -0700
>>
>>     slab: remove BAD_ALIEN_MAGIC

> This patch only works for !NUMA. And if num_possible_nodes() is 1,
> then it doesn't have any effect, because alloc_alien_cache() call is always
> skipped. Is it possible !NUMA and num_possible_nodes() != 1?
>
> Could you check your config for CONFIG_NUMA and
> CONFIG_NODES_SHIFT?

$ grep CONFIG_NUMA .config
$ grep CONFIG_NODES_SHIFT .config
CONFIG_NODES_SHIFT=3
$

There are indeed multiple nodes:

On node 0 totalpages: 3584
free_area_init_node: node 0, pgdat 003659a4, node_mem_map 00402000
  DMA zone: 32 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 3584 pages, LIFO batch:0
On node 1 totalpages: 65536
free_area_init_node: node 1, pgdat 00366294, node_mem_map 00426090
  DMA zone: 576 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 65536 pages, LIFO batch:15

> And, could you check booting with boot param "noaliencache"?

That fixes the boot, too.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-07 12:53     ` Geert Uytterhoeven
@ 2014-08-07 13:03       ` Joonsoo Kim
  -1 siblings, 0 replies; 16+ messages in thread
From: Joonsoo Kim @ 2014-08-07 13:03 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Joonsoo Kim, Andrew Morton, Christoph Lameter, Pekka Enberg,
	David Rientjes, Linux MM, linux-kernel, Vladimir Davydov

2014-08-07 21:53 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> Hi,
>
> On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim <js1304@gmail.com> wrote:
>>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
>>>
>>> enable_cpucache failed for radix_tree_node, error 12.
>>> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
>
>>> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
>>> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>>> Date:   Wed Aug 6 16:04:38 2014 -0700
>>>
>>>     slab: remove BAD_ALIEN_MAGIC
>
>> This patch only works for !NUMA. And if num_possible_nodes() is 1,
>> then it doesn't have any effect, because alloc_alien_cache() call is always
>> skipped. Is it possible !NUMA and num_possible_nodes() != 1?
>>
>> Could you check your config for CONFIG_NUMA and
>> CONFIG_NODES_SHIFT?
>
> $ grep CONFIG_NUMA .config
> $ grep CONFIG_NODES_SHIFT .config
> CONFIG_NODES_SHIFT=3
> $
>
> There are indeed multiple nodes:
>
> On node 0 totalpages: 3584
> free_area_init_node: node 0, pgdat 003659a4, node_mem_map 00402000
>   DMA zone: 32 pages used for memmap
>   DMA zone: 0 pages reserved
>   DMA zone: 3584 pages, LIFO batch:0
> On node 1 totalpages: 65536
> free_area_init_node: node 1, pgdat 00366294, node_mem_map 00426090
>   DMA zone: 576 pages used for memmap
>   DMA zone: 0 pages reserved
>   DMA zone: 65536 pages, LIFO batch:15
>
>> And, could you check booting with boot param "noaliencache"?
>
> That fixes the boot, too.

Ah... I don't know it can be possible to be !CONFIG_NUMA and
CONFIG_NODES_SHIFT > 0 until now. If so, I should revert this patch.

After some more investigation, I will revert this patch tomorrow and
notify you.

Thanks for reporting!!! :)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-07 13:03       ` Joonsoo Kim
  0 siblings, 0 replies; 16+ messages in thread
From: Joonsoo Kim @ 2014-08-07 13:03 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Joonsoo Kim, Andrew Morton, Christoph Lameter, Pekka Enberg,
	David Rientjes, Linux MM, linux-kernel, Vladimir Davydov

2014-08-07 21:53 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> Hi,
>
> On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim <js1304@gmail.com> wrote:
>>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
>>>
>>> enable_cpucache failed for radix_tree_node, error 12.
>>> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
>
>>> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
>>> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>>> Date:   Wed Aug 6 16:04:38 2014 -0700
>>>
>>>     slab: remove BAD_ALIEN_MAGIC
>
>> This patch only works for !NUMA. And if num_possible_nodes() is 1,
>> then it doesn't have any effect, because alloc_alien_cache() call is always
>> skipped. Is it possible !NUMA and num_possible_nodes() != 1?
>>
>> Could you check your config for CONFIG_NUMA and
>> CONFIG_NODES_SHIFT?
>
> $ grep CONFIG_NUMA .config
> $ grep CONFIG_NODES_SHIFT .config
> CONFIG_NODES_SHIFT=3
> $
>
> There are indeed multiple nodes:
>
> On node 0 totalpages: 3584
> free_area_init_node: node 0, pgdat 003659a4, node_mem_map 00402000
>   DMA zone: 32 pages used for memmap
>   DMA zone: 0 pages reserved
>   DMA zone: 3584 pages, LIFO batch:0
> On node 1 totalpages: 65536
> free_area_init_node: node 1, pgdat 00366294, node_mem_map 00426090
>   DMA zone: 576 pages used for memmap
>   DMA zone: 0 pages reserved
>   DMA zone: 65536 pages, LIFO batch:15
>
>> And, could you check booting with boot param "noaliencache"?
>
> That fixes the boot, too.

Ah... I don't know it can be possible to be !CONFIG_NUMA and
CONFIG_NODES_SHIFT > 0 until now. If so, I should revert this patch.

After some more investigation, I will revert this patch tomorrow and
notify you.

Thanks for reporting!!! :)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-07 13:03       ` Joonsoo Kim
@ 2014-08-08  7:19         ` Joonsoo Kim
  -1 siblings, 0 replies; 16+ messages in thread
From: Joonsoo Kim @ 2014-08-08  7:19 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

On Thu, Aug 07, 2014 at 10:03:09PM +0900, Joonsoo Kim wrote:
> 2014-08-07 21:53 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> > Hi,
> >
> > On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim <js1304@gmail.com> wrote:
> >>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
> >>>
> >>> enable_cpucache failed for radix_tree_node, error 12.
> >>> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
> >
> >>> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
> >>> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >>> Date:   Wed Aug 6 16:04:38 2014 -0700
> >>>
> >>>     slab: remove BAD_ALIEN_MAGIC
> >
> >> This patch only works for !NUMA. And if num_possible_nodes() is 1,
> >> then it doesn't have any effect, because alloc_alien_cache() call is always
> >> skipped. Is it possible !NUMA and num_possible_nodes() != 1?
> >>
> >> Could you check your config for CONFIG_NUMA and
> >> CONFIG_NODES_SHIFT?
> >
> > $ grep CONFIG_NUMA .config
> > $ grep CONFIG_NODES_SHIFT .config
> > CONFIG_NODES_SHIFT=3
> > $
> >
> > There are indeed multiple nodes:
> >
> > On node 0 totalpages: 3584
> > free_area_init_node: node 0, pgdat 003659a4, node_mem_map 00402000
> >   DMA zone: 32 pages used for memmap
> >   DMA zone: 0 pages reserved
> >   DMA zone: 3584 pages, LIFO batch:0
> > On node 1 totalpages: 65536
> > free_area_init_node: node 1, pgdat 00366294, node_mem_map 00426090
> >   DMA zone: 576 pages used for memmap
> >   DMA zone: 0 pages reserved
> >   DMA zone: 65536 pages, LIFO batch:15
> >
> >> And, could you check booting with boot param "noaliencache"?
> >
> > That fixes the boot, too.
> 
> Ah... I don't know it can be possible to be !CONFIG_NUMA and
> CONFIG_NODES_SHIFT > 0 until now. If so, I should revert this patch.
> 
> After some more investigation, I will revert this patch tomorrow and
> notify you.
> 
> Thanks for reporting!!! :)

Hello,

Just for curiosity.

Could you show me your full dmesg on boot-up?
What I want to know is nodes-cpus mapping.

I looked at SLAB code and found that SLAB works fine only if
numa_mem_id() always returns 0. I guess that this is the case for
!CONFIG_NUMA, so your system would work fine.

And, I looked at SLUB code and found that SLUB works fine only if
page_to_nid(page) always return 0 for this !CONFIG_NUMA and many nodes
case. If not, some memory could be leak, I guess. 

If possible, could you check whether page_to_nid(page) returns
only 0 or not?

Thanks.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-08  7:19         ` Joonsoo Kim
  0 siblings, 0 replies; 16+ messages in thread
From: Joonsoo Kim @ 2014-08-08  7:19 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

On Thu, Aug 07, 2014 at 10:03:09PM +0900, Joonsoo Kim wrote:
> 2014-08-07 21:53 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>:
> > Hi,
> >
> > On Thu, Aug 7, 2014 at 2:36 PM, Joonsoo Kim <js1304@gmail.com> wrote:
> >>> With latest mainline, I'm getting a crash during bootup on m68k/ARAnyM:
> >>>
> >>> enable_cpucache failed for radix_tree_node, error 12.
> >>> kernel BUG at /scratch/geert/linux/linux-m68k/mm/slab.c:1522!
> >
> >>> I bisected it to commit a640616822b2c3a8009b0600f20c4a76ea8a0025
> >>> Author: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >>> Date:   Wed Aug 6 16:04:38 2014 -0700
> >>>
> >>>     slab: remove BAD_ALIEN_MAGIC
> >
> >> This patch only works for !NUMA. And if num_possible_nodes() is 1,
> >> then it doesn't have any effect, because alloc_alien_cache() call is always
> >> skipped. Is it possible !NUMA and num_possible_nodes() != 1?
> >>
> >> Could you check your config for CONFIG_NUMA and
> >> CONFIG_NODES_SHIFT?
> >
> > $ grep CONFIG_NUMA .config
> > $ grep CONFIG_NODES_SHIFT .config
> > CONFIG_NODES_SHIFT=3
> > $
> >
> > There are indeed multiple nodes:
> >
> > On node 0 totalpages: 3584
> > free_area_init_node: node 0, pgdat 003659a4, node_mem_map 00402000
> >   DMA zone: 32 pages used for memmap
> >   DMA zone: 0 pages reserved
> >   DMA zone: 3584 pages, LIFO batch:0
> > On node 1 totalpages: 65536
> > free_area_init_node: node 1, pgdat 00366294, node_mem_map 00426090
> >   DMA zone: 576 pages used for memmap
> >   DMA zone: 0 pages reserved
> >   DMA zone: 65536 pages, LIFO batch:15
> >
> >> And, could you check booting with boot param "noaliencache"?
> >
> > That fixes the boot, too.
> 
> Ah... I don't know it can be possible to be !CONFIG_NUMA and
> CONFIG_NODES_SHIFT > 0 until now. If so, I should revert this patch.
> 
> After some more investigation, I will revert this patch tomorrow and
> notify you.
> 
> Thanks for reporting!!! :)

Hello,

Just for curiosity.

Could you show me your full dmesg on boot-up?
What I want to know is nodes-cpus mapping.

I looked at SLAB code and found that SLAB works fine only if
numa_mem_id() always returns 0. I guess that this is the case for
!CONFIG_NUMA, so your system would work fine.

And, I looked at SLUB code and found that SLUB works fine only if
page_to_nid(page) always return 0 for this !CONFIG_NUMA and many nodes
case. If not, some memory could be leak, I guess. 

If possible, could you check whether page_to_nid(page) returns
only 0 or not?

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-08  7:19         ` Joonsoo Kim
  (?)
@ 2014-08-08  8:56         ` Geert Uytterhoeven
  2014-08-08 11:50           ` Christoph Lameter
  -1 siblings, 1 reply; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-08-08  8:56 UTC (permalink / raw)
  To: Joonsoo Kim
  Cc: Andrew Morton, Christoph Lameter, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

Hi Joonsoo,

On Fri, Aug 8, 2014 at 9:19 AM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> Could you show me your full dmesg on boot-up?
> What I want to know is nodes-cpus mapping.

Attached.

If you want more debug output, please ask.

> I looked at SLAB code and found that SLAB works fine only if
> numa_mem_id() always returns 0. I guess that this is the case for
> !CONFIG_NUMA, so your system would work fine.
>
> And, I looked at SLUB code and found that SLUB works fine only if
> page_to_nid(page) always return 0 for this !CONFIG_NUMA and many nodes
> case. If not, some memory could be leak, I guess.

I've just tried SLUB, it boots fine. That doesn't say there are no leaks,
though.

> Of possible, could you check whether page_to_nid(page) returns
> only 0 or not?

It returns 0 or 1.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[-- Attachment #2: dmesg --]
[-- Type: application/octet-stream, Size: 5535 bytes --]

Linux version 3.16.0-atari-09694-geaf4843385e3 (geert@ramsan) (gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)) #53 Fri Aug 8 09:44:14 CEST 2014
Saving 154 bytes of bootinfo
console [debug0] enabled
Atari hardware found: VIDEL STDMA-SCSI ST_MFP YM2149 PCM CODEC DSP56K SCC ANALOG_JOY BLITTER IDE TT_CLK FDC_SPEED 
*** m68k_memoffset = 0x00000000
*** m68k_virt_to_node_shift = 23
m68k_setup_node: node = 0 (start 0x00000000 size 0x00e00000)
    i = 0, end = 1
m68k_setup_node: node = 1 (start 0x01000000 size 0x10000000)
    i = 2, end = 33
On node 0 totalpages: 3584
free_area_init_node: node 0, pgdat 0036dac4, node_mem_map 0040b000
  DMA zone: 32 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 3584 pages, LIFO batch:0
On node 1 totalpages: 65536
free_area_init_node: node 1, pgdat 0036e3b4, node_mem_map 0042f090
  DMA zone: 576 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 65536 pages, LIFO batch:15
NatFeats found (ARAnyM, 1.0)
pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768
pcpu-alloc: [0] 0 
Built 2 zonelists in Zone order, mobility grouping on.  Total pages: 68512
Kernel command line: root=/dev/hda1 video=atafb:tthigh debug=par console=tty0 BOOT_IMAGE=vmlinux
PID hash table entries: 2048 (order: 1, 8192 bytes)
Dentry cache hash table entries: 65536 (order: 6, 262144 bytes)
Inode-cache hash table entries: 32768 (order: 5, 131072 bytes)
Sorting __ex_table...
Memory: 268440K/276480K available (2710K kernel code, 307K rwdata, 644K rodata, 148K init, 168K bss, 8040K reserved)
Virtual kernel memory layout:
    vector  : 0x0036d5b4 - 0x0036d9b4   (   1 KiB)
    kmap    : 0xd0000000 - 0xf0000000   ( 512 MiB)
    vmalloc : 0x11800000 - 0xd0000000   (3048 MiB)
    lowmem  : 0x00000000 - 0x11000000   ( 272 MiB)
      .init : 0x00398000 - 0x003bd000   ( 148 KiB)
      .text : 0x00001000 - 0x002a691c   (2711 KiB)
      .data : 0x002a9600 - 0x0039750c   ( 952 KiB)
      .bss  : 0x0036d4c0 - 0x0039750c   ( 169 KiB)
NR_IRQS:141
Console: colour dummy device 80x25
console [tty0] enabled
Calibrating delay loop... 188.82 BogoMIPS (lpj=944128)
pid_max: default: 32768 minimum: 301
Mount-cache hash table entries: 1024 (order: 0, 4096 bytes)
Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes)
devtmpfs: initialized
NET: Registered protocol family 16
SCSI subsystem initialized
NET: Registered protocol family 2
TCP established hash table entries: 4096 (order: 2, 16384 bytes)
TCP bind hash table entries: 4096 (order: 2, 16384 bytes)
TCP: Hash tables configured (established 4096 bind 4096)
TCP: reno registered
UDP hash table entries: 256 (order: 0, 4096 bytes)
UDP-Lite hash table entries: 256 (order: 0, 4096 bytes)
NET: Registered protocol family 1
RPC: Registered named UNIX socket transport module.
RPC: Registered udp transport module.
RPC: Registered tcp transport module.
RPC: Registered tcp NFSv4.1 backchannel transport module.
nfhd8: found device with 2118816 blocks (512 bytes)
 nfhd8: AHDI p1 p2
nfeth: API 5
eth0: nfeth addr:192.168.0.1 (192.168.0.2) HWaddr:00:41:45:54:48:30
futex hash table entries: 256 (order: -1, 3072 bytes)
VFS: Disk quotas dquot_6.5.2
Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
msgmni has been set to 524
Block layer SCSI generic (bsg) driver version 0.4 loaded (major 252)
io scheduler noop registered
io scheduler cfq registered (default)
atafb_init: start
atafb_init: initializing Falcon hw
atafb: screen_base 00670000 phys_screen_base 670000 screen_len 311296
Determined 640x480, depth 4
   virtual 640x972
Console: switching to colour frame buffer device 80x30
fb0: frame buffer device, using 304K of video memory
Non-volatile memory driver v1.3
Atari floppy driver: max. HD, track buffering
Probing floppy drive(s):
fd0
brd: module loaded
loop: module loaded
Uniform Multi-Platform E-IDE driver
ide: Falcon IDE controller
Probing IDE interface ide0...
hda: Sarge m68k, ATA DISK drive
ide0 at 0xfff00000 on irq 15 (serialized)
ide-gd driver 1.18
hda: max request size: 128KiB
hda: 2118816 sectors (1084 MB) w/256KiB Cache, CHS=2102/16/63
 hda: AHDI hda1 hda2
ide-cd driver 5.00
scsi0: options CAN_QUEUE=8 CMD_PER_LUN=1 SCAT-GAT=0 TAGGED-QUEUING=no HOSTID=7 generic options AUTOSENSE REAL DMA SCSI-2 TAGGED QUEUING generic release=7
scsi host0: Atari native SCSI
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
ne ne (unnamed net_device) (uninitialized): NE*000 ethercard probe at 0x300:
 not found (no reset ack).
ne ne (unnamed net_device) (uninitialized): ne.c: No NE*000 card found at i/o = 0x300
mousedev: PS/2 mouse device common for all mice
input: Atari Keyboard as /devices/virtual/input/input0
TCP: cubic registered
NET: Registered protocol family 17
NET: Registered protocol family 15
Key type dns_resolver registered
/scratch/geert/linux/linux-m68k/drivers/rtc/hctosys.c: unable to open rtc device (rtc0)
EXT4-fs (hda1): mounting ext3 file system using the ext4 subsystem
EXT4-fs (hda1): mounted filesystem with ordered data mode. Opts: (null)
VFS: Mounted root (ext3 filesystem) readonly on device 3:1.
Freeing unused kernel memory: 148K (00398000 - 003bd000)
random: nonblocking pool is initialized
Adding 137800k swap on /dev/hda2.  Priority:-1 extents:1 across:137800k 
EXT4-fs (hda1): re-mounted. Opts: 
EXT4-fs (hda1): re-mounted. Opts: errors=remount-ro

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-08  8:56         ` Geert Uytterhoeven
@ 2014-08-08 11:50           ` Christoph Lameter
  2014-08-08 12:06               ` Geert Uytterhoeven
  0 siblings, 1 reply; 16+ messages in thread
From: Christoph Lameter @ 2014-08-08 11:50 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Joonsoo Kim, Andrew Morton, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

[-- Attachment #1: Type: TEXT/PLAIN, Size: 310 bytes --]

On Fri, 8 Aug 2014, Geert Uytterhoeven wrote:

>
> > Of possible, could you check whether page_to_nid(page) returns
> > only 0 or not?
>
> It returns 0 or 1.

Ok this is broken on m68k. CONFIG_NUMA is required for this to work. If
the arch code does this despite !CONFIG_NUMA then lots of things should
break.

[-- Attachment #2: Type: APPLICATION/OCTET-STREAM, Size: 5535 bytes --]

Linux version 3.16.0-atari-09694-geaf4843385e3 (geert@ramsan) (gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)) #53 Fri Aug 8 09:44:14 CEST 2014
Saving 154 bytes of bootinfo
console [debug0] enabled
Atari hardware found: VIDEL STDMA-SCSI ST_MFP YM2149 PCM CODEC DSP56K SCC ANALOG_JOY BLITTER IDE TT_CLK FDC_SPEED 
*** m68k_memoffset = 0x00000000
*** m68k_virt_to_node_shift = 23
m68k_setup_node: node = 0 (start 0x00000000 size 0x00e00000)
    i = 0, end = 1
m68k_setup_node: node = 1 (start 0x01000000 size 0x10000000)
    i = 2, end = 33
On node 0 totalpages: 3584
free_area_init_node: node 0, pgdat 0036dac4, node_mem_map 0040b000
  DMA zone: 32 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 3584 pages, LIFO batch:0
On node 1 totalpages: 65536
free_area_init_node: node 1, pgdat 0036e3b4, node_mem_map 0042f090
  DMA zone: 576 pages used for memmap
  DMA zone: 0 pages reserved
  DMA zone: 65536 pages, LIFO batch:15
NatFeats found (ARAnyM, 1.0)
pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768
pcpu-alloc: [0] 0 
Built 2 zonelists in Zone order, mobility grouping on.  Total pages: 68512
Kernel command line: root=/dev/hda1 video=atafb:tthigh debug=par console=tty0 BOOT_IMAGE=vmlinux
PID hash table entries: 2048 (order: 1, 8192 bytes)
Dentry cache hash table entries: 65536 (order: 6, 262144 bytes)
Inode-cache hash table entries: 32768 (order: 5, 131072 bytes)
Sorting __ex_table...
Memory: 268440K/276480K available (2710K kernel code, 307K rwdata, 644K rodata, 148K init, 168K bss, 8040K reserved)
Virtual kernel memory layout:
    vector  : 0x0036d5b4 - 0x0036d9b4   (   1 KiB)
    kmap    : 0xd0000000 - 0xf0000000   ( 512 MiB)
    vmalloc : 0x11800000 - 0xd0000000   (3048 MiB)
    lowmem  : 0x00000000 - 0x11000000   ( 272 MiB)
      .init : 0x00398000 - 0x003bd000   ( 148 KiB)
      .text : 0x00001000 - 0x002a691c   (2711 KiB)
      .data : 0x002a9600 - 0x0039750c   ( 952 KiB)
      .bss  : 0x0036d4c0 - 0x0039750c   ( 169 KiB)
NR_IRQS:141
Console: colour dummy device 80x25
console [tty0] enabled
Calibrating delay loop... 188.82 BogoMIPS (lpj=944128)
pid_max: default: 32768 minimum: 301
Mount-cache hash table entries: 1024 (order: 0, 4096 bytes)
Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes)
devtmpfs: initialized
NET: Registered protocol family 16
SCSI subsystem initialized
NET: Registered protocol family 2
TCP established hash table entries: 4096 (order: 2, 16384 bytes)
TCP bind hash table entries: 4096 (order: 2, 16384 bytes)
TCP: Hash tables configured (established 4096 bind 4096)
TCP: reno registered
UDP hash table entries: 256 (order: 0, 4096 bytes)
UDP-Lite hash table entries: 256 (order: 0, 4096 bytes)
NET: Registered protocol family 1
RPC: Registered named UNIX socket transport module.
RPC: Registered udp transport module.
RPC: Registered tcp transport module.
RPC: Registered tcp NFSv4.1 backchannel transport module.
nfhd8: found device with 2118816 blocks (512 bytes)
 nfhd8: AHDI p1 p2
nfeth: API 5
eth0: nfeth addr:192.168.0.1 (192.168.0.2) HWaddr:00:41:45:54:48:30
futex hash table entries: 256 (order: -1, 3072 bytes)
VFS: Disk quotas dquot_6.5.2
Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
msgmni has been set to 524
Block layer SCSI generic (bsg) driver version 0.4 loaded (major 252)
io scheduler noop registered
io scheduler cfq registered (default)
atafb_init: start
atafb_init: initializing Falcon hw
atafb: screen_base 00670000 phys_screen_base 670000 screen_len 311296
Determined 640x480, depth 4
   virtual 640x972
Console: switching to colour frame buffer device 80x30
fb0: frame buffer device, using 304K of video memory
Non-volatile memory driver v1.3
Atari floppy driver: max. HD, track buffering
Probing floppy drive(s):
fd0
brd: module loaded
loop: module loaded
Uniform Multi-Platform E-IDE driver
ide: Falcon IDE controller
Probing IDE interface ide0...
hda: Sarge m68k, ATA DISK drive
ide0 at 0xfff00000 on irq 15 (serialized)
ide-gd driver 1.18
hda: max request size: 128KiB
hda: 2118816 sectors (1084 MB) w/256KiB Cache, CHS=2102/16/63
 hda: AHDI hda1 hda2
ide-cd driver 5.00
scsi0: options CAN_QUEUE=8 CMD_PER_LUN=1 SCAT-GAT=0 TAGGED-QUEUING=no HOSTID=7 generic options AUTOSENSE REAL DMA SCSI-2 TAGGED QUEUING generic release=7
scsi host0: Atari native SCSI
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
blk_queue_max_segments: set to minimum 1
ne ne (unnamed net_device) (uninitialized): NE*000 ethercard probe at 0x300:
 not found (no reset ack).
ne ne (unnamed net_device) (uninitialized): ne.c: No NE*000 card found at i/o = 0x300
mousedev: PS/2 mouse device common for all mice
input: Atari Keyboard as /devices/virtual/input/input0
TCP: cubic registered
NET: Registered protocol family 17
NET: Registered protocol family 15
Key type dns_resolver registered
/scratch/geert/linux/linux-m68k/drivers/rtc/hctosys.c: unable to open rtc device (rtc0)
EXT4-fs (hda1): mounting ext3 file system using the ext4 subsystem
EXT4-fs (hda1): mounted filesystem with ordered data mode. Opts: (null)
VFS: Mounted root (ext3 filesystem) readonly on device 3:1.
Freeing unused kernel memory: 148K (00398000 - 003bd000)
random: nonblocking pool is initialized
Adding 137800k swap on /dev/hda2.  Priority:-1 extents:1 across:137800k 
EXT4-fs (hda1): re-mounted. Opts: 
EXT4-fs (hda1): re-mounted. Opts: errors=remount-ro

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-08 11:50           ` Christoph Lameter
@ 2014-08-08 12:06               ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-08-08 12:06 UTC (permalink / raw)
  To: Christoph Lameter
  Cc: Joonsoo Kim, Andrew Morton, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

Hi Christoph,

On Fri, Aug 8, 2014 at 1:50 PM, Christoph Lameter <cl@linux.com> wrote:
> On Fri, 8 Aug 2014, Geert Uytterhoeven wrote:
>> > Of possible, could you check whether page_to_nid(page) returns
>> > only 0 or not?
>>
>> It returns 0 or 1.
>
> Ok this is broken on m68k. CONFIG_NUMA is required for this to work. If
> the arch code does this despite !CONFIG_NUMA then lots of things should
> break.

Can you please elaborate? We've been using for years...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-08 12:06               ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-08-08 12:06 UTC (permalink / raw)
  To: Christoph Lameter
  Cc: Joonsoo Kim, Andrew Morton, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

Hi Christoph,

On Fri, Aug 8, 2014 at 1:50 PM, Christoph Lameter <cl@linux.com> wrote:
> On Fri, 8 Aug 2014, Geert Uytterhoeven wrote:
>> > Of possible, could you check whether page_to_nid(page) returns
>> > only 0 or not?
>>
>> It returns 0 or 1.
>
> Ok this is broken on m68k. CONFIG_NUMA is required for this to work. If
> the arch code does this despite !CONFIG_NUMA then lots of things should
> break.

Can you please elaborate? We've been using for years...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
  2014-08-08 12:06               ` Geert Uytterhoeven
@ 2014-08-08 14:11                 ` Christoph Lameter
  -1 siblings, 0 replies; 16+ messages in thread
From: Christoph Lameter @ 2014-08-08 14:11 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Joonsoo Kim, Andrew Morton, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

On Fri, 8 Aug 2014, Geert Uytterhoeven wrote:

> > Ok this is broken on m68k. CONFIG_NUMA is required for this to work. If
> > the arch code does this despite !CONFIG_NUMA then lots of things should
> > break.
>
> Can you please elaborate? We've been using for years...

!CONFIG_NUMA leads to the assumption of a system with a single node in
numerous places.

F.e. in include/linux/mm.h:


static inline int zone_to_nid(struct zone *zone)
{
#ifdef CONFIG_NUMA
        return zone->node;
#else
        return 0;
#endif
}



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC)
@ 2014-08-08 14:11                 ` Christoph Lameter
  0 siblings, 0 replies; 16+ messages in thread
From: Christoph Lameter @ 2014-08-08 14:11 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Joonsoo Kim, Andrew Morton, Pekka Enberg, David Rientjes,
	Linux MM, linux-kernel, Vladimir Davydov

On Fri, 8 Aug 2014, Geert Uytterhoeven wrote:

> > Ok this is broken on m68k. CONFIG_NUMA is required for this to work. If
> > the arch code does this despite !CONFIG_NUMA then lots of things should
> > break.
>
> Can you please elaborate? We've been using for years...

!CONFIG_NUMA leads to the assumption of a system with a single node in
numerous places.

F.e. in include/linux/mm.h:


static inline int zone_to_nid(struct zone *zone)
{
#ifdef CONFIG_NUMA
        return zone->node;
#else
        return 0;
#endif
}


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2014-08-08 14:11 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-07 11:52 BUG: enable_cpucache failed for radix_tree_node, error 12 (was: Re: [PATCH v3 9/9] slab: remove BAD_ALIEN_MAGIC) Geert Uytterhoeven
2014-08-07 11:52 ` Geert Uytterhoeven
2014-08-07 12:36 ` Joonsoo Kim
2014-08-07 12:36   ` Joonsoo Kim
2014-08-07 12:53   ` Geert Uytterhoeven
2014-08-07 12:53     ` Geert Uytterhoeven
2014-08-07 13:03     ` Joonsoo Kim
2014-08-07 13:03       ` Joonsoo Kim
2014-08-08  7:19       ` Joonsoo Kim
2014-08-08  7:19         ` Joonsoo Kim
2014-08-08  8:56         ` Geert Uytterhoeven
2014-08-08 11:50           ` Christoph Lameter
2014-08-08 12:06             ` Geert Uytterhoeven
2014-08-08 12:06               ` Geert Uytterhoeven
2014-08-08 14:11               ` Christoph Lameter
2014-08-08 14:11                 ` Christoph Lameter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.