* [PATCH] serial: 8250_hp300: trivial: fix symbol name in #warning message
@ 2014-08-08 15:14 Daniele Forsi
2014-08-08 15:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Daniele Forsi @ 2014-08-08 15:14 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Jiri Kosina, linux-serial; +Cc: Daniele Forsi
The symbol is defined in drivers/tty/serial/8250/Kconfig as
"SERIAL_8250", not just "8250".
Signed-off-by: Daniele Forsi <dforsi@gmail.com>
---
drivers/tty/serial/8250/8250_hp300.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_hp300.c b/drivers/tty/serial/8250/8250_hp300.c
index 5bdaf27..f155328 100644
--- a/drivers/tty/serial/8250/8250_hp300.c
+++ b/drivers/tty/serial/8250/8250_hp300.c
@@ -24,6 +24,10 @@
#warning CONFIG_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
#endif
+#if !defined(CONFIG_HPDCA) && !defined(CONFIG_HPAPCI)
+#warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
+#endif
+
#ifdef CONFIG_HPAPCI
struct hp300_port
{
--
2.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: 8250_hp300: trivial: fix symbol name in #warning message
2014-08-08 15:14 [PATCH] serial: 8250_hp300: trivial: fix symbol name in #warning message Daniele Forsi
@ 2014-08-08 15:29 ` Greg Kroah-Hartman
2014-08-08 15:56 ` [PATCH v2] " Daniele Forsi
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-08-08 15:29 UTC (permalink / raw)
To: Daniele Forsi; +Cc: Jiri Slaby, Jiri Kosina, linux-serial
On Fri, Aug 08, 2014 at 05:14:32PM +0200, Daniele Forsi wrote:
> The symbol is defined in drivers/tty/serial/8250/Kconfig as
> "SERIAL_8250", not just "8250".
>
> Signed-off-by: Daniele Forsi <dforsi@gmail.com>
> ---
> drivers/tty/serial/8250/8250_hp300.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_hp300.c b/drivers/tty/serial/8250/8250_hp300.c
> index 5bdaf27..f155328 100644
> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
> @@ -24,6 +24,10 @@
> #warning CONFIG_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
> #endif
>
> +#if !defined(CONFIG_HPDCA) && !defined(CONFIG_HPAPCI)
> +#warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
> +#endif
Shouldn't you just change the line before this one with the proper
config option?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] serial: 8250_hp300: trivial: fix symbol name in #warning message
2014-08-08 15:29 ` Greg Kroah-Hartman
@ 2014-08-08 15:56 ` Daniele Forsi
0 siblings, 0 replies; 3+ messages in thread
From: Daniele Forsi @ 2014-08-08 15:56 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Jiri Kosina, linux-serial; +Cc: Daniele Forsi
The symbol is defined in drivers/tty/serial/8250/Kconfig as
"SERIAL_8250", not just "8250".
Signed-off-by: Daniele Forsi <dforsi@gmail.com>
---
Changes in v2:
- fix the original message and do not duplicate the whole check
drivers/tty/serial/8250/8250_hp300.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_hp300.c b/drivers/tty/serial/8250/8250_hp300.c
index 5bdaf27..afffe4d 100644
--- a/drivers/tty/serial/8250/8250_hp300.c
+++ b/drivers/tty/serial/8250/8250_hp300.c
@@ -21,7 +21,7 @@
#include "8250.h"
#if !defined(CONFIG_HPDCA) && !defined(CONFIG_HPAPCI)
-#warning CONFIG_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
+#warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
#endif
#ifdef CONFIG_HPAPCI
--
2.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-08 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-08 15:14 [PATCH] serial: 8250_hp300: trivial: fix symbol name in #warning message Daniele Forsi
2014-08-08 15:29 ` Greg Kroah-Hartman
2014-08-08 15:56 ` [PATCH v2] " Daniele Forsi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.