From: Konrad Rzeszutek Wilk <konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> To: Olav Haugan <ohaugan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions Date: Mon, 11 Aug 2014 21:35:59 -0400 [thread overview] Message-ID: <20140812013559.GA25121@laptop.dumpdata.com> (raw) In-Reply-To: <1407797150-515-2-git-send-email-ohaugan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> On Mon, Aug 11, 2014 at 03:45:50PM -0700, Olav Haugan wrote: > Mapping and unmapping are more often than not in the critical path. > map_sg and unmap_sg allows IOMMU driver implementations to optimize > the process of mapping and unmapping buffers into the IOMMU page tables. > > Instead of mapping a buffer one page at a time and requiring potentially > expensive TLB operations for each page, this function allows the driver > to map all pages in one go and defer TLB maintenance until after all > pages have been mapped. > > Additionally, the mapping operation would be faster in general since > clients does not have to keep calling map API over and over again for > each physically contiguous chunk of memory that needs to be mapped to a > virtually contiguous region. > > Signed-off-by: Olav Haugan <ohaugan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Thank you for changing it this way. .. snip.. > + for_each_sg(sg, s, nents, i) { > + phys_addr_t phys = page_to_phys(sg_page(s)); > + size_t page_len = s->offset + s->length; > + > + ret = iommu_map(domain, iova + offset, phys, page_len, > + prot); > + if (ret) { > + /* undo mappings already done */ > + iommu_unmap(domain, iova, offset); Don't we want then to unmap all of the scatter list instead of just the last one? > + break; > + } > + offset += page_len; > + } > + > + return ret; > +}
WARNING: multiple messages have this Message-ID (diff)
From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions Date: Mon, 11 Aug 2014 21:35:59 -0400 [thread overview] Message-ID: <20140812013559.GA25121@laptop.dumpdata.com> (raw) In-Reply-To: <1407797150-515-2-git-send-email-ohaugan@codeaurora.org> On Mon, Aug 11, 2014 at 03:45:50PM -0700, Olav Haugan wrote: > Mapping and unmapping are more often than not in the critical path. > map_sg and unmap_sg allows IOMMU driver implementations to optimize > the process of mapping and unmapping buffers into the IOMMU page tables. > > Instead of mapping a buffer one page at a time and requiring potentially > expensive TLB operations for each page, this function allows the driver > to map all pages in one go and defer TLB maintenance until after all > pages have been mapped. > > Additionally, the mapping operation would be faster in general since > clients does not have to keep calling map API over and over again for > each physically contiguous chunk of memory that needs to be mapped to a > virtually contiguous region. > > Signed-off-by: Olav Haugan <ohaugan@codeaurora.org> Thank you for changing it this way. .. snip.. > + for_each_sg(sg, s, nents, i) { > + phys_addr_t phys = page_to_phys(sg_page(s)); > + size_t page_len = s->offset + s->length; > + > + ret = iommu_map(domain, iova + offset, phys, page_len, > + prot); > + if (ret) { > + /* undo mappings already done */ > + iommu_unmap(domain, iova, offset); Don't we want then to unmap all of the scatter list instead of just the last one? > + break; > + } > + offset += page_len; > + } > + > + return ret; > +}
next prev parent reply other threads:[~2014-08-12 1:35 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-11 22:45 [PATCH v5 0/1] Add iommu map_sg/unmap_sg API Olav Haugan 2014-08-11 22:45 ` Olav Haugan 2014-08-11 22:45 ` [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions Olav Haugan 2014-08-11 22:45 ` Olav Haugan [not found] ` <1407797150-515-2-git-send-email-ohaugan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2014-08-12 1:35 ` Konrad Rzeszutek Wilk [this message] 2014-08-12 1:35 ` Konrad Rzeszutek Wilk [not found] ` <20140812013559.GA25121-0iZWjJA6G8GSPmnEAIUT9EEOCMrvLtNR@public.gmane.org> 2014-08-12 16:53 ` Olav Haugan 2014-08-12 16:53 ` Olav Haugan 2014-08-12 1:51 ` Hiroshi Doyu 2014-08-12 1:51 ` Hiroshi Doyu 2014-08-12 10:48 ` Rob Clark 2014-08-12 10:48 ` Rob Clark 2014-08-12 16:56 ` Olav Haugan 2014-08-12 16:56 ` Olav Haugan [not found] ` <53EA472B.3020900-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2014-08-18 14:07 ` joro-zLv9SwRftAIdnm+yROfE0A 2014-08-18 14:07 ` joro at 8bytes.org [not found] ` <20140818140730.GC9809-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> 2014-08-18 18:32 ` Rob Clark 2014-08-18 18:32 ` Rob Clark [not found] ` <CAF6AEGtGmAQjMc5W5a6x5QiyUc8v0XHcsNAFe65Znc=DDKPS+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-08-18 20:48 ` Olav Haugan 2014-08-18 20:48 ` Olav Haugan [not found] ` <53F266AE.40303-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2014-08-18 21:26 ` joro-zLv9SwRftAIdnm+yROfE0A 2014-08-18 21:26 ` joro at 8bytes.org [not found] ` <20140818212627.GI9809-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> 2014-08-18 21:32 ` Olav Haugan 2014-08-18 21:32 ` Olav Haugan 2014-08-12 16:55 ` Laurent Pinchart 2014-08-12 16:55 ` Laurent Pinchart 2014-08-12 17:10 ` Olav Haugan 2014-08-12 17:10 ` Olav Haugan 2014-08-18 21:55 ` Joerg Roedel 2014-08-18 21:55 ` Joerg Roedel 2014-08-18 22:47 ` Olav Haugan 2014-08-18 22:47 ` Olav Haugan [not found] ` <53F2829C.2040809-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2014-08-19 11:59 ` Joerg Roedel 2014-08-19 11:59 ` Joerg Roedel [not found] ` <20140819115954.GC16329-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> 2014-08-19 16:11 ` Laurent Pinchart 2014-08-19 16:11 ` Laurent Pinchart 2014-08-19 18:40 ` Olav Haugan 2014-08-19 18:40 ` Olav Haugan [not found] ` <53F39A18.70409-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2014-08-19 20:52 ` Laurent Pinchart 2014-08-19 20:52 ` Laurent Pinchart 2014-08-20 5:21 ` Thierry Reding 2014-08-20 5:21 ` Thierry Reding 2014-08-20 13:02 ` Konrad Rzeszutek Wilk 2014-08-20 13:02 ` Konrad Rzeszutek Wilk [not found] ` <20140820130250.GA3120-0iZWjJA6G8GSPmnEAIUT9EEOCMrvLtNR@public.gmane.org> 2014-08-20 14:15 ` Laurent Pinchart 2014-08-20 14:15 ` Laurent Pinchart 2014-08-19 18:37 ` Olav Haugan 2014-08-19 18:37 ` Olav Haugan 2014-09-25 17:01 ` Joerg Roedel 2014-09-25 17:01 ` Joerg Roedel [not found] ` <20140925170108.GE8306-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> 2014-10-06 19:02 ` Olav Haugan 2014-10-06 19:02 ` Olav Haugan 2014-10-15 9:16 ` Thierry Reding 2014-10-15 9:16 ` Thierry Reding 2014-10-16 17:23 ` Olav Haugan 2014-10-16 17:23 ` Olav Haugan 2014-10-17 9:09 ` Joerg Roedel 2014-10-17 9:09 ` Joerg Roedel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140812013559.GA25121@laptop.dumpdata.com \ --to=konrad.wilk-qhclzuegtsvqt0dzr+alfa@public.gmane.org \ --cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \ --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \ --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \ --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ --cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=ohaugan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.