From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com> Cc: broonie@kernel.org, lgirdwood@gmail.com, tiwai@suse.de, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, perex@perex.cz Subject: Re: [PATCH v2] mfd: wm8994: declare dc servo register for wm8958 as volatile Date: Thu, 14 Aug 2014 09:37:53 +0100 [thread overview] Message-ID: <20140814083753.GM15833@opensource.wolfsonmicro.com> (raw) In-Reply-To: <1407943649-9535-1-git-send-email-nikesh@opensource.wolfsonmicro.com> On Wed, Aug 13, 2014 at 04:27:29PM +0100, Nikesh Oswal wrote: > DC Servo register 57h holds the DC offset value after the hardware has > completed the DC Servo Correction, so declare this register as volatile > because it is changed by the hardware. > > Signed-off-by: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com> > --- > drivers/mfd/wm8994-regmap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c > index 2fbce9c..fa1630d 100644 > --- a/drivers/mfd/wm8994-regmap.c > +++ b/drivers/mfd/wm8994-regmap.c > @@ -1169,6 +1169,7 @@ static bool wm8958_volatile_register(struct device *dev, unsigned int reg) > case WM8958_FW_MINOR_0: > case WM8958_FW_PATCH_1: > case WM8958_FW_PATCH_0: > + case WM8994_DC_SERVO_4: Looking at this again it looks like this should actually be in wm8994_volatile_register as some revs of the wm8994 use this register as well as the 8958 for the servo readback. Then if you update the other patch to use this register for dsc_readback_mode = 1, then once we have a confirmation from hardware I think both of these patches are good to go. Thanks, Charles > return true; > default: > return wm8994_volatile_register(dev, reg); > -- > 1.7.9.5 > > _______________________________________________ > patches mailing list > patches@opensource.wolfsonmicro.com > http://opensource.wolfsonmicro.com/cgi-bin/mailman/listinfo/patches
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org Subject: Re: [PATCH v2] mfd: wm8994: declare dc servo register for wm8958 as volatile Date: Thu, 14 Aug 2014 09:37:53 +0100 [thread overview] Message-ID: <20140814083753.GM15833@opensource.wolfsonmicro.com> (raw) In-Reply-To: <1407943649-9535-1-git-send-email-nikesh@opensource.wolfsonmicro.com> On Wed, Aug 13, 2014 at 04:27:29PM +0100, Nikesh Oswal wrote: > DC Servo register 57h holds the DC offset value after the hardware has > completed the DC Servo Correction, so declare this register as volatile > because it is changed by the hardware. > > Signed-off-by: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com> > --- > drivers/mfd/wm8994-regmap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/wm8994-regmap.c b/drivers/mfd/wm8994-regmap.c > index 2fbce9c..fa1630d 100644 > --- a/drivers/mfd/wm8994-regmap.c > +++ b/drivers/mfd/wm8994-regmap.c > @@ -1169,6 +1169,7 @@ static bool wm8958_volatile_register(struct device *dev, unsigned int reg) > case WM8958_FW_MINOR_0: > case WM8958_FW_PATCH_1: > case WM8958_FW_PATCH_0: > + case WM8994_DC_SERVO_4: Looking at this again it looks like this should actually be in wm8994_volatile_register as some revs of the wm8994 use this register as well as the 8958 for the servo readback. Then if you update the other patch to use this register for dsc_readback_mode = 1, then once we have a confirmation from hardware I think both of these patches are good to go. Thanks, Charles > return true; > default: > return wm8994_volatile_register(dev, reg); > -- > 1.7.9.5 > > _______________________________________________ > patches mailing list > patches@opensource.wolfsonmicro.com > http://opensource.wolfsonmicro.com/cgi-bin/mailman/listinfo/patches
next prev parent reply other threads:[~2014-08-14 8:37 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-13 15:27 [PATCH v2] mfd: wm8994: declare dc servo register for wm8958 as volatile Nikesh Oswal 2014-08-14 8:37 ` Charles Keepax [this message] 2014-08-14 8:37 ` Charles Keepax
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140814083753.GM15833@opensource.wolfsonmicro.com \ --to=ckeepax@opensource.wolfsonmicro.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=nikesh@opensource.wolfsonmicro.com \ --cc=patches@opensource.wolfsonmicro.com \ --cc=perex@perex.cz \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.