* [PATCH] regulator: as3722: .name field initialized twice differently
@ 2014-08-15 11:09 ` Peter Griffin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2014-08-15 11:09 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, lgirdwood, broonie, ldewangan
Cc: peter.griffin, patches, lee.jones
Regulator AS3722_REGULATOR_ID_LDO3 and AS3722_REGULATOR_ID_LDO4
have there .name field initialised twice with different values.
Looking at the code the second entry should have been .sname
which is what this patch corrects.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/regulator/as3722-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
index ad9e0c9..b68f05f 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO3,
.name = "as3722-ldo3",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
.vsel_mask = AS3722_LDO3_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO4,
.name = "as3722-ldo4",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
.vsel_mask = AS3722_LDO_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] regulator: as3722: .name field initialized twice differently
@ 2014-08-15 11:09 ` Peter Griffin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2014-08-15 11:09 UTC (permalink / raw)
To: linux-arm-kernel
Regulator AS3722_REGULATOR_ID_LDO3 and AS3722_REGULATOR_ID_LDO4
have there .name field initialised twice with different values.
Looking at the code the second entry should have been .sname
which is what this patch corrects.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
drivers/regulator/as3722-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
index ad9e0c9..b68f05f 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO3,
.name = "as3722-ldo3",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
.vsel_mask = AS3722_LDO3_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO4,
.name = "as3722-ldo4",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
.vsel_mask = AS3722_LDO_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: as3722: .name field initialized twice differently
2014-08-15 11:09 ` Peter Griffin
@ 2014-08-15 11:41 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-08-15 11:41 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-arm-kernel, linux-kernel, lgirdwood, ldewangan, patches, lee.jones
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
On Fri, Aug 15, 2014 at 12:09:44PM +0100, Peter Griffin wrote:
> Regulator AS3722_REGULATOR_ID_LDO3 and AS3722_REGULATOR_ID_LDO4
> have there .name field initialised twice with different values.
>
> Looking at the code the second entry should have been .sname
> which is what this patch corrects.
This change appears to already be present in current code - please
submit against current code, or Linus' tree for bug fixes.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] regulator: as3722: .name field initialized twice differently
@ 2014-08-15 11:41 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-08-15 11:41 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 15, 2014 at 12:09:44PM +0100, Peter Griffin wrote:
> Regulator AS3722_REGULATOR_ID_LDO3 and AS3722_REGULATOR_ID_LDO4
> have there .name field initialised twice with different values.
>
> Looking at the code the second entry should have been .sname
> which is what this patch corrects.
This change appears to already be present in current code - please
submit against current code, or Linus' tree for bug fixes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140815/bf6c22ee/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-15 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-15 11:09 [PATCH] regulator: as3722: .name field initialized twice differently Peter Griffin
2014-08-15 11:09 ` Peter Griffin
2014-08-15 11:41 ` Mark Brown
2014-08-15 11:41 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.