From: Lina Iyer <lina.iyer@linaro.org> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Mark Rutland <Mark.Rutland@arm.com>, Catalin Marinas <Catalin.Marinas@arm.com>, Tomasz Figa <t.figa@samsung.com>, Chander Kashyap <k.chander@samsung.com>, Kukjin Kim <kgene.kim@samsung.com>, Vincent Guittot <vincent.guittot@linaro.org>, Nicolas Pitre <nico@linaro.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "grant.likely@linaro.org" <grant.likely@linaro.org>, Charles Garcia-Tobin <Charles.Garcia-Tobin@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Kevin Hilman <khilman@linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, Sebastian Capella <sebcape@gmail.com>, Rob Herring <robh+dt@kernel.org>, Antti Miettinen <ananaza@iki.fi>, Paul Walmsley <paul@pwsan.com>, Geoff Levand <geoff@infradead.org>, Peter De Schrijver <pdeschrijver@nvidia.com>, Stephen Subject: Re: [PATCH v7 8/8] drivers: cpuidle: initialize Exynos driver through DT Date: Fri, 15 Aug 2014 15:45:13 -0600 [thread overview] Message-ID: <20140815214513.GB46224@ilina-mac.local> (raw) In-Reply-To: <20140815214034.GA10552@e102568-lin.cambridge.arm.com> On Fri, Aug 15, 2014 at 10:40:34PM +0100, Lorenzo Pieralisi wrote: >On Fri, Aug 15, 2014 at 10:12:33PM +0100, Lina Iyer wrote: > >[...] > >> > static int exynos_cpuidle_probe(struct platform_device *pdev) >> > { >> >- int ret; >> >+ int ret, i; >> >+ struct cpuidle_driver *drv = &exynos_idle_driver; >> > >> > exynos_enter_aftr = (void *)(pdev->dev.platform_data); >> > >> >- ret = cpuidle_register(&exynos_idle_driver, NULL); >> >+ drv->cpumask = kzalloc(cpumask_size(), GFP_KERNEL); >> >+ if (!drv->cpumask) >> >+ return -ENOMEM; >> drv->cpumask would not have any cpu set. I dont see it being modified >> elsewhere. > >Gah, I should have missed that while refactoring, I can just compile test this >patch so it went unnoticed. Fixed (by copying the possible mask to >drv->cpumask). > >Thank you ! >Lorenzo Noticed that in the big.little exynos driver as well. > >> >+ >> >+ /* Start at index 1, index 0 standard WFI */ >> >+ ret = dt_init_idle_driver(drv, 1); >> >+ if (ret < 0) { >> >+ dev_err(&pdev->dev, "failed to initialize idle states\n"); >> >+ goto free_mem; >> >+ } >> >+ >> >+ for (i = 1; i < drv->state_count; i++) >> >+ drv->states[i].enter = exynos_enter_lowpower; >> >+ >> >+ ret = cpuidle_register(drv, NULL); >> > if (ret) { >> > dev_err(&pdev->dev, "failed to register cpuidle driver\n"); >> >- return ret; >> >+ goto free_mem; >> > } >> > >> > return 0; >> >+free_mem: >> >+ kfree(drv->cpumask); >> >+ return ret; >> > } >> > >> > static struct platform_driver exynos_cpuidle_driver = { >> >-- >> >1.9.1 >> > >> > >> >
WARNING: multiple messages have this Message-ID (diff)
From: lina.iyer@linaro.org (Lina Iyer) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 8/8] drivers: cpuidle: initialize Exynos driver through DT Date: Fri, 15 Aug 2014 15:45:13 -0600 [thread overview] Message-ID: <20140815214513.GB46224@ilina-mac.local> (raw) In-Reply-To: <20140815214034.GA10552@e102568-lin.cambridge.arm.com> On Fri, Aug 15, 2014 at 10:40:34PM +0100, Lorenzo Pieralisi wrote: >On Fri, Aug 15, 2014 at 10:12:33PM +0100, Lina Iyer wrote: > >[...] > >> > static int exynos_cpuidle_probe(struct platform_device *pdev) >> > { >> >- int ret; >> >+ int ret, i; >> >+ struct cpuidle_driver *drv = &exynos_idle_driver; >> > >> > exynos_enter_aftr = (void *)(pdev->dev.platform_data); >> > >> >- ret = cpuidle_register(&exynos_idle_driver, NULL); >> >+ drv->cpumask = kzalloc(cpumask_size(), GFP_KERNEL); >> >+ if (!drv->cpumask) >> >+ return -ENOMEM; >> drv->cpumask would not have any cpu set. I dont see it being modified >> elsewhere. > >Gah, I should have missed that while refactoring, I can just compile test this >patch so it went unnoticed. Fixed (by copying the possible mask to >drv->cpumask). > >Thank you ! >Lorenzo Noticed that in the big.little exynos driver as well. > >> >+ >> >+ /* Start at index 1, index 0 standard WFI */ >> >+ ret = dt_init_idle_driver(drv, 1); >> >+ if (ret < 0) { >> >+ dev_err(&pdev->dev, "failed to initialize idle states\n"); >> >+ goto free_mem; >> >+ } >> >+ >> >+ for (i = 1; i < drv->state_count; i++) >> >+ drv->states[i].enter = exynos_enter_lowpower; >> >+ >> >+ ret = cpuidle_register(drv, NULL); >> > if (ret) { >> > dev_err(&pdev->dev, "failed to register cpuidle driver\n"); >> >- return ret; >> >+ goto free_mem; >> > } >> > >> > return 0; >> >+free_mem: >> >+ kfree(drv->cpumask); >> >+ return ret; >> > } >> > >> > static struct platform_driver exynos_cpuidle_driver = { >> >-- >> >1.9.1 >> > >> > >> >
next prev parent reply other threads:[~2014-08-15 21:45 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-13 15:51 [PATCH v7 0/8] ARM generic idle states Lorenzo Pieralisi 2014-08-13 15:51 ` Lorenzo Pieralisi 2014-08-13 15:52 ` [PATCH v7 1/8] arm64: kernel: refactor the CPU suspend API for retention states Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi 2014-08-18 7:47 ` Hanjun Guo 2014-08-18 7:47 ` Hanjun Guo 2014-08-18 14:20 ` Catalin Marinas 2014-08-18 14:20 ` Catalin Marinas 2014-08-13 15:52 ` [PATCH v7 2/8] Documentation: arm: define DT idle states bindings Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi [not found] ` <1407945127-27554-3-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2014-08-13 19:25 ` Lina Iyer 2014-08-13 19:25 ` Lina Iyer 2014-08-13 22:11 ` Lorenzo Pieralisi 2014-08-13 22:11 ` Lorenzo Pieralisi 2014-08-15 17:20 ` Lina Iyer 2014-08-15 17:20 ` Lina Iyer 2014-08-15 17:51 ` Lorenzo Pieralisi 2014-08-15 17:51 ` Lorenzo Pieralisi 2014-08-18 14:20 ` Catalin Marinas 2014-08-18 14:20 ` Catalin Marinas 2014-08-13 15:52 ` [PATCH v7 3/8] drivers: cpuidle: implement DT based idle states infrastructure Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi 2014-08-13 16:31 ` Nicolas Pitre 2014-08-13 16:31 ` Nicolas Pitre 2014-08-13 17:04 ` Lorenzo Pieralisi 2014-08-13 17:04 ` Lorenzo Pieralisi 2014-08-13 17:29 ` Nicolas Pitre 2014-08-13 17:29 ` Nicolas Pitre 2014-08-14 11:29 ` Lorenzo Pieralisi 2014-08-14 11:29 ` Lorenzo Pieralisi 2014-08-14 15:47 ` Nicolas Pitre 2014-08-14 15:47 ` Nicolas Pitre 2014-08-14 16:02 ` Lorenzo Pieralisi 2014-08-14 16:02 ` Lorenzo Pieralisi 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 14:21 ` Catalin Marinas 2014-08-13 15:52 ` [PATCH v7 4/8] arm64: kernel: introduce cpu_init_idle CPU operation Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 14:21 ` Catalin Marinas [not found] ` <1407945127-27554-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> 2014-08-13 15:52 ` [PATCH v7 5/8] arm64: add PSCI CPU_SUSPEND based cpu_suspend support Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 14:21 ` Catalin Marinas 2014-08-13 15:52 ` [PATCH v7 6/8] drivers: cpuidle: CPU idle ARM64 driver Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 22:30 ` Lorenzo Pieralisi 2014-08-18 22:30 ` Lorenzo Pieralisi 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 22:25 ` Lorenzo Pieralisi 2014-08-18 22:25 ` Lorenzo Pieralisi 2014-08-13 15:52 ` [PATCH v7 7/8] drivers: cpuidle: initialize big.LITTLE driver through DT Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi 2014-08-18 14:21 ` Catalin Marinas 2014-08-18 14:21 ` Catalin Marinas 2014-08-13 15:52 ` [PATCH v7 8/8] drivers: cpuidle: initialize Exynos " Lorenzo Pieralisi 2014-08-13 15:52 ` Lorenzo Pieralisi 2014-08-15 21:12 ` Lina Iyer 2014-08-15 21:12 ` Lina Iyer 2014-08-15 21:40 ` Lorenzo Pieralisi 2014-08-15 21:40 ` Lorenzo Pieralisi 2014-08-15 21:45 ` Lina Iyer [this message] 2014-08-15 21:45 ` Lina Iyer 2014-08-15 21:52 ` Lorenzo Pieralisi 2014-08-15 21:52 ` Lorenzo Pieralisi 2014-08-18 14:22 ` Catalin Marinas 2014-08-18 14:22 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140815214513.GB46224@ilina-mac.local \ --to=lina.iyer@linaro.org \ --cc=Catalin.Marinas@arm.com \ --cc=Charles.Garcia-Tobin@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=ananaza@iki.fi \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=geoff@infradead.org \ --cc=grant.likely@linaro.org \ --cc=k.chander@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=nico@linaro.org \ --cc=paul@pwsan.com \ --cc=pdeschrijver@nvidia.com \ --cc=robh+dt@kernel.org \ --cc=sebcape@gmail.com \ --cc=t.figa@samsung.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.