* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-07-16 8:50 ` Daniel Drake
0 siblings, 0 replies; 24+ messages in thread
From: Daniel Drake @ 2014-07-16 8:50 UTC (permalink / raw)
To: kgene.kim; +Cc: linux-samsung-soc, liquid.acid, m.szyprowski, linux-arm-kernel
The ODROID kernel shows that the PMIC interrupt line is hooked up
to pin GPX3-2.
This is needed for the max77686-irq driver to create the PMIC IRQ
domain, which is needed by max77686-rtc.
Signed-off-by: Daniel Drake <drake@endlessm.com>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 6d6d23c..cb6f55f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -148,6 +148,10 @@
max77686: pmic@09 {
compatible = "maxim,max77686";
+ interrupt-parent = <&gpx3>;
+ interrupts = <2 0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&max77686_irq>;
reg = <0x09>;
#clock-cells = <1>;
@@ -368,4 +372,11 @@
samsung,pins = "gpx1-3";
samsung,pin-pud = <0>;
};
+
+ max77686_irq: max77686-irq {
+ samsung,pins = "gpx3-2";
+ samsung,pin-function = <0>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
};
--
1.9.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-07-16 8:50 ` Daniel Drake
0 siblings, 0 replies; 24+ messages in thread
From: Daniel Drake @ 2014-07-16 8:50 UTC (permalink / raw)
To: linux-arm-kernel
The ODROID kernel shows that the PMIC interrupt line is hooked up
to pin GPX3-2.
This is needed for the max77686-irq driver to create the PMIC IRQ
domain, which is needed by max77686-rtc.
Signed-off-by: Daniel Drake <drake@endlessm.com>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 6d6d23c..cb6f55f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -148,6 +148,10 @@
max77686: pmic at 09 {
compatible = "maxim,max77686";
+ interrupt-parent = <&gpx3>;
+ interrupts = <2 0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&max77686_irq>;
reg = <0x09>;
#clock-cells = <1>;
@@ -368,4 +372,11 @@
samsung,pins = "gpx1-3";
samsung,pin-pud = <0>;
};
+
+ max77686_irq: max77686-irq {
+ samsung,pins = "gpx3-2";
+ samsung,pin-function = <0>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
};
--
1.9.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/2] ARM: dts: ODROID i2c improvements
2014-07-16 8:50 ` Daniel Drake
@ 2014-07-16 8:50 ` Daniel Drake
-1 siblings, 0 replies; 24+ messages in thread
From: Daniel Drake @ 2014-07-16 8:50 UTC (permalink / raw)
To: kgene.kim; +Cc: linux-samsung-soc, liquid.acid, m.szyprowski, linux-arm-kernel
Increase max i2c bus frequency beyond the default for faster
data transfers. According to the manual, these faster speeds are
only available when the board is wired up the right way. In this case,
the vendor kernel has run at this speed for a long time.
sda-delay is needed for talking to RTC on PMIC, otherwise the i2c
controller never sees an ACK. Strangely the other PMIC i2c slave (the
main one) works fine even without this delay. I Chose value 100 to
match the vendor kernel.
Signed-off-by: Daniel Drake <drake@endlessm.com>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index cb6f55f..adadaf9 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -134,6 +134,8 @@
i2c@13860000 {
pinctrl-0 = <&i2c0_bus>;
pinctrl-names = "default";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <400000>;
status = "okay";
usb3503: usb3503@08 {
--
1.9.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 2/2] ARM: dts: ODROID i2c improvements
@ 2014-07-16 8:50 ` Daniel Drake
0 siblings, 0 replies; 24+ messages in thread
From: Daniel Drake @ 2014-07-16 8:50 UTC (permalink / raw)
To: linux-arm-kernel
Increase max i2c bus frequency beyond the default for faster
data transfers. According to the manual, these faster speeds are
only available when the board is wired up the right way. In this case,
the vendor kernel has run at this speed for a long time.
sda-delay is needed for talking to RTC on PMIC, otherwise the i2c
controller never sees an ACK. Strangely the other PMIC i2c slave (the
main one) works fine even without this delay. I Chose value 100 to
match the vendor kernel.
Signed-off-by: Daniel Drake <drake@endlessm.com>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index cb6f55f..adadaf9 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -134,6 +134,8 @@
i2c at 13860000 {
pinctrl-0 = <&i2c0_bus>;
pinctrl-names = "default";
+ samsung,i2c-sda-delay = <100>;
+ samsung,i2c-max-bus-freq = <400000>;
status = "okay";
usb3503: usb3503 at 08 {
--
1.9.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-07-16 8:50 ` Daniel Drake
@ 2014-07-16 12:34 ` Tomasz Figa
-1 siblings, 0 replies; 24+ messages in thread
From: Tomasz Figa @ 2014-07-16 12:34 UTC (permalink / raw)
To: Daniel Drake, kgene.kim
Cc: linux-samsung-soc, liquid.acid, m.szyprowski, linux-arm-kernel
On 16.07.2014 10:50, Daniel Drake wrote:
> The ODROID kernel shows that the PMIC interrupt line is hooked up
> to pin GPX3-2.
>
> This is needed for the max77686-irq driver to create the PMIC IRQ
> domain, which is needed by max77686-rtc.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 6d6d23c..cb6f55f 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -148,6 +148,10 @@
>
> max77686: pmic@09 {
> compatible = "maxim,max77686";
> + interrupt-parent = <&gpx3>;
> + interrupts = <2 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&max77686_irq>;
> reg = <0x09>;
> #clock-cells = <1>;
>
> @@ -368,4 +372,11 @@
> samsung,pins = "gpx1-3";
> samsung,pin-pud = <0>;
> };
> +
> + max77686_irq: max77686-irq {
> + samsung,pins = "gpx3-2";
> + samsung,pin-function = <0>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> };
>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-07-16 12:34 ` Tomasz Figa
0 siblings, 0 replies; 24+ messages in thread
From: Tomasz Figa @ 2014-07-16 12:34 UTC (permalink / raw)
To: linux-arm-kernel
On 16.07.2014 10:50, Daniel Drake wrote:
> The ODROID kernel shows that the PMIC interrupt line is hooked up
> to pin GPX3-2.
>
> This is needed for the max77686-irq driver to create the PMIC IRQ
> domain, which is needed by max77686-rtc.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 6d6d23c..cb6f55f 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -148,6 +148,10 @@
>
> max77686: pmic at 09 {
> compatible = "maxim,max77686";
> + interrupt-parent = <&gpx3>;
> + interrupts = <2 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&max77686_irq>;
> reg = <0x09>;
> #clock-cells = <1>;
>
> @@ -368,4 +372,11 @@
> samsung,pins = "gpx1-3";
> samsung,pin-pud = <0>;
> };
> +
> + max77686_irq: max77686-irq {
> + samsung,pins = "gpx3-2";
> + samsung,pin-function = <0>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> };
>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] ARM: dts: ODROID i2c improvements
2014-07-16 8:50 ` Daniel Drake
@ 2014-07-16 12:34 ` Tomasz Figa
-1 siblings, 0 replies; 24+ messages in thread
From: Tomasz Figa @ 2014-07-16 12:34 UTC (permalink / raw)
To: Daniel Drake, kgene.kim
Cc: linux-samsung-soc, liquid.acid, m.szyprowski, linux-arm-kernel
On 16.07.2014 10:50, Daniel Drake wrote:
> Increase max i2c bus frequency beyond the default for faster
> data transfers. According to the manual, these faster speeds are
> only available when the board is wired up the right way. In this case,
> the vendor kernel has run at this speed for a long time.
>
> sda-delay is needed for talking to RTC on PMIC, otherwise the i2c
> controller never sees an ACK. Strangely the other PMIC i2c slave (the
> main one) works fine even without this delay. I Chose value 100 to
> match the vendor kernel.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index cb6f55f..adadaf9 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -134,6 +134,8 @@
> i2c@13860000 {
> pinctrl-0 = <&i2c0_bus>;
> pinctrl-names = "default";
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <400000>;
> status = "okay";
>
> usb3503: usb3503@08 {
>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] ARM: dts: ODROID i2c improvements
@ 2014-07-16 12:34 ` Tomasz Figa
0 siblings, 0 replies; 24+ messages in thread
From: Tomasz Figa @ 2014-07-16 12:34 UTC (permalink / raw)
To: linux-arm-kernel
On 16.07.2014 10:50, Daniel Drake wrote:
> Increase max i2c bus frequency beyond the default for faster
> data transfers. According to the manual, these faster speeds are
> only available when the board is wired up the right way. In this case,
> the vendor kernel has run at this speed for a long time.
>
> sda-delay is needed for talking to RTC on PMIC, otherwise the i2c
> controller never sees an ACK. Strangely the other PMIC i2c slave (the
> main one) works fine even without this delay. I Chose value 100 to
> match the vendor kernel.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index cb6f55f..adadaf9 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -134,6 +134,8 @@
> i2c at 13860000 {
> pinctrl-0 = <&i2c0_bus>;
> pinctrl-names = "default";
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <400000>;
> status = "okay";
>
> usb3503: usb3503 at 08 {
>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-07-16 8:50 ` Daniel Drake
@ 2014-08-12 13:06 ` Tomeu Vizoso
-1 siblings, 0 replies; 24+ messages in thread
From: Tomeu Vizoso @ 2014-08-12 13:06 UTC (permalink / raw)
To: Daniel Drake
Cc: Kukjin Kim, liquid.acid, linux-samsung-soc, linux-arm-kernel,
Marek Szyprowski
Tested on an Odroid-U2:
Tested-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Thanks,
Tomeu
On 16 July 2014 10:50, Daniel Drake <drake@endlessm.com> wrote:
> The ODROID kernel shows that the PMIC interrupt line is hooked up
> to pin GPX3-2.
>
> This is needed for the max77686-irq driver to create the PMIC IRQ
> domain, which is needed by max77686-rtc.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 6d6d23c..cb6f55f 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -148,6 +148,10 @@
>
> max77686: pmic@09 {
> compatible = "maxim,max77686";
> + interrupt-parent = <&gpx3>;
> + interrupts = <2 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&max77686_irq>;
> reg = <0x09>;
> #clock-cells = <1>;
>
> @@ -368,4 +372,11 @@
> samsung,pins = "gpx1-3";
> samsung,pin-pud = <0>;
> };
> +
> + max77686_irq: max77686-irq {
> + samsung,pins = "gpx3-2";
> + samsung,pin-function = <0>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> };
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-08-12 13:06 ` Tomeu Vizoso
0 siblings, 0 replies; 24+ messages in thread
From: Tomeu Vizoso @ 2014-08-12 13:06 UTC (permalink / raw)
To: linux-arm-kernel
Tested on an Odroid-U2:
Tested-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Thanks,
Tomeu
On 16 July 2014 10:50, Daniel Drake <drake@endlessm.com> wrote:
> The ODROID kernel shows that the PMIC interrupt line is hooked up
> to pin GPX3-2.
>
> This is needed for the max77686-irq driver to create the PMIC IRQ
> domain, which is needed by max77686-rtc.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 6d6d23c..cb6f55f 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -148,6 +148,10 @@
>
> max77686: pmic at 09 {
> compatible = "maxim,max77686";
> + interrupt-parent = <&gpx3>;
> + interrupts = <2 0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&max77686_irq>;
> reg = <0x09>;
> #clock-cells = <1>;
>
> @@ -368,4 +372,11 @@
> samsung,pins = "gpx1-3";
> samsung,pin-pud = <0>;
> };
> +
> + max77686_irq: max77686-irq {
> + samsung,pins = "gpx3-2";
> + samsung,pin-function = <0>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> };
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 2/2] ARM: dts: ODROID i2c improvements
2014-07-16 8:50 ` Daniel Drake
@ 2014-08-12 13:11 ` Tomeu Vizoso
-1 siblings, 0 replies; 24+ messages in thread
From: Tomeu Vizoso @ 2014-08-12 13:11 UTC (permalink / raw)
To: Daniel Drake
Cc: Kukjin Kim, Tobias Jakobi, linux-samsung-soc, linux-arm-kernel,
Marek Szyprowski
Tested on an Odroid-U2:
Tested-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Thanks,
Tomeu
On 16 July 2014 10:50, Daniel Drake <drake@endlessm.com> wrote:
> Increase max i2c bus frequency beyond the default for faster
> data transfers. According to the manual, these faster speeds are
> only available when the board is wired up the right way. In this case,
> the vendor kernel has run at this speed for a long time.
>
> sda-delay is needed for talking to RTC on PMIC, otherwise the i2c
> controller never sees an ACK. Strangely the other PMIC i2c slave (the
> main one) works fine even without this delay. I Chose value 100 to
> match the vendor kernel.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index cb6f55f..adadaf9 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -134,6 +134,8 @@
> i2c@13860000 {
> pinctrl-0 = <&i2c0_bus>;
> pinctrl-names = "default";
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <400000>;
> status = "okay";
>
> usb3503: usb3503@08 {
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 2/2] ARM: dts: ODROID i2c improvements
@ 2014-08-12 13:11 ` Tomeu Vizoso
0 siblings, 0 replies; 24+ messages in thread
From: Tomeu Vizoso @ 2014-08-12 13:11 UTC (permalink / raw)
To: linux-arm-kernel
Tested on an Odroid-U2:
Tested-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Thanks,
Tomeu
On 16 July 2014 10:50, Daniel Drake <drake@endlessm.com> wrote:
> Increase max i2c bus frequency beyond the default for faster
> data transfers. According to the manual, these faster speeds are
> only available when the board is wired up the right way. In this case,
> the vendor kernel has run at this speed for a long time.
>
> sda-delay is needed for talking to RTC on PMIC, otherwise the i2c
> controller never sees an ACK. Strangely the other PMIC i2c slave (the
> main one) works fine even without this delay. I Chose value 100 to
> match the vendor kernel.
>
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index cb6f55f..adadaf9 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -134,6 +134,8 @@
> i2c at 13860000 {
> pinctrl-0 = <&i2c0_bus>;
> pinctrl-names = "default";
> + samsung,i2c-sda-delay = <100>;
> + samsung,i2c-max-bus-freq = <400000>;
> status = "okay";
>
> usb3503: usb3503 at 08 {
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-08-12 13:06 ` Tomeu Vizoso
@ 2014-08-18 16:43 ` Kukjin Kim
-1 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2014-08-18 16:43 UTC (permalink / raw)
To: Tomeu Vizoso
Cc: Daniel Drake, liquid.acid, Kukjin Kim, linux-arm-kernel,
linux-samsung-soc, Marek Szyprowski
On 08/12/14 08:06, Tomeu Vizoso wrote:
> Tested on an Odroid-U2:
>
> Tested-by: Tomeu Vizoso<tomeu@tomeuvizoso.net>
>
> Thanks,
>
> Tomeu
>
>
> On 16 July 2014 10:50, Daniel Drake<drake@endlessm.com> wrote:
>> The ODROID kernel shows that the PMIC interrupt line is hooked up
>> to pin GPX3-2.
>>
>> This is needed for the max77686-irq driver to create the PMIC IRQ
>> domain, which is needed by max77686-rtc.
>>
>> Signed-off-by: Daniel Drake<drake@endlessm.com>
>> ---
>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 6d6d23c..cb6f55f 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -148,6 +148,10 @@
>>
>> max77686: pmic@09 {
>> compatible = "maxim,max77686";
>> + interrupt-parent =<&gpx3>;
>> + interrupts =<2 0>;
>> + pinctrl-names = "default";
>> + pinctrl-0 =<&max77686_irq>;
>> reg =<0x09>;
>> #clock-cells =<1>;
>>
>> @@ -368,4 +372,11 @@
>> samsung,pins = "gpx1-3";
>> samsung,pin-pud =<0>;
>> };
>> +
>> + max77686_irq: max77686-irq {
>> + samsung,pins = "gpx3-2";
>> + samsung,pin-function =<0>;
>> + samsung,pin-pud =<0>;
>> + samsung,pin-drv =<0>;
>> + };
>> };
Thanks, applied this series.
- Kukjin
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-08-18 16:43 ` Kukjin Kim
0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2014-08-18 16:43 UTC (permalink / raw)
To: linux-arm-kernel
On 08/12/14 08:06, Tomeu Vizoso wrote:
> Tested on an Odroid-U2:
>
> Tested-by: Tomeu Vizoso<tomeu@tomeuvizoso.net>
>
> Thanks,
>
> Tomeu
>
>
> On 16 July 2014 10:50, Daniel Drake<drake@endlessm.com> wrote:
>> The ODROID kernel shows that the PMIC interrupt line is hooked up
>> to pin GPX3-2.
>>
>> This is needed for the max77686-irq driver to create the PMIC IRQ
>> domain, which is needed by max77686-rtc.
>>
>> Signed-off-by: Daniel Drake<drake@endlessm.com>
>> ---
>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 6d6d23c..cb6f55f 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -148,6 +148,10 @@
>>
>> max77686: pmic at 09 {
>> compatible = "maxim,max77686";
>> + interrupt-parent =<&gpx3>;
>> + interrupts =<2 0>;
>> + pinctrl-names = "default";
>> + pinctrl-0 =<&max77686_irq>;
>> reg =<0x09>;
>> #clock-cells =<1>;
>>
>> @@ -368,4 +372,11 @@
>> samsung,pins = "gpx1-3";
>> samsung,pin-pud =<0>;
>> };
>> +
>> + max77686_irq: max77686-irq {
>> + samsung,pins = "gpx3-2";
>> + samsung,pin-function =<0>;
>> + samsung,pin-pud =<0>;
>> + samsung,pin-drv =<0>;
>> + };
>> };
Thanks, applied this series.
- Kukjin
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-08-18 16:43 ` Kukjin Kim
@ 2014-08-19 9:57 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 24+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-08-19 9:57 UTC (permalink / raw)
To: Kukjin Kim
Cc: Tomeu Vizoso, Daniel Drake, liquid.acid, linux-arm-kernel,
linux-samsung-soc, Marek Szyprowski
Hi,
On Monday, August 18, 2014 11:43:07 AM Kukjin Kim wrote:
> On 08/12/14 08:06, Tomeu Vizoso wrote:
> > Tested on an Odroid-U2:
> >
> > Tested-by: Tomeu Vizoso<tomeu@tomeuvizoso.net>
> >
> > Thanks,
> >
> > Tomeu
> >
> >
> > On 16 July 2014 10:50, Daniel Drake<drake@endlessm.com> wrote:
> >> The ODROID kernel shows that the PMIC interrupt line is hooked up
> >> to pin GPX3-2.
> >>
> >> This is needed for the max77686-irq driver to create the PMIC IRQ
> >> domain, which is needed by max77686-rtc.
> >>
> >> Signed-off-by: Daniel Drake<drake@endlessm.com>
> >> ---
> >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >> index 6d6d23c..cb6f55f 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >> @@ -148,6 +148,10 @@
> >>
> >> max77686: pmic@09 {
> >> compatible = "maxim,max77686";
> >> + interrupt-parent =<&gpx3>;
> >> + interrupts =<2 0>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 =<&max77686_irq>;
> >> reg =<0x09>;
> >> #clock-cells =<1>;
> >>
> >> @@ -368,4 +372,11 @@
> >> samsung,pins = "gpx1-3";
> >> samsung,pin-pud =<0>;
> >> };
> >> +
> >> + max77686_irq: max77686-irq {
> >> + samsung,pins = "gpx3-2";
> >> + samsung,pin-function =<0>;
> >> + samsung,pin-pud =<0>;
> >> + samsung,pin-drv =<0>;
> >> + };
> >> };
>
> Thanks, applied this series.
Unfortunately these patches were applied to v3.18-next/dt-samsung
branch and not v3.17-samsung-fixes-1 one.
IMHO they should go to upstream ASAP as they fix the boot for
ODROID boards and they cannot break anything as they are limited
to ODROID dts files.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-08-19 9:57 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 24+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-08-19 9:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Monday, August 18, 2014 11:43:07 AM Kukjin Kim wrote:
> On 08/12/14 08:06, Tomeu Vizoso wrote:
> > Tested on an Odroid-U2:
> >
> > Tested-by: Tomeu Vizoso<tomeu@tomeuvizoso.net>
> >
> > Thanks,
> >
> > Tomeu
> >
> >
> > On 16 July 2014 10:50, Daniel Drake<drake@endlessm.com> wrote:
> >> The ODROID kernel shows that the PMIC interrupt line is hooked up
> >> to pin GPX3-2.
> >>
> >> This is needed for the max77686-irq driver to create the PMIC IRQ
> >> domain, which is needed by max77686-rtc.
> >>
> >> Signed-off-by: Daniel Drake<drake@endlessm.com>
> >> ---
> >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >> index 6d6d23c..cb6f55f 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> >> @@ -148,6 +148,10 @@
> >>
> >> max77686: pmic at 09 {
> >> compatible = "maxim,max77686";
> >> + interrupt-parent =<&gpx3>;
> >> + interrupts =<2 0>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 =<&max77686_irq>;
> >> reg =<0x09>;
> >> #clock-cells =<1>;
> >>
> >> @@ -368,4 +372,11 @@
> >> samsung,pins = "gpx1-3";
> >> samsung,pin-pud =<0>;
> >> };
> >> +
> >> + max77686_irq: max77686-irq {
> >> + samsung,pins = "gpx3-2";
> >> + samsung,pin-function =<0>;
> >> + samsung,pin-pud =<0>;
> >> + samsung,pin-drv =<0>;
> >> + };
> >> };
>
> Thanks, applied this series.
Unfortunately these patches were applied to v3.18-next/dt-samsung
branch and not v3.17-samsung-fixes-1 one.
IMHO they should go to upstream ASAP as they fix the boot for
ODROID boards and they cannot break anything as they are limited
to ODROID dts files.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-08-19 9:57 ` Bartlomiej Zolnierkiewicz
@ 2014-08-19 10:15 ` Javier Martinez Canillas
-1 siblings, 0 replies; 24+ messages in thread
From: Javier Martinez Canillas @ 2014-08-19 10:15 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Kukjin Kim, Tomeu Vizoso, Daniel Drake, liquid.acid,
linux-arm-kernel, linux-samsung-soc, Marek Szyprowski
Hello,
On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
> IMHO they should go to upstream ASAP as they fix the boot for
> ODROID boards and they cannot break anything as they are limited
> to ODROID dts files.
>
Agreed, this is definitely -rc material IMHO.
Best regards,
Javier
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-08-19 10:15 ` Javier Martinez Canillas
0 siblings, 0 replies; 24+ messages in thread
From: Javier Martinez Canillas @ 2014-08-19 10:15 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
> IMHO they should go to upstream ASAP as they fix the boot for
> ODROID boards and they cannot break anything as they are limited
> to ODROID dts files.
>
Agreed, this is definitely -rc material IMHO.
Best regards,
Javier
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-08-19 10:15 ` Javier Martinez Canillas
@ 2014-08-19 20:18 ` Olof Johansson
-1 siblings, 0 replies; 24+ messages in thread
From: Olof Johansson @ 2014-08-19 20:18 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Bartlomiej Zolnierkiewicz, Kukjin Kim, Tomeu Vizoso,
Daniel Drake, liquid.acid, linux-arm-kernel, linux-samsung-soc,
Marek Szyprowski
On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote:
> Hello,
>
> On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > IMHO they should go to upstream ASAP as they fix the boot for
> > ODROID boards and they cannot break anything as they are limited
> > to ODROID dts files.
> >
>
> Agreed, this is definitely -rc material IMHO.
Yes. Definitely.
-Olof
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-08-19 20:18 ` Olof Johansson
0 siblings, 0 replies; 24+ messages in thread
From: Olof Johansson @ 2014-08-19 20:18 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote:
> Hello,
>
> On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > IMHO they should go to upstream ASAP as they fix the boot for
> > ODROID boards and they cannot break anything as they are limited
> > to ODROID dts files.
> >
>
> Agreed, this is definitely -rc material IMHO.
Yes. Definitely.
-Olof
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-08-19 20:18 ` Olof Johansson
@ 2014-08-22 10:39 ` Kukjin Kim
-1 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2014-08-22 10:39 UTC (permalink / raw)
To: 'Olof Johansson', 'Javier Martinez Canillas'
Cc: 'Bartlomiej Zolnierkiewicz', 'Tomeu Vizoso',
'Daniel Drake',
liquid.acid, linux-arm-kernel, linux-samsung-soc,
'Marek Szyprowski'
Olof Johansson wrote:
>
> On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote:
> > Hello,
> >
> > On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
> > <b.zolnierkie@samsung.com> wrote:
> > >
> > > IMHO they should go to upstream ASAP as they fix the boot for
> > > ODROID boards and they cannot break anything as they are limited
> > > to ODROID dts files.
> > >
> >
> > Agreed, this is definitely -rc material IMHO.
>
> Yes. Definitely.
>
OK, agreed. Will apply into fixes.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-08-22 10:39 ` Kukjin Kim
0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2014-08-22 10:39 UTC (permalink / raw)
To: linux-arm-kernel
Olof Johansson wrote:
>
> On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote:
> > Hello,
> >
> > On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
> > <b.zolnierkie@samsung.com> wrote:
> > >
> > > IMHO they should go to upstream ASAP as they fix the boot for
> > > ODROID boards and they cannot break anything as they are limited
> > > to ODROID dts files.
> > >
> >
> > Agreed, this is definitely -rc material IMHO.
>
> Yes. Definitely.
>
OK, agreed. Will apply into fixes.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
2014-08-22 10:39 ` Kukjin Kim
@ 2014-08-24 18:32 ` Olof Johansson
-1 siblings, 0 replies; 24+ messages in thread
From: Olof Johansson @ 2014-08-24 18:32 UTC (permalink / raw)
To: Kukjin Kim
Cc: Javier Martinez Canillas, Bartlomiej Zolnierkiewicz,
Tomeu Vizoso, Daniel Drake, Tobias Jakobi, linux-arm-kernel,
linux-samsung-soc, Marek Szyprowski
On Fri, Aug 22, 2014 at 3:39 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Olof Johansson wrote:
>>
>> On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote:
>> > Hello,
>> >
>> > On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
>> > <b.zolnierkie@samsung.com> wrote:
>> > >
>> > > IMHO they should go to upstream ASAP as they fix the boot for
>> > > ODROID boards and they cannot break anything as they are limited
>> > > to ODROID dts files.
>> > >
>> >
>> > Agreed, this is definitely -rc material IMHO.
>>
>> Yes. Definitely.
>>
> OK, agreed. Will apply into fixes.
Hi,
I'm about to send a batch up to Linus, and this was quick to apply
myself, so I've done so -- I'm interested in keeping this hardware
working since I have it in my test setup as the only EXYNOS4 machine.
-Olof
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
@ 2014-08-24 18:32 ` Olof Johansson
0 siblings, 0 replies; 24+ messages in thread
From: Olof Johansson @ 2014-08-24 18:32 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 22, 2014 at 3:39 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Olof Johansson wrote:
>>
>> On Tue, Aug 19, 2014 at 12:15:41PM +0200, Javier Martinez Canillas wrote:
>> > Hello,
>> >
>> > On Tue, Aug 19, 2014 at 11:57 AM, Bartlomiej Zolnierkiewicz
>> > <b.zolnierkie@samsung.com> wrote:
>> > >
>> > > IMHO they should go to upstream ASAP as they fix the boot for
>> > > ODROID boards and they cannot break anything as they are limited
>> > > to ODROID dts files.
>> > >
>> >
>> > Agreed, this is definitely -rc material IMHO.
>>
>> Yes. Definitely.
>>
> OK, agreed. Will apply into fixes.
Hi,
I'm about to send a batch up to Linus, and this was quick to apply
myself, so I've done so -- I'm interested in keeping this hardware
working since I have it in my test setup as the only EXYNOS4 machine.
-Olof
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2014-08-24 18:32 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-16 8:50 [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID Daniel Drake
2014-07-16 8:50 ` Daniel Drake
2014-07-16 8:50 ` [PATCH 2/2] ARM: dts: ODROID i2c improvements Daniel Drake
2014-07-16 8:50 ` Daniel Drake
2014-07-16 12:34 ` Tomasz Figa
2014-07-16 12:34 ` Tomasz Figa
2014-08-12 13:11 ` Tomeu Vizoso
2014-08-12 13:11 ` Tomeu Vizoso
2014-07-16 12:34 ` [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID Tomasz Figa
2014-07-16 12:34 ` Tomasz Figa
2014-08-12 13:06 ` Tomeu Vizoso
2014-08-12 13:06 ` Tomeu Vizoso
2014-08-18 16:43 ` Kukjin Kim
2014-08-18 16:43 ` Kukjin Kim
2014-08-19 9:57 ` Bartlomiej Zolnierkiewicz
2014-08-19 9:57 ` Bartlomiej Zolnierkiewicz
2014-08-19 10:15 ` Javier Martinez Canillas
2014-08-19 10:15 ` Javier Martinez Canillas
2014-08-19 20:18 ` Olof Johansson
2014-08-19 20:18 ` Olof Johansson
2014-08-22 10:39 ` Kukjin Kim
2014-08-22 10:39 ` Kukjin Kim
2014-08-24 18:32 ` Olof Johansson
2014-08-24 18:32 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.