All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Jingoo Han <jg1.han@samsung.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
	"linux-pci" <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API
Date: Wed, 20 Aug 2014 13:27:57 +0200	[thread overview]
Message-ID: <201408201327.57376.arnd@arndb.de> (raw)
In-Reply-To: <1407861695-25549-1-git-send-email-Liviu.Dudau@arm.com>

On Tuesday 12 August 2014, Liviu Dudau wrote:
> +       return of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops,
> +                                       gen_pci_setup, pci);

I had not noticed it earlier, but the setup callback is actually a feature
of the arm32 PCI code that I had hoped to avoid when moving to the
generic API. Can we do this as a more regular sequence of


	ret = of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops, pci);
	if (ret)
		return ret;

	ret = gen_pci_setup(pci);
	if (ret)
		pci_destroy_host_bridge(dev, pci);
	return ret;

?

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API
Date: Wed, 20 Aug 2014 13:27:57 +0200	[thread overview]
Message-ID: <201408201327.57376.arnd@arndb.de> (raw)
In-Reply-To: <1407861695-25549-1-git-send-email-Liviu.Dudau@arm.com>

On Tuesday 12 August 2014, Liviu Dudau wrote:
> +       return of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops,
> +                                       gen_pci_setup, pci);

I had not noticed it earlier, but the setup callback is actually a feature
of the arm32 PCI code that I had hoped to avoid when moving to the
generic API. Can we do this as a more regular sequence of


	ret = of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops, pci);
	if (ret)
		return ret;

	ret = gen_pci_setup(pci);
	if (ret)
		pci_destroy_host_bridge(dev, pci);
	return ret;

?

	Arnd

  parent reply	other threads:[~2014-08-20 11:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 16:41 [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API Liviu Dudau
2014-08-12 16:41 ` Liviu Dudau
2014-08-19 12:05 ` Will Deacon
2014-08-19 12:05   ` Will Deacon
2014-08-20 11:23   ` Arnd Bergmann
2014-08-20 11:23     ` Arnd Bergmann
2014-09-04 13:39   ` Lorenzo Pieralisi
2014-09-04 13:39     ` Lorenzo Pieralisi
2014-09-04 14:05     ` Arnd Bergmann
2014-09-04 14:05       ` Arnd Bergmann
2014-09-04 16:02       ` Lorenzo Pieralisi
2014-09-04 16:02         ` Lorenzo Pieralisi
2014-09-04 18:56         ` Arnd Bergmann
2014-09-04 18:56           ` Arnd Bergmann
2014-08-20 11:27 ` Arnd Bergmann [this message]
2014-08-20 11:27   ` Arnd Bergmann
2014-08-20 12:31   ` Liviu Dudau
2014-08-20 12:31     ` Liviu Dudau
2014-08-20 19:39     ` Arnd Bergmann
2014-08-20 19:39       ` Arnd Bergmann
2014-08-21 23:07       ` Liviu Dudau
2014-08-21 23:07         ` Liviu Dudau
2014-08-20 22:35     ` Bjorn Helgaas
2014-08-20 22:35       ` Bjorn Helgaas
2014-08-21 18:02       ` Bjorn Helgaas
2014-08-21 18:02         ` Bjorn Helgaas
2014-08-21 22:13         ` Liviu Dudau
2014-08-21 22:13           ` Liviu Dudau
2014-08-21 23:01         ` Liviu Dudau
2014-08-21 23:01           ` Liviu Dudau
2014-08-22  5:13           ` Bjorn Helgaas
2014-08-22  5:13             ` Bjorn Helgaas
2014-08-22 12:32             ` Liviu Dudau
2014-08-22 12:32               ` Liviu Dudau
2014-08-22 15:27               ` Bjorn Helgaas
2014-08-22 15:27                 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201408201327.57376.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=Catalin.Marinas@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=bhelgaas@google.com \
    --cc=jg1.han@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.