* [PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer()
@ 2014-08-17 10:21 Andreea-Cristina Bernat
2014-08-22 19:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andreea-Cristina Bernat @ 2014-08-17 10:21 UTC (permalink / raw)
To: j.vosburgh, vfalico, andy, netdev, linux-kernel; +Cc: paulmck
This "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes this replacement.
The following Coccinelle semantic patch was used for solving it:
@@
@@
(
if(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
|
while(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
Changes in v2:
- Modified subject line from
"rcu: Replace rcu_dereference() with rcu_access_pointer()"
to
"bonding: Replace rcu_dereference() with rcu_access_pointer()",
noted by David Miller <davem@davemloft.net>
drivers/net/bonding/bond_alb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 76c0dad..1319c5b 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -1385,7 +1385,7 @@ static int bond_do_alb_xmit(struct sk_buff *skb, struct bonding *bond,
}
if (tx_slave && bond_slave_can_tx(tx_slave)) {
- if (tx_slave != rcu_dereference(bond->curr_active_slave)) {
+ if (tx_slave != rcu_access_pointer(bond->curr_active_slave)) {
ether_addr_copy(eth_data->h_source,
tx_slave->dev->dev_addr);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer()
2014-08-17 10:21 [PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer() Andreea-Cristina Bernat
@ 2014-08-22 19:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-08-22 19:28 UTC (permalink / raw)
To: bernat.ada; +Cc: j.vosburgh, vfalico, andy, netdev, linux-kernel, paulmck
From: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Date: Sun, 17 Aug 2014 13:21:45 +0300
> This "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes this replacement.
...
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-22 19:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-17 10:21 [PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer() Andreea-Cristina Bernat
2014-08-22 19:28 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.