Re: [PATCH v4 1/2] pwm: lpss: properly split driver to parts

From: Thierry Reding <thierry.reding@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-pwm@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH v4 1/2] pwm: lpss: properly split driver to parts
Date: Fri, 22 Aug 2014 13:13:44 +0200	[thread overview]
Message-ID: <20140822111343.GA3825@ulmo> (raw)
In-Reply-To: <1408465056-8605-2-git-send-email-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

On Tue, Aug 19, 2014 at 07:17:35PM +0300, Andy Shevchenko wrote:
[...]
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
[...]
> +config PWM_LPSS_PCI
> +	tristate "Intel LPSS PWM PCI driver"
> +	depends on PCI
> +	select PWM_LPSS
[...]
> +config PWM_LPSS_PLATFORM
> +	tristate "Intel LPSS PWM platform driver"
> +	depends on ACPI
> +	select PWM_LPSS

I changed both of the above select PWM_LPSS to depends on PWM_LPSS
because that makes them show up in a more meaningful way in menuconfig
and otherwise it looks weird if the PWM_LPSS shows up as automatically
selected without being useful in itself. This way the PWM_LPSS is sort
of a common core that PWM_LPSS_PLATFORM and PWM_LPSS_PCI use.

An alternative that's commonly used for this would be to hide PWM_LPSS
from users and keep the select within PWM_LPSS_PLATFORM and
PWM_LPSS_PCI. That would be okay with me too.

Let me know if you have any objections to this change.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]