* [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
@ 2014-08-22 13:06 ` Andreea-Cristina Bernat
0 siblings, 0 replies; 5+ messages in thread
From: Andreea-Cristina Bernat @ 2014-08-22 13:06 UTC (permalink / raw)
To: stephen, davem, bridge, netdev, linux-kernel; +Cc: paulmck
The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
net/bridge/br_multicast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index abfa0b65..9b64383 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1822,7 +1822,7 @@ static void br_multicast_query_expired(struct net_bridge *br,
if (query->startup_sent < br->multicast_startup_query_count)
query->startup_sent++;
- rcu_assign_pointer(querier, NULL);
+ RCU_INIT_POINTER(querier, NULL);
br_multicast_send_query(br, NULL, query);
spin_unlock(&br->multicast_lock);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Bridge] [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
@ 2014-08-22 13:06 ` Andreea-Cristina Bernat
0 siblings, 0 replies; 5+ messages in thread
From: Andreea-Cristina Bernat @ 2014-08-22 13:06 UTC (permalink / raw)
To: stephen, davem, bridge, netdev, linux-kernel; +Cc: paulmck
The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
net/bridge/br_multicast.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index abfa0b65..9b64383 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1822,7 +1822,7 @@ static void br_multicast_query_expired(struct net_bridge *br,
if (query->startup_sent < br->multicast_startup_query_count)
query->startup_sent++;
- rcu_assign_pointer(querier, NULL);
+ RCU_INIT_POINTER(querier, NULL);
br_multicast_send_query(br, NULL, query);
spin_unlock(&br->multicast_lock);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
2014-08-22 13:06 ` [Bridge] " Andreea-Cristina Bernat
(?)
@ 2014-08-22 19:28 ` David Miller
-1 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2014-08-22 19:28 UTC (permalink / raw)
To: bernat.ada; +Cc: stephen, bridge, netdev, linux-kernel, paulmck
From: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Date: Fri, 22 Aug 2014 16:06:09 +0300
> The use of "rcu_assign_pointer()" is NULLing out the pointer.
> According to RCU_INIT_POINTER()'s block comment:
> "1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
> it is better to use it instead of rcu_assign_pointer() because it has a
> smaller overhead.
...
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
@ 2014-08-22 19:28 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2014-08-22 19:28 UTC (permalink / raw)
To: bernat.ada; +Cc: stephen, netdev, bridge, paulmck, linux-kernel
From: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Date: Fri, 22 Aug 2014 16:06:09 +0300
> The use of "rcu_assign_pointer()" is NULLing out the pointer.
> According to RCU_INIT_POINTER()'s block comment:
> "1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
> it is better to use it instead of rcu_assign_pointer() because it has a
> smaller overhead.
...
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Bridge] [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
@ 2014-08-22 19:28 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2014-08-22 19:28 UTC (permalink / raw)
To: bernat.ada; +Cc: stephen, netdev, bridge, paulmck, linux-kernel
From: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Date: Fri, 22 Aug 2014 16:06:09 +0300
> The use of "rcu_assign_pointer()" is NULLing out the pointer.
> According to RCU_INIT_POINTER()'s block comment:
> "1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
> it is better to use it instead of rcu_assign_pointer() because it has a
> smaller overhead.
...
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-22 19:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 13:06 [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER() Andreea-Cristina Bernat
2014-08-22 13:06 ` [Bridge] " Andreea-Cristina Bernat
2014-08-22 19:28 ` David Miller
2014-08-22 19:28 ` [Bridge] " David Miller
2014-08-22 19:28 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.