* [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions
@ 2014-08-26 11:05 Vasili Galka
2014-08-26 19:45 ` Marek Vasut
2014-09-01 20:53 ` Wolfgang Denk
0 siblings, 2 replies; 6+ messages in thread
From: Vasili Galka @ 2014-08-26 11:05 UTC (permalink / raw)
To: u-boot
Some drivers (e.g. net/e1000) reference these functions. So, this
fixes the build of MVBC_P board.
I'm not familiar with the MPC5xxx platform, maybe a full
implementation shall be implemented instead of this stub in the
future.
Signed-off-by: Vasili Galka <vvv444@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de>
---
arch/powerpc/cpu/mpc5xxx/Makefile | 1 +
arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++
2 files changed, 16 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
diff --git a/arch/powerpc/cpu/mpc5xxx/Makefile b/arch/powerpc/cpu/mpc5xxx/Makefile
index 5c67e1d..d122b29 100644
--- a/arch/powerpc/cpu/mpc5xxx/Makefile
+++ b/arch/powerpc/cpu/mpc5xxx/Makefile
@@ -7,6 +7,7 @@
extra-y = start.o
extra-y += traps.o
+obj-y += cache.o
obj-y += io.o
obj-y += firmware_sc_task_bestcomm.impl.o
obj-y += i2c.o
diff --git a/arch/powerpc/cpu/mpc5xxx/cache.c b/arch/powerpc/cpu/mpc5xxx/cache.c
new file mode 100644
index 0000000..5d674bc
--- /dev/null
+++ b/arch/powerpc/cpu/mpc5xxx/cache.c
@@ -0,0 +1,15 @@
+/*
+ * This file contains stub implementation of
+ * invalidate_dcache_range()
+ * flush_dcache_range()
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+void invalidate_dcache_range(unsigned long start, unsigned long stop)
+{
+}
+
+void flush_dcache_range(unsigned long start, unsigned long stop)
+{
+}
--
1.7.9
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions
2014-08-26 11:05 [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions Vasili Galka
@ 2014-08-26 19:45 ` Marek Vasut
2014-08-26 19:48 ` Scott Wood
2014-09-01 20:53 ` Wolfgang Denk
1 sibling, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2014-08-26 19:45 UTC (permalink / raw)
To: u-boot
On Tuesday, August 26, 2014 at 01:05:31 PM, Vasili Galka wrote:
> Some drivers (e.g. net/e1000) reference these functions. So, this
> fixes the build of MVBC_P board.
>
> I'm not familiar with the MPC5xxx platform, maybe a full
> implementation shall be implemented instead of this stub in the
> future.
Is MPC5xxx cache coherent PPC or is it not ?
> Signed-off-by: Vasili Galka <vvv444@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de>
+CC Scott , he can likely clarify .
> ---
> arch/powerpc/cpu/mpc5xxx/Makefile | 1 +
> arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++
> 2 files changed, 16 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
>
> diff --git a/arch/powerpc/cpu/mpc5xxx/Makefile
> b/arch/powerpc/cpu/mpc5xxx/Makefile index 5c67e1d..d122b29 100644
> --- a/arch/powerpc/cpu/mpc5xxx/Makefile
> +++ b/arch/powerpc/cpu/mpc5xxx/Makefile
> @@ -7,6 +7,7 @@
>
> extra-y = start.o
> extra-y += traps.o
> +obj-y += cache.o
> obj-y += io.o
> obj-y += firmware_sc_task_bestcomm.impl.o
> obj-y += i2c.o
> diff --git a/arch/powerpc/cpu/mpc5xxx/cache.c
> b/arch/powerpc/cpu/mpc5xxx/cache.c new file mode 100644
> index 0000000..5d674bc
> --- /dev/null
> +++ b/arch/powerpc/cpu/mpc5xxx/cache.c
> @@ -0,0 +1,15 @@
> +/*
> + * This file contains stub implementation of
> + * invalidate_dcache_range()
> + * flush_dcache_range()
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +void invalidate_dcache_range(unsigned long start, unsigned long stop)
> +{
> +}
> +
> +void flush_dcache_range(unsigned long start, unsigned long stop)
> +{
> +}
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions
2014-08-26 19:45 ` Marek Vasut
@ 2014-08-26 19:48 ` Scott Wood
2014-08-26 19:56 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2014-08-26 19:48 UTC (permalink / raw)
To: u-boot
On Tue, 2014-08-26 at 21:45 +0200, Marek Vasut wrote:
> On Tuesday, August 26, 2014 at 01:05:31 PM, Vasili Galka wrote:
> > Some drivers (e.g. net/e1000) reference these functions. So, this
> > fixes the build of MVBC_P board.
> >
> > I'm not familiar with the MPC5xxx platform, maybe a full
> > implementation shall be implemented instead of this stub in the
> > future.
>
> Is MPC5xxx cache coherent PPC or is it not ?
>
> > Signed-off-by: Vasili Galka <vvv444@gmail.com>
> > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de>
>
> +CC Scott , he can likely clarify .
MPC5xxx is from a different part of Freescale, so I'm not sure, except
to note that the first link I found by googling "mpc5xxx cache coherent"
is a patch from Wolfgang suggesting that it is:
https://git.linaro.org/?p=boot/u-boot-linaro-stable.git;a=patch;h=8419c013048b1f15f3fa2fc7c0463d860a04ee3e
:-)
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions
2014-08-26 19:48 ` Scott Wood
@ 2014-08-26 19:56 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2014-08-26 19:56 UTC (permalink / raw)
To: u-boot
On Tuesday, August 26, 2014 at 09:48:26 PM, Scott Wood wrote:
> On Tue, 2014-08-26 at 21:45 +0200, Marek Vasut wrote:
> > On Tuesday, August 26, 2014 at 01:05:31 PM, Vasili Galka wrote:
> > > Some drivers (e.g. net/e1000) reference these functions. So, this
> > > fixes the build of MVBC_P board.
> > >
> > > I'm not familiar with the MPC5xxx platform, maybe a full
> > > implementation shall be implemented instead of this stub in the
> > > future.
> >
> > Is MPC5xxx cache coherent PPC or is it not ?
> >
> > > Signed-off-by: Vasili Galka <vvv444@gmail.com>
> > > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de>
> >
> > +CC Scott , he can likely clarify .
>
> MPC5xxx is from a different part of Freescale, so I'm not sure, except
> to note that the first link I found by googling "mpc5xxx cache coherent"
> is a patch from Wolfgang suggesting that it is:
>
> https://git.linaro.org/?p=boot/u-boot-linaro-stable.git;a=patch;h=8419c0130
> 48b1f15f3fa2fc7c0463d860a04ee3e
Well OK. Who shall pick this patch up or decide what to do about it ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions
2014-08-26 11:05 [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions Vasili Galka
2014-08-26 19:45 ` Marek Vasut
@ 2014-09-01 20:53 ` Wolfgang Denk
2014-09-02 12:20 ` Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2014-09-01 20:53 UTC (permalink / raw)
To: u-boot
Dear Vasili Galka,
In message <1409051131-7260-1-git-send-email-vvv444@gmail.com> you wrote:
> Some drivers (e.g. net/e1000) reference these functions. So, this
> fixes the build of MVBC_P board.
>
> I'm not familiar with the MPC5xxx platform, maybe a full
> implementation shall be implemented instead of this stub in the
> future.
>
> Signed-off-by: Vasili Galka <vvv444@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de>
> ---
> arch/powerpc/cpu/mpc5xxx/Makefile | 1 +
> arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++
> 2 files changed, 16 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
Acked-by: Wolfgang Denk <wd@denx.de>
Tom, can you please pick this up directly? Thanks!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number of Unix installations has grown to 10, with more
expected." - The Unix Programmer's Manual, 2nd Edition, June, 1972
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions
2014-09-01 20:53 ` Wolfgang Denk
@ 2014-09-02 12:20 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2014-09-02 12:20 UTC (permalink / raw)
To: u-boot
On Mon, Sep 01, 2014 at 10:53:10PM +0200, Wolfgang Denk wrote:
> Dear Vasili Galka,
>
> In message <1409051131-7260-1-git-send-email-vvv444@gmail.com> you wrote:
> > Some drivers (e.g. net/e1000) reference these functions. So, this
> > fixes the build of MVBC_P board.
> >
> > I'm not familiar with the MPC5xxx platform, maybe a full
> > implementation shall be implemented instead of this stub in the
> > future.
> >
> > Signed-off-by: Vasili Galka <vvv444@gmail.com>
> > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de>
> > ---
> > arch/powerpc/cpu/mpc5xxx/Makefile | 1 +
> > arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++
> > 2 files changed, 16 insertions(+), 0 deletions(-)
> > create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c
>
> Acked-by: Wolfgang Denk <wd@denx.de>
>
>
> Tom, can you please pick this up directly? Thanks!
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140902/6d79edb3/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-02 12:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-26 11:05 [U-Boot] [PATCH] mpc5xxx: Add stub implementation of cache functions Vasili Galka
2014-08-26 19:45 ` Marek Vasut
2014-08-26 19:48 ` Scott Wood
2014-08-26 19:56 ` Marek Vasut
2014-09-01 20:53 ` Wolfgang Denk
2014-09-02 12:20 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.