All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: mx6: Add support for Kosagi Novena
Date: Sat, 30 Aug 2014 16:20:02 +0200	[thread overview]
Message-ID: <201408301620.02617.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5CkJZ24wXre0OkHFPwM2apPAq8VhFnRyXaCoPTGSNg2YQ@mail.gmail.com>

On Saturday, August 30, 2014 at 03:55:48 PM, Fabio Estevam wrote:
> On Sat, Aug 30, 2014 at 9:40 AM, Marek Vasut <marex@denx.de> wrote:
> > On Friday, August 29, 2014 at 07:08:54 PM, Fabio Estevam wrote:
> > [...]
> > 
> >> > +/* Extra U-Boot environment. */
> >> > +#define CONFIG_EXTRA_ENV_SETTINGS                                    
> >> >  \ +       "fdt_high=0xffffffff\0"                                   
> >> >      \ +       "initrd_high=0xffffffff\0"                            
> >> >          \ +       "consdev=ttymxc1\0"                               
> >> >              \ +       "baudrate=115200\0"                           
> >> >                  \ +       "bootdev=/dev/mmcblk0p1\0"                
> >> >                      \ +       "rootdev=/dev/mmcblk0p2\0"            
> >> >                          \ +       "netdev=eth0\0"                   
> >> >                              \ +      
> >> > "rootpath=/opt/eldk-5.5/armv7a-hf/rootfs-qte-sdk\0"             \
> >> 
> >> This seems to be a too specific rootpath name. Not everyone will use
> >> this same rootpath.
> > 
> > You're right, but what kind of sane default do you suggest ? The user
> > will overwrite this anyway ...
> 
> I would say just get rid of this default rootpath entry.
> 
> Users will have to add their own ipaddr, serverip and rootpath anyway.

Sure, but having some default value is better than having all the scripts broken 
because the variable is not set at all, right ?

Best regards,
Marek Vasut

  reply	other threads:[~2014-08-30 14:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  9:30 [U-Boot] [PATCH] ARM: mx6: Add support for Kosagi Novena Marek Vasut
2014-08-29 15:58 ` Stephen Warren
2014-08-29 16:24   ` Marek Vasut
2014-08-29 16:46 ` Nikolay Dimitrov
2014-08-29 16:50   ` Marek Vasut
2014-08-29 17:08 ` Fabio Estevam
2014-08-30 12:40   ` Marek Vasut
2014-08-30 13:55     ` Fabio Estevam
2014-08-30 14:20       ` Marek Vasut [this message]
2014-09-16 11:00         ` Stefano Babic
2014-09-21 13:45           ` Marek Vasut
2014-08-30 14:12 ` Fabio Estevam
2014-08-30 14:22   ` Marek Vasut
2014-08-30 15:20     ` Fabio Estevam
2014-08-30 16:34       ` Marek Vasut
2014-08-30 16:50         ` Fabio Estevam
2014-09-24 16:57 ` Sean Cross
2014-09-27 20:19   ` Marek Vasut
2014-10-02  6:16     ` Sean Cross
2014-10-10  0:02       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201408301620.02617.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.