* [PATCH -next] ASoC: es8328: fix error return code in es8328_codec_probe()
@ 2014-09-01 0:47 weiyj_lk
2014-09-01 10:34 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: weiyj_lk @ 2014-09-01 0:47 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Sean Cross
Cc: Wei Yongjun, alsa-devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
sound/soc/codecs/es8328.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/es8328.c b/sound/soc/codecs/es8328.c
index 7a9f65a..3ff7870 100644
--- a/sound/soc/codecs/es8328.c
+++ b/sound/soc/codecs/es8328.c
@@ -665,6 +665,7 @@ static int es8328_codec_probe(struct snd_soc_codec *codec)
es8328->clk = devm_clk_get(codec->dev, NULL);
if (IS_ERR(es8328->clk)) {
dev_err(codec->dev, "codec clock missing or invalid\n");
+ ret = PTR_ERR(es8328->clk);
goto clk_fail;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ASoC: es8328: fix error return code in es8328_codec_probe()
2014-09-01 0:47 [PATCH -next] ASoC: es8328: fix error return code in es8328_codec_probe() weiyj_lk
@ 2014-09-01 10:34 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-09-01 10:34 UTC (permalink / raw)
To: weiyj_lk
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Sean Cross,
Wei Yongjun, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
On Mon, Sep 01, 2014 at 08:47:50AM +0800, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] ASoC: es8328: fix error return code in es8328_codec_probe()
@ 2014-09-01 10:34 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-09-01 10:34 UTC (permalink / raw)
To: weiyj_lk
Cc: alsa-devel, Takashi Iwai, linux-kernel, Liam Girdwood,
Wei Yongjun, Sean Cross
[-- Attachment #1.1: Type: text/plain, Size: 265 bytes --]
On Mon, Sep 01, 2014 at 08:47:50AM +0800, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-01 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-01 0:47 [PATCH -next] ASoC: es8328: fix error return code in es8328_codec_probe() weiyj_lk
2014-09-01 10:34 ` Mark Brown
2014-09-01 10:34 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.