* Re: [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c
[not found] <1409672694-32108-1-git-send-email-zlang@redhat.com>
@ 2014-09-03 7:22 ` chrubis
[not found] ` <5406CE2C.5080006@redhat.com>
0 siblings, 1 reply; 7+ messages in thread
From: chrubis @ 2014-09-03 7:22 UTC (permalink / raw)
To: Zorro Lang; +Cc: ltp-list
Hi!
> when compile kernel/fs/fsstress/fsstress.c, some warning always be printed.
> Because there is a new field 'isxfs' be added in opdesc_t struct,
> but some lines of opdesc_t ops[] forget to init this field.
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c
[not found] ` <5406CE2C.5080006@redhat.com>
@ 2014-09-03 8:17 ` chrubis
0 siblings, 0 replies; 7+ messages in thread
From: chrubis @ 2014-09-03 8:17 UTC (permalink / raw)
To: Zorro Lang; +Cc: ltp-list
Hi!
> >> when compile kernel/fs/fsstress/fsstress.c, some warning always be printed.
> >> Because there is a new field 'isxfs' be added in opdesc_t struct,
> >> but some lines of opdesc_t ops[] forget to init this field.
> > Pushed, thanks.
> >
> Thank you very much.
>
> How about the other patch, named "fs/fsstress: prevent orphan and zombie
> processes to be left".
> That is we really want to be merged.
I will have a look ASAP.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c
[not found] ` <5405E5EC.4010406@redhat.com>
@ 2014-09-02 16:00 ` chrubis
0 siblings, 0 replies; 7+ messages in thread
From: chrubis @ 2014-09-02 16:00 UTC (permalink / raw)
To: Zorro Lang; +Cc: ltp-list
Hi!
> >> when compile kernel/fs/fsstress/fsstress.c, some warning always be printed.
> >> Because there is a new field 'isxfs' be added in opdesc_t struct,
> >> but some lines of opdesc_t ops[] forget to init this field.
> > The changes looks good but 'git am' says:
> >
> > Applying: fs/fsstress: modify compile warning about fsstress.c
> > fatal: corrupt patch at line 81
> >
> > Can you please resend (preferably generated by 'git format-patch' or send
> > by 'git send-email')?
> >
> Sorry about that. Because there is no reply for long time, I edited the
> patch email by my thunderbird(an email tool) and re-sent to you. I think
> that changed the format of the patch.
> I will resend my two patches about fsstress.c later.
That explains it, thunderbird is known for mangling patches. There is a
howto for configuring it not to do that in linux kernel source in
Documentation/email-clients.txt.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c
2014-08-20 2:37 Zorro Lang
@ 2014-09-02 13:21 ` chrubis
[not found] ` <5405E5EC.4010406@redhat.com>
0 siblings, 1 reply; 7+ messages in thread
From: chrubis @ 2014-09-02 13:21 UTC (permalink / raw)
To: Zorro Lang; +Cc: ltp-list
Hi!
> when compile kernel/fs/fsstress/fsstress.c, some warning always be printed.
> Because there is a new field 'isxfs' be added in opdesc_t struct,
> but some lines of opdesc_t ops[] forget to init this field.
The changes looks good but 'git am' says:
Applying: fs/fsstress: modify compile warning about fsstress.c
fatal: corrupt patch at line 81
Can you please resend (preferably generated by 'git format-patch' or send
by 'git send-email')?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c
@ 2014-08-29 7:05 Zorro Lang
0 siblings, 0 replies; 7+ messages in thread
From: Zorro Lang @ 2014-08-29 7:05 UTC (permalink / raw)
To: ltp-list
when compile kernel/fs/fsstress/fsstress.c, some warning always be printed.
Because there is a new field 'isxfs' be added in opdesc_t struct,
but some lines of opdesc_t ops[] forget to init this field.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
Hi,
Ping ...
I have sent my two patch for a long time, but no response until now. If
there are any problems you don't want to merge it, please tell me.
(Re-send this patch again now. )
Thank you,
Zorro Lang
testcases/kernel/fs/fsstress/fsstress.c | 40
++++++++++++++++-----------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/testcases/kernel/fs/fsstress/fsstress.c
b/testcases/kernel/fs/fsstress/fsstress.c
index 4a8a1c2..1783783 100644
--- a/testcases/kernel/fs/fsstress/fsstress.c
+++ b/testcases/kernel/fs/fsstress/fsstress.c
@@ -164,35 +164,35 @@ opdesc_t ops[] = {
{OP_BULKSTAT, "bulkstat", bulkstat_f, 1, 0, 1},
{OP_BULKSTAT1, "bulkstat1", bulkstat1_f, 1, 0, 1},
#endif
- {OP_CHOWN, "chown", chown_f, 3, 1},
- {OP_CREAT, "creat", creat_f, 4, 1},
- {OP_DREAD, "dread", dread_f, 4, 0},
- {OP_DWRITE, "dwrite", dwrite_f, 4, 1},
- {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1},
+ {OP_CHOWN, "chown", chown_f, 3, 1, 0},
+ {OP_CREAT, "creat", creat_f, 4, 1, 0},
+ {OP_DREAD, "dread", dread_f, 4, 0, 0},
+ {OP_DWRITE, "dwrite", dwrite_f, 4, 1, 0},
+ {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1, 0},
#ifndef NO_XFS
{OP_FREESP, "freesp", freesp_f, 1, 1, 1},
#endif
- {OP_FSYNC, "fsync", fsync_f, 1, 1},
- {OP_GETDENTS, "getdents", getdents_f, 1, 0},
- {OP_LINK, "link", link_f, 1, 1},
- {OP_MKDIR, "mkdir", mkdir_f, 2, 1},
- {OP_MKNOD, "mknod", mknod_f, 2, 1},
- {OP_READ, "read", read_f, 1, 0},
- {OP_READLINK, "readlink", readlink_f, 1, 0},
- {OP_RENAME, "rename", rename_f, 2, 1},
+ {OP_FSYNC, "fsync", fsync_f, 1, 1, 0},
+ {OP_GETDENTS, "getdents", getdents_f, 1, 0, 0},
+ {OP_LINK, "link", link_f, 1, 1, 0},
+ {OP_MKDIR, "mkdir", mkdir_f, 2, 1, 0},
+ {OP_MKNOD, "mknod", mknod_f, 2, 1, 0},
+ {OP_READ, "read", read_f, 1, 0, 0},
+ {OP_READLINK, "readlink", readlink_f, 1, 0, 0},
+ {OP_RENAME, "rename", rename_f, 2, 1, 0},
#ifndef NO_XFS
{OP_RESVSP, "resvsp", resvsp_f, 1, 1, 1},
#endif
- {OP_RMDIR, "rmdir", rmdir_f, 1, 1},
- {OP_STAT, "stat", stat_f, 1, 0},
- {OP_SYMLINK, "symlink", symlink_f, 2, 1},
- {OP_SYNC, "sync", sync_f, 1, 0},
- {OP_TRUNCATE, "truncate", truncate_f, 2, 1},
- {OP_UNLINK, "unlink", unlink_f, 1, 1},
+ {OP_RMDIR, "rmdir", rmdir_f, 1, 1, 0},
+ {OP_STAT, "stat", stat_f, 1, 0, 0},
+ {OP_SYMLINK, "symlink", symlink_f, 2, 1, 0},
+ {OP_SYNC, "sync", sync_f, 1, 0, 0},
+ {OP_TRUNCATE, "truncate", truncate_f, 2, 1, 0},
+ {OP_UNLINK, "unlink", unlink_f, 1, 1, 0},
#ifndef NO_XFS
{OP_UNRESVSP, "unresvsp", unresvsp_f, 1, 1, 1},
#endif
- {OP_WRITE, "write", write_f, 4, 1},
+ {OP_WRITE, "write", write_f, 4, 1, 0},
}, *ops_end;
flist_t flist[FT_nft] = {
--
1.9.3
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c
@ 2014-08-20 2:37 Zorro Lang
2014-09-02 13:21 ` chrubis
0 siblings, 1 reply; 7+ messages in thread
From: Zorro Lang @ 2014-08-20 2:37 UTC (permalink / raw)
To: ltp-list
when compile kernel/fs/fsstress/fsstress.c, some warning always be printed.
Because there is a new field 'isxfs' be added in opdesc_t struct,
but some lines of opdesc_t ops[] forget to init this field.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
Hi,
Ping ...
I have sent my two patch for a long time, but no response until now. If
there are any problems you don't want to merge it, please tell me.
(Re-send this patch again now. )
Thank you,
Zorro Lang
testcases/kernel/fs/fsstress/fsstress.c | 40
++++++++++++++++-----------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/testcases/kernel/fs/fsstress/fsstress.c
b/testcases/kernel/fs/fsstress/fsstress.c
index 4a8a1c2..1783783 100644
--- a/testcases/kernel/fs/fsstress/fsstress.c
+++ b/testcases/kernel/fs/fsstress/fsstress.c
@@ -164,35 +164,35 @@ opdesc_t ops[] = {
{OP_BULKSTAT, "bulkstat", bulkstat_f, 1, 0, 1},
{OP_BULKSTAT1, "bulkstat1", bulkstat1_f, 1, 0, 1},
#endif
- {OP_CHOWN, "chown", chown_f, 3, 1},
- {OP_CREAT, "creat", creat_f, 4, 1},
- {OP_DREAD, "dread", dread_f, 4, 0},
- {OP_DWRITE, "dwrite", dwrite_f, 4, 1},
- {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1},
+ {OP_CHOWN, "chown", chown_f, 3, 1, 0},
+ {OP_CREAT, "creat", creat_f, 4, 1, 0},
+ {OP_DREAD, "dread", dread_f, 4, 0, 0},
+ {OP_DWRITE, "dwrite", dwrite_f, 4, 1, 0},
+ {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1, 0},
#ifndef NO_XFS
{OP_FREESP, "freesp", freesp_f, 1, 1, 1},
#endif
- {OP_FSYNC, "fsync", fsync_f, 1, 1},
- {OP_GETDENTS, "getdents", getdents_f, 1, 0},
- {OP_LINK, "link", link_f, 1, 1},
- {OP_MKDIR, "mkdir", mkdir_f, 2, 1},
- {OP_MKNOD, "mknod", mknod_f, 2, 1},
- {OP_READ, "read", read_f, 1, 0},
- {OP_READLINK, "readlink", readlink_f, 1, 0},
- {OP_RENAME, "rename", rename_f, 2, 1},
+ {OP_FSYNC, "fsync", fsync_f, 1, 1, 0},
+ {OP_GETDENTS, "getdents", getdents_f, 1, 0, 0},
+ {OP_LINK, "link", link_f, 1, 1, 0},
+ {OP_MKDIR, "mkdir", mkdir_f, 2, 1, 0},
+ {OP_MKNOD, "mknod", mknod_f, 2, 1, 0},
+ {OP_READ, "read", read_f, 1, 0, 0},
+ {OP_READLINK, "readlink", readlink_f, 1, 0, 0},
+ {OP_RENAME, "rename", rename_f, 2, 1, 0},
#ifndef NO_XFS
{OP_RESVSP, "resvsp", resvsp_f, 1, 1, 1},
#endif
- {OP_RMDIR, "rmdir", rmdir_f, 1, 1},
- {OP_STAT, "stat", stat_f, 1, 0},
- {OP_SYMLINK, "symlink", symlink_f, 2, 1},
- {OP_SYNC, "sync", sync_f, 1, 0},
- {OP_TRUNCATE, "truncate", truncate_f, 2, 1},
- {OP_UNLINK, "unlink", unlink_f, 1, 1},
+ {OP_RMDIR, "rmdir", rmdir_f, 1, 1, 0},
+ {OP_STAT, "stat", stat_f, 1, 0, 0},
+ {OP_SYMLINK, "symlink", symlink_f, 2, 1, 0},
+ {OP_SYNC, "sync", sync_f, 1, 0, 0},
+ {OP_TRUNCATE, "truncate", truncate_f, 2, 1, 0},
+ {OP_UNLINK, "unlink", unlink_f, 1, 1, 0},
#ifndef NO_XFS
{OP_UNRESVSP, "unresvsp", unresvsp_f, 1, 1, 1},
#endif
- {OP_WRITE, "write", write_f, 4, 1},
+ {OP_WRITE, "write", write_f, 4, 1, 0},
}, *ops_end;
flist_t flist[FT_nft] = {
--
1.9.3
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c
@ 2014-08-12 10:00 Zorro Lang
0 siblings, 0 replies; 7+ messages in thread
From: Zorro Lang @ 2014-08-12 10:00 UTC (permalink / raw)
To: ltp-list
when compile kernel/fs/fsstress/fsstress.c, some warning always be printed.
Because there is a new field 'isxfs' be added in opdesc_t struct,
but some lines of opdesc_t ops[] forget to init this field.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
testcases/kernel/fs/fsstress/fsstress.c | 40 ++++++++++++++++-----------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/testcases/kernel/fs/fsstress/fsstress.c b/testcases/kernel/fs/fsstress/fsstress.c
index 4a8a1c2..1783783 100644
--- a/testcases/kernel/fs/fsstress/fsstress.c
+++ b/testcases/kernel/fs/fsstress/fsstress.c
@@ -164,35 +164,35 @@ opdesc_t ops[] = {
{OP_BULKSTAT, "bulkstat", bulkstat_f, 1, 0, 1},
{OP_BULKSTAT1, "bulkstat1", bulkstat1_f, 1, 0, 1},
#endif
- {OP_CHOWN, "chown", chown_f, 3, 1},
- {OP_CREAT, "creat", creat_f, 4, 1},
- {OP_DREAD, "dread", dread_f, 4, 0},
- {OP_DWRITE, "dwrite", dwrite_f, 4, 1},
- {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1},
+ {OP_CHOWN, "chown", chown_f, 3, 1, 0},
+ {OP_CREAT, "creat", creat_f, 4, 1, 0},
+ {OP_DREAD, "dread", dread_f, 4, 0, 0},
+ {OP_DWRITE, "dwrite", dwrite_f, 4, 1, 0},
+ {OP_FDATASYNC, "fdatasync", fdatasync_f, 1, 1, 0},
#ifndef NO_XFS
{OP_FREESP, "freesp", freesp_f, 1, 1, 1},
#endif
- {OP_FSYNC, "fsync", fsync_f, 1, 1},
- {OP_GETDENTS, "getdents", getdents_f, 1, 0},
- {OP_LINK, "link", link_f, 1, 1},
- {OP_MKDIR, "mkdir", mkdir_f, 2, 1},
- {OP_MKNOD, "mknod", mknod_f, 2, 1},
- {OP_READ, "read", read_f, 1, 0},
- {OP_READLINK, "readlink", readlink_f, 1, 0},
- {OP_RENAME, "rename", rename_f, 2, 1},
+ {OP_FSYNC, "fsync", fsync_f, 1, 1, 0},
+ {OP_GETDENTS, "getdents", getdents_f, 1, 0, 0},
+ {OP_LINK, "link", link_f, 1, 1, 0},
+ {OP_MKDIR, "mkdir", mkdir_f, 2, 1, 0},
+ {OP_MKNOD, "mknod", mknod_f, 2, 1, 0},
+ {OP_READ, "read", read_f, 1, 0, 0},
+ {OP_READLINK, "readlink", readlink_f, 1, 0, 0},
+ {OP_RENAME, "rename", rename_f, 2, 1, 0},
#ifndef NO_XFS
{OP_RESVSP, "resvsp", resvsp_f, 1, 1, 1},
#endif
- {OP_RMDIR, "rmdir", rmdir_f, 1, 1},
- {OP_STAT, "stat", stat_f, 1, 0},
- {OP_SYMLINK, "symlink", symlink_f, 2, 1},
- {OP_SYNC, "sync", sync_f, 1, 0},
- {OP_TRUNCATE, "truncate", truncate_f, 2, 1},
- {OP_UNLINK, "unlink", unlink_f, 1, 1},
+ {OP_RMDIR, "rmdir", rmdir_f, 1, 1, 0},
+ {OP_STAT, "stat", stat_f, 1, 0, 0},
+ {OP_SYMLINK, "symlink", symlink_f, 2, 1, 0},
+ {OP_SYNC, "sync", sync_f, 1, 0, 0},
+ {OP_TRUNCATE, "truncate", truncate_f, 2, 1, 0},
+ {OP_UNLINK, "unlink", unlink_f, 1, 1, 0},
#ifndef NO_XFS
{OP_UNRESVSP, "unresvsp", unresvsp_f, 1, 1, 1},
#endif
- {OP_WRITE, "write", write_f, 4, 1},
+ {OP_WRITE, "write", write_f, 4, 1, 0},
}, *ops_end;
flist_t flist[FT_nft] = {
--
1.9.3
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-03 8:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1409672694-32108-1-git-send-email-zlang@redhat.com>
2014-09-03 7:22 ` [LTP] [PATCH] fs/fsstress: modify compile warning about fsstress.c chrubis
[not found] ` <5406CE2C.5080006@redhat.com>
2014-09-03 8:17 ` chrubis
2014-08-29 7:05 Zorro Lang
-- strict thread matches above, loose matches on Subject: below --
2014-08-20 2:37 Zorro Lang
2014-09-02 13:21 ` chrubis
[not found] ` <5405E5EC.4010406@redhat.com>
2014-09-02 16:00 ` chrubis
2014-08-12 10:00 Zorro Lang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.