From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Erik van Luijk <evanluijk@interact.nl>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node
Date: Wed, 3 Sep 2014 09:09:16 +0200 [thread overview]
Message-ID: <20140903090916.4a624739@bbrezillon> (raw)
In-Reply-To: <5406B098.6020500@interact.nl>
On Wed, 03 Sep 2014 08:09:28 +0200
Erik van Luijk <evanluijk@interact.nl> wrote:
>
> Hi Boris, Nicolas,
>
> Boris BREZILLON schreef op 2-9-2014 om 18:33:
> > Hi Erik,
> >
> > On Tue, 2 Sep 2014 12:52:12 +0200
> > Erik van Luijk <evanluijk@interact.nl> wrote:
> >
> >> Signed-off-by: Erik van Luijk <evanluijk@interact.nl>
> >
> > Except for the nitpicks you'll find below, you have my
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >
> >> ---
> >> arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++
> >> arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++
> >> 2 files changed, 10 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi
> b/arch/arm/boot/dts/at91sam9g45.dtsi
> >> index 932a669..bf62c18 100644
> >> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> >> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> >> @@ -1070,6 +1070,13 @@
> >> status = "disabled";
> >> };
> >>
> >> + rtc@fffffdb0 {
> >> + compatible = "atmel,at91rm9200-rtc";
> >> + reg = <0xfffffdb0 0x30>;
> >
> > The RTC registers goes from 0xfffffdb0 to 0xfffffdc0, which means the
> > size is 0x10 and not 0x30. This is not important here, because the
> > following region is marked as reserved, but we prefer to keep the DT
> > consistent with the datasheet.
>
> This is an inconsistency in the datasheet of the AT91SAM9G45 (and at
> least also
> AT91SAM9G15, AT91SAM9G25, AT91SAM9G35 and AT91SAM9M10).
> In the memory map (fig. 5-1) there is room for 16 bytes.
> But in the 'Real-time Clock (RTC) User Interface' (table 15-1) there is
> room for
> 48 bytes (0x30) excluding the Reserved Registers (which don't belong to
> the RTC
> on the AT91SAM9M10). Perhaps Nicolas can draw some attention to this at
> Atmel.
Indeed, I only had a look at the memory map.
Given this input, you should keep your definition ;-).
>
> >
> >> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> >> + status = "disabled";
> >> + };
> >> +
> >> spi0: spi@fffa4000 {
> >> #address-cells = <1>;
> >> #size-cells = <0>;
> >> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> >> index 96ccc7d..2dd2347 100644
> >> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> >> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> >> @@ -70,6 +70,9 @@
> >>
> >> watchdog@fffffd40 {
> >> status = "okay";
> >> +
> >> + rtc@fffffdb0 {
> >> + status = "okay";
> >
> > Try to keep SoC and board changes in distinct commits.
>
> Understood.
>
> >
> >> };
> >>
> >> mmc0: mmc@fff80000 {
> >
> >
> > Best Regards,
> >
> > Boris
> >
>
> Regards,
>
> Erik
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node
Date: Wed, 3 Sep 2014 09:09:16 +0200 [thread overview]
Message-ID: <20140903090916.4a624739@bbrezillon> (raw)
In-Reply-To: <5406B098.6020500@interact.nl>
On Wed, 03 Sep 2014 08:09:28 +0200
Erik van Luijk <evanluijk@interact.nl> wrote:
>
> Hi Boris, Nicolas,
>
> Boris BREZILLON schreef op 2-9-2014 om 18:33:
> > Hi Erik,
> >
> > On Tue, 2 Sep 2014 12:52:12 +0200
> > Erik van Luijk <evanluijk@interact.nl> wrote:
> >
> >> Signed-off-by: Erik van Luijk <evanluijk@interact.nl>
> >
> > Except for the nitpicks you'll find below, you have my
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >
> >> ---
> >> arch/arm/boot/dts/at91sam9g45.dtsi | 7 +++++++
> >> arch/arm/boot/dts/at91sam9m10g45ek.dts | 3 +++
> >> 2 files changed, 10 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi
> b/arch/arm/boot/dts/at91sam9g45.dtsi
> >> index 932a669..bf62c18 100644
> >> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> >> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> >> @@ -1070,6 +1070,13 @@
> >> status = "disabled";
> >> };
> >>
> >> + rtc at fffffdb0 {
> >> + compatible = "atmel,at91rm9200-rtc";
> >> + reg = <0xfffffdb0 0x30>;
> >
> > The RTC registers goes from 0xfffffdb0 to 0xfffffdc0, which means the
> > size is 0x10 and not 0x30. This is not important here, because the
> > following region is marked as reserved, but we prefer to keep the DT
> > consistent with the datasheet.
>
> This is an inconsistency in the datasheet of the AT91SAM9G45 (and at
> least also
> AT91SAM9G15, AT91SAM9G25, AT91SAM9G35 and AT91SAM9M10).
> In the memory map (fig. 5-1) there is room for 16 bytes.
> But in the 'Real-time Clock (RTC) User Interface' (table 15-1) there is
> room for
> 48 bytes (0x30) excluding the Reserved Registers (which don't belong to
> the RTC
> on the AT91SAM9M10). Perhaps Nicolas can draw some attention to this at
> Atmel.
Indeed, I only had a look at the memory map.
Given this input, you should keep your definition ;-).
>
> >
> >> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> >> + status = "disabled";
> >> + };
> >> +
> >> spi0: spi at fffa4000 {
> >> #address-cells = <1>;
> >> #size-cells = <0>;
> >> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> >> index 96ccc7d..2dd2347 100644
> >> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> >> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> >> @@ -70,6 +70,9 @@
> >>
> >> watchdog at fffffd40 {
> >> status = "okay";
> >> +
> >> + rtc at fffffdb0 {
> >> + status = "okay";
> >
> > Try to keep SoC and board changes in distinct commits.
>
> Understood.
>
> >
> >> };
> >>
> >> mmc0: mmc at fff80000 {
> >
> >
> > Best Regards,
> >
> > Boris
> >
>
> Regards,
>
> Erik
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-03 7:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 10:52 [PATCH] ARM: at91/dt: at91sam9m10g45ek add rtc node Erik van Luijk
2014-09-02 10:52 ` Erik van Luijk
2014-09-02 16:33 ` Boris BREZILLON
2014-09-02 16:33 ` Boris BREZILLON
2014-09-03 6:09 ` Erik van Luijk
2014-09-03 6:09 ` Erik van Luijk
2014-09-03 7:09 ` Boris BREZILLON [this message]
2014-09-03 7:09 ` Boris BREZILLON
2014-09-18 16:17 ` Nicolas Ferre
2014-09-18 16:17 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903090916.4a624739@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=evanluijk@interact.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.