From: Boris BREZILLON <boris.brezillon@free-electrons.com> To: Mike Turquette <mturquette@linaro.org> Cc: "Nicolas Ferre" <nicolas.ferre@atmel.com>, "Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>, "Alexandre Belloni" <alexandre.belloni@free-electrons.com>, "Andrew Victor" <linux@maxim.org.za>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: at91: fix num_parents test in at91sam9260 slow clk implementation Date: Wed, 3 Sep 2014 09:42:50 +0200 [thread overview] Message-ID: <20140903094250.0a5b5154@bbrezillon> (raw) In-Reply-To: <20140902214506.5251.1412@quantum> On Tue, 02 Sep 2014 14:45:06 -0700 Mike Turquette <mturquette@linaro.org> wrote: > Quoting Boris BREZILLON (2014-09-02 08:27:51) > > The slow clk block provided by at91sam9260 and derived SoCs should always > > have 2 parents. > > > > Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com> > > --- > > > > Hello Mike, > > > > Could you take this fix for the next 3.17 rc ? > > Without this fix you won't be able to use programmable clks (the slow > > clk is one of the parents of prog clks), and these prog clks are used, > > among other things, to provide clks to external audio chips. > > > > No need to backport this fix to previous stable releases, as CCF support > > for at91sam9260 (and derived) SoCs only appeared in 3.17. > > Pulled into clk-fixes. Thanks! > > Regards, > Mike > > > > > Best Regards, > > > > Boris > > > > drivers/clk/at91/clk-slow.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/at91/clk-slow.c b/drivers/clk/at91/clk-slow.c > > index 0300c46..32f7c1b 100644 > > --- a/drivers/clk/at91/clk-slow.c > > +++ b/drivers/clk/at91/clk-slow.c > > @@ -447,7 +447,7 @@ void __init of_at91sam9260_clk_slow_setup(struct device_node *np, > > int i; > > > > num_parents = of_count_phandle_with_args(np, "clocks", "#clock-cells"); > > - if (num_parents <= 0 || num_parents > 1) > > + if (num_parents != 2) > > return; > > > > for (i = 0; i < num_parents; ++i) { > > -- > > 1.9.1 > > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris BREZILLON) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] clk: at91: fix num_parents test in at91sam9260 slow clk implementation Date: Wed, 3 Sep 2014 09:42:50 +0200 [thread overview] Message-ID: <20140903094250.0a5b5154@bbrezillon> (raw) In-Reply-To: <20140902214506.5251.1412@quantum> On Tue, 02 Sep 2014 14:45:06 -0700 Mike Turquette <mturquette@linaro.org> wrote: > Quoting Boris BREZILLON (2014-09-02 08:27:51) > > The slow clk block provided by at91sam9260 and derived SoCs should always > > have 2 parents. > > > > Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com> > > --- > > > > Hello Mike, > > > > Could you take this fix for the next 3.17 rc ? > > Without this fix you won't be able to use programmable clks (the slow > > clk is one of the parents of prog clks), and these prog clks are used, > > among other things, to provide clks to external audio chips. > > > > No need to backport this fix to previous stable releases, as CCF support > > for at91sam9260 (and derived) SoCs only appeared in 3.17. > > Pulled into clk-fixes. Thanks! > > Regards, > Mike > > > > > Best Regards, > > > > Boris > > > > drivers/clk/at91/clk-slow.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/at91/clk-slow.c b/drivers/clk/at91/clk-slow.c > > index 0300c46..32f7c1b 100644 > > --- a/drivers/clk/at91/clk-slow.c > > +++ b/drivers/clk/at91/clk-slow.c > > @@ -447,7 +447,7 @@ void __init of_at91sam9260_clk_slow_setup(struct device_node *np, > > int i; > > > > num_parents = of_count_phandle_with_args(np, "clocks", "#clock-cells"); > > - if (num_parents <= 0 || num_parents > 1) > > + if (num_parents != 2) > > return; > > > > for (i = 0; i < num_parents; ++i) { > > -- > > 1.9.1 > > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
next prev parent reply other threads:[~2014-09-03 7:42 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-02 15:27 [PATCH] clk: at91: fix num_parents test in at91sam9260 slow clk implementation Boris BREZILLON 2014-09-02 15:27 ` Boris BREZILLON 2014-09-02 21:45 ` Mike Turquette 2014-09-02 21:45 ` Mike Turquette 2014-09-03 7:42 ` Boris BREZILLON [this message] 2014-09-03 7:42 ` Boris BREZILLON
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140903094250.0a5b5154@bbrezillon \ --to=boris.brezillon@free-electrons.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@maxim.org.za \ --cc=mturquette@linaro.org \ --cc=nicolas.ferre@atmel.com \ --cc=plagnioj@jcrosoft.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.