[ANNOUNCE] util-linux v2.25.1

[ANNOUNCE] util-linux v2.25.1

[Karel Zak]

The util-linux stable release v2.25.1 is available at

    ftp://ftp.kernel.org/pub/linux/utils/util-linux/v2.25

Feedback and bug reports, as always, are welcomed.

  Karel


Util-linux 2.25.1 Release Notes
===============================

build-sys:
   - create parent directory for $(PATHFILES)  [Michael Marineau]
   - fix double prefix with explict --libdir  [Christoph Junghans]
   - fix switch_root/pivot_root cut-n-paste error in configure.ac  [Andreas Henriksson]
   - release++ (v2.25.1-rc1)  [Karel Zak]
cfdisk:
   - fix typo in the previous commit  [Karel Zak]
   - reenable cursor when quitting  [Karel Zak]
   - wrong interpretation of yes in non-english language  [Karel Zak]
docs:
   - update AUTHORS file  [Karel Zak]
   - update v2.25.1-ReleaseNotes  [Karel Zak]
fdisk:
   - always print warning for mis-aligned partitions  [Karel Zak]
   - fix -l [<device>]  [Karel Zak]
   - update tests and clean up output  [Karel Zak]
hexdump:
   - Fix parse format of "byte count without repetition count"  [HUANG Wei]
hwclock:
   - check for permissions before use clock interface  [Karel Zak]
   - use pluralized translations.  [Lauri Nurmi]
libblkid:
   - (gpt) fix PT offset  [Karel Zak]
   - (gpt) use real sector size to set PTMAGIC_OFFSET  [Karel Zak]
libfdisk:
   - (dos) fix logical partitions add/delete code  [Karel Zak]
   - (gpt) add Microsoft Storage Spaces GUID  [Sergei Antonov]
   - (gpt) allow to specify attr bit by API  [Karel Zak]
libmount:
   - use -t for type.subtype in helpers API  [Karel Zak]
lscpu:
   - clean up vmware inline asm  [Mike Frysinger]
mcookie:
   - avoid format warning  [Bernhard Voelker]
more:
   - replace ad-hoc support for plurals with gettext plurals.  [Lauri Nurmi]
po:
   - merge changes  [Karel Zak]
   - update cs.po (from translationproject.org)  [Petr Písař]
   - update da.po (from translationproject.org)  [Joe Hansen]
   - update de.po (from translationproject.org)  [Mario Blättermann]
   - update es.po (from translationproject.org)  [Antonio Ceballos Roa]
   - update fr.po (from translationproject.org)  [David Prévot]
   - update nl.po (from translationproject.org)  [Benno Schulenberg]
   - update pl.po (from translationproject.org)  [Jakub Bogusz]
   - update pt_BR.po (from translationproject.org)  [Rafael Ferreira]
   - update uk.po (from translationproject.org)  [Yuri Chornoivan]
   - update vi.po (from translationproject.org)  [Trần Ngọc Quân]
   - update zh_CN.po (from translationproject.org)  [Wylmer Wang]
   - update zh_TW.po (from translationproject.org)  [Wei-Lun Chao]
sfdisk:
   - use pluralized translation.  [Lauri Nurmi]
swapon:
   - remove invalid error string print outs  [Sami Kerola]
tests:
   - Fall back on host/getent in ts_resolve_host  [Andreas Henriksson]
   - allow non-inotify tailf to keep up  [Andreas Henriksson]
   - apply travis clang PATH workaround  [Sami Kerola]
   - fix fdisk/bsd for the two possible sectors/offsets  [Aurelien Jarno]
   - kill output message change  [Sami Kerola]
   - make ipcs limit calculations work when numbers are large  [Sami Kerola]
textual:
   - fix some typos and inconsistencies in various messages  [Benno Schulenberg]
   - remove some inconsistent periods from error messages  [Benno Schulenberg]
various:
   - erase all traces of the long-obsolete xiafs  [Benno Schulenberg]

- erase all traces of the long-obsolete xiafs  [Benno Schulenberg]

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

[ANNOUNCE] util-linux v2.25.1

[Karel Zak]

The util-linux stable release v2.25.1 is available at

    ftp://ftp.kernel.org/pub/linux/utils/util-linux/v2.25

Feedback and bug reports, as always, are welcomed.

  Karel


Util-linux 2.25.1 Release Notes
===============================

build-sys:
   - create parent directory for $(PATHFILES)  [Michael Marineau]
   - fix double prefix with explict --libdir  [Christoph Junghans]
   - fix switch_root/pivot_root cut-n-paste error in configure.ac  [Andreas Henriksson]
   - release++ (v2.25.1-rc1)  [Karel Zak]
cfdisk:
   - fix typo in the previous commit  [Karel Zak]
   - reenable cursor when quitting  [Karel Zak]
   - wrong interpretation of yes in non-english language  [Karel Zak]
docs:
   - update AUTHORS file  [Karel Zak]
   - update v2.25.1-ReleaseNotes  [Karel Zak]
fdisk:
   - always print warning for mis-aligned partitions  [Karel Zak]
   - fix -l [<device>]  [Karel Zak]
   - update tests and clean up output  [Karel Zak]
hexdump:
   - Fix parse format of "byte count without repetition count"  [HUANG Wei]
hwclock:
   - check for permissions before use clock interface  [Karel Zak]
   - use pluralized translations.  [Lauri Nurmi]
libblkid:
   - (gpt) fix PT offset  [Karel Zak]
   - (gpt) use real sector size to set PTMAGIC_OFFSET  [Karel Zak]
libfdisk:
   - (dos) fix logical partitions add/delete code  [Karel Zak]
   - (gpt) add Microsoft Storage Spaces GUID  [Sergei Antonov]
   - (gpt) allow to specify attr bit by API  [Karel Zak]
libmount:
   - use -t for type.subtype in helpers API  [Karel Zak]
lscpu:
   - clean up vmware inline asm  [Mike Frysinger]
mcookie:
   - avoid format warning  [Bernhard Voelker]
more:
   - replace ad-hoc support for plurals with gettext plurals.  [Lauri Nurmi]
po:
   - merge changes  [Karel Zak]
   - update cs.po (from translationproject.org)  [Petr Písař]
   - update da.po (from translationproject.org)  [Joe Hansen]
   - update de.po (from translationproject.org)  [Mario Blättermann]
   - update es.po (from translationproject.org)  [Antonio Ceballos Roa]
   - update fr.po (from translationproject.org)  [David Prévot]
   - update nl.po (from translationproject.org)  [Benno Schulenberg]
   - update pl.po (from translationproject.org)  [Jakub Bogusz]
   - update pt_BR.po (from translationproject.org)  [Rafael Ferreira]
   - update uk.po (from translationproject.org)  [Yuri Chornoivan]
   - update vi.po (from translationproject.org)  [Trần Ngọc Quân]
   - update zh_CN.po (from translationproject.org)  [Wylmer Wang]
   - update zh_TW.po (from translationproject.org)  [Wei-Lun Chao]
sfdisk:
   - use pluralized translation.  [Lauri Nurmi]
swapon:
   - remove invalid error string print outs  [Sami Kerola]
tests:
   - Fall back on host/getent in ts_resolve_host  [Andreas Henriksson]
   - allow non-inotify tailf to keep up  [Andreas Henriksson]
   - apply travis clang PATH workaround  [Sami Kerola]
   - fix fdisk/bsd for the two possible sectors/offsets  [Aurelien Jarno]
   - kill output message change  [Sami Kerola]
   - make ipcs limit calculations work when numbers are large  [Sami Kerola]
textual:
   - fix some typos and inconsistencies in various messages  [Benno Schulenberg]
   - remove some inconsistent periods from error messages  [Benno Schulenberg]
various:
   - erase all traces of the long-obsolete xiafs  [Benno Schulenberg]

- erase all traces of the long-obsolete xiafs  [Benno Schulenberg]

-- 
 Karel Zak  <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] util-linux v2.25.1

[Adam Sampson]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

On Wed, Sep 03, 2014 at 12:54:27PM +0200, Karel Zak wrote:
>    - make ipcs limit calculations work when numbers are large

That change isn't right -- it reverses the sense of the test, making the
testcase fail on 3.16 again. Patch attached.

Thanks,

-- 
Adam Sampson <ats@offog.org>                         <http://offog.org/>

[-- Attachment #2: 0001-Fix-the-test-for-shmall-being-too-big-to-show.patch --]
[-- Type: text/plain, Size: 929 bytes --]

>From 1269b6bb74727043c16852bc34727a0c8d0696c7 Mon Sep 17 00:00:00 2001
From: Adam Sampson <ats@offog.org>
Date: Wed, 3 Sep 2014 16:49:40 +0100
Subject: [PATCH] Fix the test for shmall being too big to show.

It was correct when originally introduced, but the shell overflow fix in
3a9ec12d6664527fad9c56347c88f3447d6c0856 accidentally reversed the sense
of the test.

Signed-off-by: Adam Sampson <ats@offog.org>
---
 tests/ts/ipcs/limits2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/ts/ipcs/limits2 b/tests/ts/ipcs/limits2
index 1a49c46..19f49fb 100755
--- a/tests/ts/ipcs/limits2
+++ b/tests/ts/ipcs/limits2
@@ -29,7 +29,7 @@ ts_check_prog "bc"
 
 # TODO https://github.com/karelzak/util-linux/issues/51
 SHMALL=$(</proc/sys/kernel/shmall)
-if [ $(bc <<<"2^64 / $PAGE_SIZE < $SHMALL") -ne 1 ]; then
+if [ $(bc <<<"2^64 / $PAGE_SIZE < $SHMALL") -eq 1 ]; then
 	TS_KNOWN_FAIL="yes"
 fi
 
-- 
2.0.4

Re: [ANNOUNCE] util-linux v2.25.1

[Ruediger Meier]

On Wednesday 03 September 2014, Adam Sampson wrote:
> On Wed, Sep 03, 2014 at 12:54:27PM +0200, Karel Zak wrote:
> >    - make ipcs limit calculations work when numbers are large
>
> That change isn't right -- it reverses the sense of the test, making
> the testcase fail on 3.16 again. Patch attached.

Your patch seems to be correct except that it should be "<=" instead 
of "<":
  if [ $(bc <<<"2^64 / $PAGE_SIZE <= $SHMALL") -eq 1 ]; then
to have the same (correct) behavior like before 3a9ec12d.

The mistake in 3a9ec12d happened probably because Sami tried to 
avoid "greater than" relations. but for my brain this line would be 
still more easy to read:
  if [ $(bc <<<"$SHMALL >= 2^64 / $PAGE_SIZE") -eq 1 ]; then
Maybe that's why me and others have not noticed the mistake when 
reviewing that patch.

cu,
Rudi

Re: [ANNOUNCE] util-linux v2.25.1

[Karel Zak]

On Sat, Sep 06, 2014 at 10:51:58AM +0200, Ruediger Meier wrote:
> It still must be "<=":
> +if [ $(bc <<<"(2^64 / $PAGE_SIZE) <= $SHMALL") -eq 1 ]; then

 Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [ANNOUNCE] util-linux v2.25.1

[Ruediger Meier]

On Saturday 06 September 2014, Sami Kerola wrote:
> On 3 September 2014 23:19, Ruediger Meier <sweet_f_a@gmx.de> wrote:
> > On Wednesday 03 September 2014, Adam Sampson wrote:
> >> On Wed, Sep 03, 2014 at 12:54:27PM +0200, Karel Zak wrote:
> >> >    - make ipcs limit calculations work when numbers are large
> >>
> >> That change isn't right -- it reverses the sense of the test,
> >> making the testcase fail on 3.16 again. Patch attached.
> >
> > Your patch seems to be correct except that it should be "<="
> > instead of "<":
> >   if [ $(bc <<<"2^64 / $PAGE_SIZE <= $SHMALL") -eq 1 ]; then
> > to have the same (correct) behavior like before 3a9ec12d.
> >
> > The mistake in 3a9ec12d happened probably because Sami tried to
> > avoid "greater than" relations. but for my brain this line would be
> > still more easy to read:
> >   if [ $(bc <<<"$SHMALL >= 2^64 / $PAGE_SIZE") -eq 1 ]; then
> > Maybe that's why me and others have not noticed the mistake when
> > reviewing that patch.
>
> Hi Adam, Rudi, and others,
>
> It was not good summer for me.  This is second totally stupid bug
> from me.  This time the reason is I tested the logic by flipping it
> around to see it works, and accidentally wrong version end up to
> submission.
>
> Here is the change from Adams attachment, with CC and Reviewed-by
> lines, and round braces to ensure bc does calculation always in
> correct order.
>
> --->8----
> From: Adam Sampson <ats@offog.org>
> Date: Wed, 3 Sep 2014 16:49:40 +0100
> Subject: tests: fix the ipcs test for shmall being too big to show
>
> It was correct when originally introduced, but the shell overflow fix
> in 3a9ec12d6664527fad9c56347c88f3447d6c0856 accidentally reversed the
> sense of the test.
>
> CC: Ruediger Meier <sweet_f_a@gmx.de>
> Reviewed-by: Sami Kerola <kerolasa@iki.if>
> Signed-off-by: Adam Sampson <ats@offog.org>
> ---
>  tests/ts/ipcs/limits2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/ts/ipcs/limits2 b/tests/ts/ipcs/limits2
> index 1a49c46..10f7514 100755
> --- a/tests/ts/ipcs/limits2
> +++ b/tests/ts/ipcs/limits2
> @@ -29,7 +29,7 @@ ts_check_prog "bc"
>
>  # TODO https://github.com/karelzak/util-linux/issues/51
>  SHMALL=$(</proc/sys/kernel/shmall)
> -if [ $(bc <<<"2^64 / $PAGE_SIZE < $SHMALL") -ne 1 ]; then
> +if [ $(bc <<<"(2^64 / $PAGE_SIZE) < $SHMALL") -eq 1 ]; then

It still must be "<=":
+if [ $(bc <<<"(2^64 / $PAGE_SIZE) <= $SHMALL") -eq 1 ]; then

You can test the logic like this on any x86_64 system (assuming page 
size 4096):

$ sudo sh -c "echo 4503599627370496 > /proc/sys/kernel/shmall"
$ make check TS_OPTS='ipcs'

4503599627370496 (= 2^64 / 4096) is the smallest value where our ipcs 
binary fails (issue #51).

>  	TS_KNOWN_FAIL="yes"
>  fi


cu,
Rudi

Re: [ANNOUNCE] util-linux v2.25.1

[Sami Kerola]

On 3 September 2014 23:19, Ruediger Meier <sweet_f_a@gmx.de> wrote:
> On Wednesday 03 September 2014, Adam Sampson wrote:
>> On Wed, Sep 03, 2014 at 12:54:27PM +0200, Karel Zak wrote:
>> >    - make ipcs limit calculations work when numbers are large
>>
>> That change isn't right -- it reverses the sense of the test, making
>> the testcase fail on 3.16 again. Patch attached.
>
> Your patch seems to be correct except that it should be "<=" instead
> of "<":
>   if [ $(bc <<<"2^64 / $PAGE_SIZE <= $SHMALL") -eq 1 ]; then
> to have the same (correct) behavior like before 3a9ec12d.
>
> The mistake in 3a9ec12d happened probably because Sami tried to
> avoid "greater than" relations. but for my brain this line would be
> still more easy to read:
>   if [ $(bc <<<"$SHMALL >= 2^64 / $PAGE_SIZE") -eq 1 ]; then
> Maybe that's why me and others have not noticed the mistake when
> reviewing that patch.

Hi Adam, Rudi, and others,

It was not good summer for me.  This is second totally stupid bug from
me.  This time the reason is I tested the logic by flipping it around to
see it works, and accidentally wrong version end up to submission.

Here is the change from Adams attachment, with CC and Reviewed-by lines,
and round braces to ensure bc does calculation always in correct order.

--->8----
From: Adam Sampson <ats@offog.org>
Date: Wed, 3 Sep 2014 16:49:40 +0100
Subject: tests: fix the ipcs test for shmall being too big to show

It was correct when originally introduced, but the shell overflow fix in
3a9ec12d6664527fad9c56347c88f3447d6c0856 accidentally reversed the sense
of the test.

CC: Ruediger Meier <sweet_f_a@gmx.de>
Reviewed-by: Sami Kerola <kerolasa@iki.if>
Signed-off-by: Adam Sampson <ats@offog.org>
---
 tests/ts/ipcs/limits2 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/ts/ipcs/limits2 b/tests/ts/ipcs/limits2
index 1a49c46..10f7514 100755
--- a/tests/ts/ipcs/limits2
+++ b/tests/ts/ipcs/limits2
@@ -29,7 +29,7 @@ ts_check_prog "bc"
 
 # TODO https://github.com/karelzak/util-linux/issues/51
 SHMALL=$(</proc/sys/kernel/shmall)
-if [ $(bc <<<"2^64 / $PAGE_SIZE < $SHMALL") -ne 1 ]; then
+if [ $(bc <<<"(2^64 / $PAGE_SIZE) < $SHMALL") -eq 1 ]; then
 	TS_KNOWN_FAIL="yes"
 fi
 
-- 
2.1.0