From: Peter Zijlstra <peterz@infradead.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: mingo@redhat.com, dzickus@redhat.com, bmr@redhat.com,
jcastillo@redhat.com, oleg@redhat.com, pzijlstr@redhat.com,
riel@redhat.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, x86@kernel.org, rostedt@goodmis.org,
hannes@cmpxchg.org, aneesh.kumar@linux.vnet.ibm.com,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
minchan@kernel.org
Subject: Re: [PATCH 1/2] sched: Add helper for task stack page overrun checking
Date: Thu, 4 Sep 2014 17:30:47 +0200 [thread overview]
Message-ID: <20140904153047.GD346@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1409842224-11847-2-git-send-email-atomlin@redhat.com>
On Thu, Sep 04, 2014 at 03:50:23PM +0100, Aaron Tomlin wrote:
> @@ -537,8 +535,8 @@ void bad_page_fault(struct pt_regs *regs, unsigned long address, int sig)
> printk(KERN_ALERT "Faulting instruction address: 0x%08lx\n",
> regs->nip);
>
> - stackend = end_of_stack(current);
> - if (current != &init_task && *stackend != STACK_END_MAGIC)
> + if (current != &init_task &&
> + task_stack_end_corrupted(current))
superfluous linebreak.
> @@ -2614,6 +2615,8 @@ static inline unsigned long *end_of_stack(struct task_struct *p)
> }
>
> #endif
Here otoh we could do with some extra whitespace
> @@ -171,8 +170,8 @@ check_stack(unsigned long ip, unsigned long *stack)
> i++;
> }
>
> - if ((current != &init_task &&
> - *(end_of_stack(current)) != STACK_END_MAGIC)) {
> + if (current != &init_task &&
> + task_stack_end_corrupted(current)) {
Again, superfluous linebreak.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: dzickus@redhat.com, jcastillo@redhat.com, riel@redhat.com,
bmr@redhat.com, x86@kernel.org, oleg@redhat.com,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
minchan@kernel.org, mingo@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, hannes@cmpxchg.org,
tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org,
akpm@linux-foundation.org, pzijlstr@redhat.com
Subject: Re: [PATCH 1/2] sched: Add helper for task stack page overrun checking
Date: Thu, 4 Sep 2014 17:30:47 +0200 [thread overview]
Message-ID: <20140904153047.GD346@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1409842224-11847-2-git-send-email-atomlin@redhat.com>
On Thu, Sep 04, 2014 at 03:50:23PM +0100, Aaron Tomlin wrote:
> @@ -537,8 +535,8 @@ void bad_page_fault(struct pt_regs *regs, unsigned long address, int sig)
> printk(KERN_ALERT "Faulting instruction address: 0x%08lx\n",
> regs->nip);
>
> - stackend = end_of_stack(current);
> - if (current != &init_task && *stackend != STACK_END_MAGIC)
> + if (current != &init_task &&
> + task_stack_end_corrupted(current))
superfluous linebreak.
> @@ -2614,6 +2615,8 @@ static inline unsigned long *end_of_stack(struct task_struct *p)
> }
>
> #endif
Here otoh we could do with some extra whitespace
> @@ -171,8 +170,8 @@ check_stack(unsigned long ip, unsigned long *stack)
> i++;
> }
>
> - if ((current != &init_task &&
> - *(end_of_stack(current)) != STACK_END_MAGIC)) {
> + if (current != &init_task &&
> + task_stack_end_corrupted(current)) {
Again, superfluous linebreak.
next prev parent reply other threads:[~2014-09-04 15:30 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 14:50 [PATCH 0/2] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-04 14:50 ` Aaron Tomlin
2014-09-04 14:50 ` [PATCH 1/2] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-04 14:50 ` Aaron Tomlin
2014-09-04 15:02 ` Oleg Nesterov
2014-09-04 15:02 ` Oleg Nesterov
2014-09-04 15:52 ` Aaron Tomlin
2014-09-04 15:52 ` Aaron Tomlin
2014-09-04 15:30 ` Peter Zijlstra [this message]
2014-09-04 15:30 ` Peter Zijlstra
2014-09-04 14:50 ` [PATCH 2/2] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-04 14:50 ` Aaron Tomlin
2014-09-04 15:32 ` Peter Zijlstra
2014-09-04 15:32 ` Peter Zijlstra
2014-09-04 16:11 ` Aaron Tomlin
2014-09-04 16:11 ` Aaron Tomlin
2014-09-08 19:23 ` [PATCH v2 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-08 19:23 ` Aaron Tomlin
2014-09-08 19:23 ` [PATCH 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-08 19:23 ` Aaron Tomlin
2014-09-08 19:23 ` [PATCH 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-08 19:23 ` Aaron Tomlin
2014-09-08 19:23 ` [PATCH 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-08 19:23 ` Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-09 9:42 ` Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-09 9:42 ` Aaron Tomlin
2014-09-10 7:26 ` Chuck Ebbert
2014-09-10 7:26 ` Chuck Ebbert
2014-09-10 13:29 ` Aaron Tomlin
2014-09-10 13:29 ` Aaron Tomlin
2014-09-11 12:23 ` Chuck Ebbert
2014-09-11 12:23 ` Chuck Ebbert
2014-09-11 14:47 ` Aaron Tomlin
2014-09-11 14:47 ` Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-09 9:42 ` Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-09 9:42 ` Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-11 15:41 ` Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-11 15:41 ` Aaron Tomlin
2014-09-12 7:28 ` Michael Ellerman
2014-09-12 7:28 ` Michael Ellerman
2014-09-11 15:41 ` [PATCH v3 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-11 15:41 ` Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-11 15:41 ` Aaron Tomlin
2014-09-12 4:06 ` Michael Ellerman
2014-09-12 4:06 ` Michael Ellerman
2014-09-12 9:44 ` Aaron Tomlin
2014-09-12 9:44 ` Aaron Tomlin
2014-09-12 10:58 ` Mike Galbraith
2014-09-12 10:58 ` Mike Galbraith
2014-09-15 2:39 ` Michael Ellerman
2014-09-15 2:39 ` Michael Ellerman
2014-09-12 6:04 ` Michael Ellerman
2014-09-12 6:04 ` Michael Ellerman
2014-09-12 9:50 ` Aaron Tomlin
2014-09-12 9:50 ` Aaron Tomlin
2014-09-11 15:53 ` [PATCH v3 0/3] sched: Always check the integrity of the canary Peter Zijlstra
2014-09-11 15:53 ` Peter Zijlstra
2014-09-11 15:59 ` Aaron Tomlin
2014-09-11 15:59 ` Aaron Tomlin
2014-09-11 16:02 ` David Laight
2014-09-11 16:02 ` David Laight
2014-09-11 17:26 ` Chuck Ebbert
2014-09-11 17:26 ` Chuck Ebbert
2014-09-12 8:43 ` David Laight
2014-09-12 8:43 ` David Laight
2014-09-11 17:44 ` Aaron Tomlin
2014-09-11 17:44 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904153047.GD346@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=atomlin@redhat.com \
--cc=bmr@redhat.com \
--cc=dzickus@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jcastillo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=pzijlstr@redhat.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.