[PATCH net-next] dp83640: Make use of skb_queue_purge instead of reimplementing the code

[PATCH net-next] dp83640: Make use of skb_queue_purge instead of reimplementing the code

[Alexander Duyck]

This change makes it so that dp83640_remove can use skb_queue_purge
instead of looping through itself to flush any entries out of the queue.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
 drivers/net/phy/dp83640.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 87648b3..99b5d20 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1136,7 +1136,6 @@ static void dp83640_remove(struct phy_device *phydev)
 	struct dp83640_clock *clock;
 	struct list_head *this, *next;
 	struct dp83640_private *tmp, *dp83640 = phydev->priv;
-	struct sk_buff *skb;
 
 	if (phydev->addr == BROADCAST_ADDR)
 		return;
@@ -1144,11 +1143,8 @@ static void dp83640_remove(struct phy_device *phydev)
 	enable_status_frames(phydev, false);
 	cancel_work_sync(&dp83640->ts_work);
 
-	while ((skb = skb_dequeue(&dp83640->rx_queue)) != NULL)
-		kfree_skb(skb);
-
-	while ((skb = skb_dequeue(&dp83640->tx_queue)) != NULL)
-		kfree_skb(skb);
+	skb_queue_purge(&dp83640->rx_queue);
+	skb_queue_purge(&dp83640->tx_queue);
 
 	clock = dp83640_clock_get(dp83640->clock);
 

Re: [PATCH net-next] dp83640: Make use of skb_queue_purge instead of reimplementing the code

[Richard Cochran]

On Mon, Sep 08, 2014 at 11:25:34AM -0400, Alexander Duyck wrote:
> This change makes it so that dp83640_remove can use skb_queue_purge
> instead of looping through itself to flush any entries out of the queue.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>

Acked-by: Richard Cochran <richardcochran@gmail.com>

Re: [PATCH net-next] dp83640: Make use of skb_queue_purge instead of reimplementing the code

[David Miller]

From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Mon, 08 Sep 2014 11:25:34 -0400

> This change makes it so that dp83640_remove can use skb_queue_purge
> instead of looping through itself to flush any entries out of the queue.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>

Applied, thanks Alex.