All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Chrysostomos Nanakos <cnanakos@grnet.gr>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 1/2] block/archipelago: Implement bdrv_truncate()
Date: Wed, 10 Sep 2014 10:32:00 +0200	[thread overview]
Message-ID: <20140910083200.GB4052@noname.str.redhat.com> (raw)
In-Reply-To: <54100AF2.7000405@grnet.gr>

Am 10.09.2014 um 10:25 hat Chrysostomos Nanakos geschrieben:
> On 09/10/2014 11:20 AM, Kevin Wolf wrote:
> >Am 09.09.2014 um 19:38 hat Chrysostomos Nanakos geschrieben:
> >>Signed-off-by: Chrysostomos Nanakos <cnanakos@grnet.gr>
> >>---
> >>  block/archipelago.c |   63 +++++++++++++++++++++++++++++++++++++++++++++++++--
> >>  1 file changed, 61 insertions(+), 2 deletions(-)
> >Thanks, applied all to the block branch.
> >
> >Can you please add a cover letter (the [PATCH 0/n] mail as produced by
> >the --cover-letter option in git format-patch) for your next series?
> >
> >Kevin
> Yes of course, removed it in the last minute thinking that it was
> only two commits and there was no need for a cover letter.

No big deal, but besides having combined diffstats, it also allows
distinguishing between comments on the first patch and comments on the
whole series, so I prefer to have it when it's more than one patch.

Of course, you don't have to actually write a description for the cover
letter for such a small series, the automatically generated stuff is
good enough.

Kevin

      reply	other threads:[~2014-09-10  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 17:38 [Qemu-devel] [PATCH v1 1/2] block/archipelago: Implement bdrv_truncate() Chrysostomos Nanakos
2014-09-09 17:38 ` [Qemu-devel] [PATCH v1 2/2] qemu-iotests: Run 025 for Archipelago block driver Chrysostomos Nanakos
2014-09-10  8:20 ` [Qemu-devel] [PATCH v1 1/2] block/archipelago: Implement bdrv_truncate() Kevin Wolf
2014-09-10  8:25   ` Chrysostomos Nanakos
2014-09-10  8:32     ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910083200.GB4052@noname.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=cnanakos@grnet.gr \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.