All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Johan Hovold <johan@kernel.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Andrew Victor <linux@maxim.org.za>,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] rtc: at91sam9: add DT bindings documentation
Date: Wed, 10 Sep 2014 17:07:02 +0200	[thread overview]
Message-ID: <20140910150702.GK2974@localhost> (raw)
In-Reply-To: <20140910152019.111c4c01@bbrezillon>

On Wed, Sep 10, 2014 at 03:20:19PM +0200, Boris BREZILLON wrote:
> On Wed, 10 Sep 2014 14:14:24 +0200
> Johan Hovold <johan@kernel.org> wrote:

> > This does not describe the hardware, but rather a specific software
> > configuration.
> > 
> > The RTT is first of all not an RTC (although it can be used as one in a
> > specific software configuration). And the second register resource above
> > is not an RTT register, but a general-purpose backup register could be
> > used for other purposes (which register to use is currently configurable
> > for legacy booting using CONFIG_RTC_DRV_AT91SAM9_GPBR).
> 
> We could use a syscon device (which exposes a regmap) for the GPBR
> block.
> 
> rtc@ffffff20 {

rtt

> 	compatible = "atmel,at91sam9260-rtt";
> 	reg = <0xfffffd20 0x10>;
> 	interrupts = <1 4 7>;
> 	clocks = <&clk32k>;
> 	atmel,time-reg = <&gpbr 0x0>;
> };
> 
> gpbr: syscon@fffffd50 {
> 	compatible = "atmel,at91sam9260-gpbr", "syscon";
> 	reg = <0xfffffd50 0x10>;
> 	
> };

Yes, this essentially what I suggested in the thread (and my last reply)
and relying on syscon rather than a custom driver seems like a good
idea. It would allow early access to the registers too with the recently
proposed changes. It would not guarantee any kind of exclusivity,
though, but I guess that's tolerable?

Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Boris BREZILLON
	<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Nicolas Ferre
	<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
	Jean-Christophe Plagniol-Villard
	<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org>,
	Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] rtc: at91sam9: add DT bindings documentation
Date: Wed, 10 Sep 2014 17:07:02 +0200	[thread overview]
Message-ID: <20140910150702.GK2974@localhost> (raw)
In-Reply-To: <20140910152019.111c4c01@bbrezillon>

On Wed, Sep 10, 2014 at 03:20:19PM +0200, Boris BREZILLON wrote:
> On Wed, 10 Sep 2014 14:14:24 +0200
> Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:

> > This does not describe the hardware, but rather a specific software
> > configuration.
> > 
> > The RTT is first of all not an RTC (although it can be used as one in a
> > specific software configuration). And the second register resource above
> > is not an RTT register, but a general-purpose backup register could be
> > used for other purposes (which register to use is currently configurable
> > for legacy booting using CONFIG_RTC_DRV_AT91SAM9_GPBR).
> 
> We could use a syscon device (which exposes a regmap) for the GPBR
> block.
> 
> rtc@ffffff20 {

rtt

> 	compatible = "atmel,at91sam9260-rtt";
> 	reg = <0xfffffd20 0x10>;
> 	interrupts = <1 4 7>;
> 	clocks = <&clk32k>;
> 	atmel,time-reg = <&gpbr 0x0>;
> };
> 
> gpbr: syscon@fffffd50 {
> 	compatible = "atmel,at91sam9260-gpbr", "syscon";
> 	reg = <0xfffffd50 0x10>;
> 	
> };

Yes, this essentially what I suggested in the thread (and my last reply)
and relying on syscon rather than a custom driver seems like a good
idea. It would allow early access to the registers too with the recently
proposed changes. It would not guarantee any kind of exclusivity,
though, but I guess that's tolerable?

Johan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] rtc: at91sam9: add DT bindings documentation
Date: Wed, 10 Sep 2014 17:07:02 +0200	[thread overview]
Message-ID: <20140910150702.GK2974@localhost> (raw)
In-Reply-To: <20140910152019.111c4c01@bbrezillon>

On Wed, Sep 10, 2014 at 03:20:19PM +0200, Boris BREZILLON wrote:
> On Wed, 10 Sep 2014 14:14:24 +0200
> Johan Hovold <johan@kernel.org> wrote:

> > This does not describe the hardware, but rather a specific software
> > configuration.
> > 
> > The RTT is first of all not an RTC (although it can be used as one in a
> > specific software configuration). And the second register resource above
> > is not an RTT register, but a general-purpose backup register could be
> > used for other purposes (which register to use is currently configurable
> > for legacy booting using CONFIG_RTC_DRV_AT91SAM9_GPBR).
> 
> We could use a syscon device (which exposes a regmap) for the GPBR
> block.
> 
> rtc at ffffff20 {

rtt

> 	compatible = "atmel,at91sam9260-rtt";
> 	reg = <0xfffffd20 0x10>;
> 	interrupts = <1 4 7>;
> 	clocks = <&clk32k>;
> 	atmel,time-reg = <&gpbr 0x0>;
> };
> 
> gpbr: syscon at fffffd50 {
> 	compatible = "atmel,at91sam9260-gpbr", "syscon";
> 	reg = <0xfffffd50 0x10>;
> 	
> };

Yes, this essentially what I suggested in the thread (and my last reply)
and relying on syscon rather than a custom driver seems like a good
idea. It would allow early access to the registers too with the recently
proposed changes. It would not guarantee any kind of exclusivity,
though, but I guess that's tolerable?

Johan

  reply	other threads:[~2014-09-10 15:09 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  8:45 [PATCH 0/5] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-03  8:45 ` Boris BREZILLON
2014-09-03  8:45 ` Boris BREZILLON
2014-09-03  8:45 ` [PATCH 1/5] rtc: at91sam9: remove references to mach specific headers Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-08 17:32   ` Alexandre Belloni
2014-09-08 17:32     ` Alexandre Belloni
2014-09-08 17:32     ` Alexandre Belloni
2014-09-03  8:45 ` [PATCH 2/5] rtc: at91sam9: use standard readl/writel functions instead of raw versions Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-03  8:45 ` [PATCH 3/5] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-03  8:45 ` [PATCH 4/5] rtc: at91sam9: retain slow clock and check its rate Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-08 17:33   ` Alexandre Belloni
2014-09-08 17:33     ` Alexandre Belloni
2014-09-08 17:33     ` Alexandre Belloni
2014-09-08 19:22     ` Boris BREZILLON
2014-09-08 19:22       ` Boris BREZILLON
2014-09-08 19:37       ` Boris BREZILLON
2014-09-08 19:37         ` Boris BREZILLON
2014-09-08 19:37         ` Boris BREZILLON
2014-09-09  8:36         ` Nicolas Ferre
2014-09-09  8:36           ` Nicolas Ferre
2014-09-09  8:36           ` Nicolas Ferre
2014-09-03  8:45 ` [PATCH 5/5] rtc: at91sam9: add DT bindings documentation Boris BREZILLON
2014-09-03  8:45   ` Boris BREZILLON
2014-09-10 12:14   ` Johan Hovold
2014-09-10 12:14     ` Johan Hovold
2014-09-10 12:14     ` Johan Hovold
2014-09-10 12:43     ` Boris BREZILLON
2014-09-10 12:43       ` Boris BREZILLON
2014-09-10 12:43       ` Boris BREZILLON
2014-09-10 13:16       ` Johan Hovold
2014-09-10 13:16         ` Johan Hovold
2014-09-10 13:16         ` Johan Hovold
2014-09-10 13:20     ` Boris BREZILLON
2014-09-10 13:20       ` Boris BREZILLON
2014-09-10 13:20       ` Boris BREZILLON
2014-09-10 15:07       ` Johan Hovold [this message]
2014-09-10 15:07         ` Johan Hovold
2014-09-10 15:07         ` Johan Hovold
2014-09-10 15:31         ` Boris BREZILLON
2014-09-10 15:31           ` Boris BREZILLON
2014-09-10 15:52           ` Johan Hovold
2014-09-10 15:52             ` Johan Hovold
2014-09-10 15:52             ` Johan Hovold
2014-09-10 16:55             ` Nicolas Ferre
2014-09-10 16:55               ` Nicolas Ferre
2014-09-10 16:55               ` Nicolas Ferre
2014-09-10 15:35         ` Boris BREZILLON
2014-09-10 15:35           ` Boris BREZILLON
2014-09-10 15:35           ` Boris BREZILLON
2014-09-10 15:57           ` Johan Hovold
2014-09-10 15:57             ` Johan Hovold
2014-09-03  9:31 ` [PATCH 0/5] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-03  9:31   ` Boris BREZILLON
2014-09-03  9:31   ` Boris BREZILLON

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910150702.GK2974@localhost \
    --to=johan@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.