[Qemu-devel] [TRIVIAL][PATCH] libqos virtio: Increase ISR timeout

[Qemu-devel] [TRIVIAL][PATCH] libqos virtio: Increase ISR timeout

[Marc Marí]

Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
---
 tests/libqos/virtio.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c
index 128dbd0..9b6de2c 100644
--- a/tests/libqos/virtio.c
+++ b/tests/libqos/virtio.c
@@ -82,7 +82,7 @@ bool qvirtio_wait_queue_isr(const QVirtioBus *bus, QVirtioDevice *d,
                                             QVirtQueue *vq, uint64_t timeout)
 {
     do {
-        clock_step(10);
+        clock_step(100);
         if (bus->get_queue_isr_status(d, vq)) {
             break; /* It has ended */
         }
@@ -95,7 +95,7 @@ bool qvirtio_wait_config_isr(const QVirtioBus *bus, QVirtioDevice *d,
                                                             uint64_t timeout)
 {
     do {
-        clock_step(10);
+        clock_step(100);
         if (bus->get_config_isr_status(d)) {
             break; /* It has ended */
         }
-- 
1.7.10.4

Re: [Qemu-devel] [TRIVIAL][PATCH] libqos virtio: Increase ISR timeout

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

On Tue, Sep 09, 2014 at 11:25:38AM +0200, Marc Marí wrote:
> Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
> ---
>  tests/libqos/virtio.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Missing a commit description.  Please justify this patch.  Why do you
need to bump the clock step amount?

What was failing and why?

This information is important to have in the git commit history.
Otherwise we'll look back and not know why this patch was necessary.

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]