All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Andrew Victor <linux@maxim.org.za>,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, Johan Hovold <jhovold@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH v3 0/8] rtc: at91sam9: add DT support
Date: Thu, 11 Sep 2014 11:39:42 +0200	[thread overview]
Message-ID: <20140911093942.GA12295@localhost> (raw)
In-Reply-To: <1410425767-17874-1-git-send-email-boris.brezillon@free-electrons.com>

On Thu, Sep 11, 2014 at 10:55:59AM +0200, Boris BREZILLON wrote:

> Johan, let me know if this version addresses part of your concerns.

Looks good to me. I just have a few minor comments on two of the patches.

> I'm open to any suggestion/rework to address other previously discussed
> issues, as long as it does not end up in a dead-end (like the discussion
> you had last year):
>  - the fact that the RTT block could be used for something that is not
>    an RTC
>  - the fact that referencing the GPBR node and defining a GPBR register
>    number to store RTC time info could be considered as an HW config and
>    not an HW description and thus should not be described in the DT

No doubt.

>  - other things I don't remember :-)

Thanks,
Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Boris BREZILLON
	<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Nicolas Ferre
	<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
	Jean-Christophe Plagniol-Villard
	<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org>,
	Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Johan Hovold <jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Douglas Gilbert
	<dgilbert-qazKcTl6WRFWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v3 0/8] rtc: at91sam9: add DT support
Date: Thu, 11 Sep 2014 11:39:42 +0200	[thread overview]
Message-ID: <20140911093942.GA12295@localhost> (raw)
In-Reply-To: <1410425767-17874-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

On Thu, Sep 11, 2014 at 10:55:59AM +0200, Boris BREZILLON wrote:

> Johan, let me know if this version addresses part of your concerns.

Looks good to me. I just have a few minor comments on two of the patches.

> I'm open to any suggestion/rework to address other previously discussed
> issues, as long as it does not end up in a dead-end (like the discussion
> you had last year):
>  - the fact that the RTT block could be used for something that is not
>    an RTC
>  - the fact that referencing the GPBR node and defining a GPBR register
>    number to store RTC time info could be considered as an HW config and
>    not an HW description and thus should not be described in the DT

No doubt.

>  - other things I don't remember :-)

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/8] rtc: at91sam9: add DT support
Date: Thu, 11 Sep 2014 11:39:42 +0200	[thread overview]
Message-ID: <20140911093942.GA12295@localhost> (raw)
In-Reply-To: <1410425767-17874-1-git-send-email-boris.brezillon@free-electrons.com>

On Thu, Sep 11, 2014 at 10:55:59AM +0200, Boris BREZILLON wrote:

> Johan, let me know if this version addresses part of your concerns.

Looks good to me. I just have a few minor comments on two of the patches.

> I'm open to any suggestion/rework to address other previously discussed
> issues, as long as it does not end up in a dead-end (like the discussion
> you had last year):
>  - the fact that the RTT block could be used for something that is not
>    an RTC
>  - the fact that referencing the GPBR node and defining a GPBR register
>    number to store RTC time info could be considered as an HW config and
>    not an HW description and thus should not be described in the DT

No doubt.

>  - other things I don't remember :-)

Thanks,
Johan

  parent reply	other threads:[~2014-09-11  9:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  8:55 [PATCH v3 0/8] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-11  8:55 ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 1/8] rtc: at91sam9: remove references to mach specific headers Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 2/8] rtc: at91sam9: use standard readl/writel functions instead of raw versions Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 3/8] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 4/8] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 5/8] rtc: at91sam9: make use of syscon/regmap to access GPBR registers Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  9:41   ` Johan Hovold
2014-09-11  9:41     ` Johan Hovold
2014-09-11  9:55     ` Boris BREZILLON
2014-09-11  9:55       ` Boris BREZILLON
2014-09-11  9:55       ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 6/8] ARM: at91: add clk_lookup entry for RTT devices Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 7/8] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 8/8] rtc: at91sam9: add DT bindings documentation Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  9:42   ` Johan Hovold
2014-09-11  9:42     ` Johan Hovold
2014-09-11  9:56     ` Boris BREZILLON
2014-09-11  9:56       ` Boris BREZILLON
2014-09-11  9:56       ` Boris BREZILLON
2014-09-11  9:39 ` Johan Hovold [this message]
2014-09-11  9:39   ` [PATCH v3 0/8] rtc: at91sam9: add DT support Johan Hovold
2014-09-11  9:39   ` Johan Hovold
2014-09-11 10:06   ` Boris BREZILLON
2014-09-11 10:06     ` Boris BREZILLON
2014-09-11 10:06     ` Boris BREZILLON
2014-09-11 10:22     ` Johan Hovold
2014-09-11 10:22       ` Johan Hovold
2014-09-11 11:52     ` Nicolas Ferre
2014-09-11 11:52       ` Nicolas Ferre
2014-09-11 11:52       ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140911093942.GA12295@localhost \
    --to=johan@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dgilbert@interlog.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jhovold@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.